From 45ee7f45a70bab7d8532e91585c7596312bd4681 Mon Sep 17 00:00:00 2001
From: mechworrior <ni.tony.ym@gmail.com>
Date: Mon, 17 Oct 2022 16:00:25 +0900
Subject: [PATCH 1/4] FIX: add encoding as an attribute for LogFileHandler
 initialization

---
 apptools/logger/logger.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/apptools/logger/logger.py b/apptools/logger/logger.py
index d7bd5b37..43927d93 100644
--- a/apptools/logger/logger.py
+++ b/apptools/logger/logger.py
@@ -29,10 +29,10 @@ class LogFileHandler(RotatingFileHandler):
     """The default log file handler."""
 
     def __init__(
-        self, path, maxBytes=1000000, backupCount=3, level=None, formatter=None
+        self, path, maxBytes=1000000, backupCount=3, level=None, formatter=None, encoding=None
     ):
         RotatingFileHandler.__init__(
-            self, path, maxBytes=maxBytes, backupCount=3
+            self, path, maxBytes=maxBytes, backupCount=3, encoding=encoding
         )
 
         if level is None:

From 75200d3dcf3adf7e27fe5f7e51729f13dab45605 Mon Sep 17 00:00:00 2001
From: mechworrior <ni.tony.ym@gmail.com>
Date: Mon, 17 Oct 2022 16:19:02 +0900
Subject: [PATCH 2/4] FIX: Codestyle

---
 apptools/logger/logger.py | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/apptools/logger/logger.py b/apptools/logger/logger.py
index 43927d93..7c755091 100644
--- a/apptools/logger/logger.py
+++ b/apptools/logger/logger.py
@@ -29,7 +29,13 @@ class LogFileHandler(RotatingFileHandler):
     """The default log file handler."""
 
     def __init__(
-        self, path, maxBytes=1000000, backupCount=3, level=None, formatter=None, encoding=None
+        self,
+        path,
+        maxBytes=1000000,
+        backupCount=3,
+        level=None,
+        formatter=None,
+        encoding=None,
     ):
         RotatingFileHandler.__init__(
             self, path, maxBytes=maxBytes, backupCount=3, encoding=encoding

From 4ba9215de5235a182900d56c774ea7f75d0fb163 Mon Sep 17 00:00:00 2001
From: mechworrior <ni.tony.ym@gmail.com>
Date: Mon, 17 Oct 2022 17:17:49 +0900
Subject: [PATCH 3/4] ENH: Full support for 3.6 API

---
 apptools/logger/logger.py | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/apptools/logger/logger.py b/apptools/logger/logger.py
index 7c755091..936d8ce4 100644
--- a/apptools/logger/logger.py
+++ b/apptools/logger/logger.py
@@ -31,14 +31,22 @@ class LogFileHandler(RotatingFileHandler):
     def __init__(
         self,
         path,
+        mode="a",
         maxBytes=1000000,
         backupCount=3,
         level=None,
         formatter=None,
         encoding=None,
+        delay=False,
     ):
         RotatingFileHandler.__init__(
-            self, path, maxBytes=maxBytes, backupCount=3, encoding=encoding
+            self,
+            path=path,
+            mode=mode,
+            maxBytes=maxBytes,
+            backupCount=backupCount,
+            encoding=encoding,
+            delay=delay,
         )
 
         if level is None:

From b13ca8d2c55bf183d85a7bcdc09d716f2e298bcc Mon Sep 17 00:00:00 2001
From: Tony Ni <95213040+mechworrior@users.noreply.github.com>
Date: Mon, 17 Oct 2022 18:07:16 +0900
Subject: [PATCH 4/4] Update apptools/logger/logger.py

Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com>
---
 apptools/logger/logger.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/apptools/logger/logger.py b/apptools/logger/logger.py
index 936d8ce4..a441fed5 100644
--- a/apptools/logger/logger.py
+++ b/apptools/logger/logger.py
@@ -41,7 +41,7 @@ def __init__(
     ):
         RotatingFileHandler.__init__(
             self,
-            path=path,
+            filename=path,
             mode=mode,
             maxBytes=maxBytes,
             backupCount=backupCount,