From 09cf1786f66371ba45dadc55ba9f39cfd949d1ac Mon Sep 17 00:00:00 2001
From: Joris Vankerschaver <joris.vankerschaver@gmail.com>
Date: Sat, 18 May 2019 21:28:10 +0100
Subject: [PATCH 01/22] TST: test_time_scale.py

---
 chaco/scales/tests/test_time_scale.py | 736 +++++++++++++-------------
 1 file changed, 372 insertions(+), 364 deletions(-)

diff --git a/chaco/scales/tests/test_time_scale.py b/chaco/scales/tests/test_time_scale.py
index e89e746b4..7cc2e2de2 100644
--- a/chaco/scales/tests/test_time_scale.py
+++ b/chaco/scales/tests/test_time_scale.py
@@ -1,12 +1,10 @@
-
-
 import datetime
 import os
 import contextlib
-
-import six.moves as sm
+import unittest
 
 import numpy as np
+import numpy.testing as nptest
 
 from chaco.scales.time_scale import (
     tfrac, trange, TimeScale, CalendarScaleSystem)
@@ -73,350 +71,355 @@ def set_timezone(tz):
 # tfrac tests
 #----------------------------------------------------------------
 
-def test_tfrac_years_01():
-    with set_timezone(UTC):
+class TestTFrac(unittest.TestCase):
+
+    def test_tfrac_years_01(self):
+        with set_timezone(UTC):
+            t = 3601
+            (base, frac) = tfrac(t, years=1)
+            self.assertEqual(base, 0)
+            self.assertEqual(frac, 3601)
+
+    def test_tfrac_years_01_Alice_Springs(self):
+        # Australia/North (UTC+09:30, never DST)
+        with set_timezone(ALICE_SPRINGS):
+            t = 3601
+            (base, frac) = tfrac(t, years=1)
+            self.assertEqual(base, 3600 * -9.5)  # Alice Springs year start UTC timestamp
+            self.assertEqual(frac, 3600 * 10.5 + 1)  # 10:30:01 in the morning Jan 1
+
+    def test_tfrac_years_01_Honolulu(self):
+        # Pacific/Honolulu (UTC-10:00, never DST)
+        with set_timezone(HONOLULU):
+            t = 3601
+            (base, frac) = tfrac(t, years=1)
+            self.assertEqual(base, 3600 * (-365*24 + 10))  # previous Honolulu year start UTC timestamp
+            self.assertEqual(frac, 3600 * (364*24 + 15) + 1)  # 15:00:01 in the afternoon, Dec 31
+
+    def test_tfrac_years_02(self):
+        with set_timezone(UTC):
+            t = 3601
+            (base, frac) = tfrac(t, years=10)
+            self.assertEqual(base, 0)
+            self.assertEqual(frac, 3601)
+
+    def test_tfrac_years_02_Alice_Springs(self):
+        # Australia/North (UTC+09:30, never DST)
+        with set_timezone(ALICE_SPRINGS):
+            t = 3601
+            (base, frac) = tfrac(t, years=10)
+            self.assertEqual(base, 3600 * -9.5)  # Alice Springs decade start UTC timestamp
+            self.assertEqual(frac, 3600 * 10.5 + 1)  # 10:30:01 in the morning Jan 1
+
+    def test_tfrac_years_02_Honolulu(self):
+        # Pacific/Honolulu (UTC-10:00, never DST)
+        with set_timezone(HONOLULU):
+            t = 3601
+            (base, frac) = tfrac(t, years=10)
+            # previous Honolulu decade start UTC timestamp (including leap years)
+            self.assertEqual(base, 3600 * (-(365*10 + 3)*24 + 10))
+            # 15:00:01 in the afternoon, Dec 31, 9 years into decade
+            self.assertEqual(frac, 3600 * ((365*9+3 + 364)*24 + 15) + 1)
+
+    def test_tfrac_days_01(self):
+        with set_timezone(UTC):
+            t = 3601
+            (base, frac) = tfrac(t, days=1)
+            self.assertEqual(base, 0)
+            self.assertEqual(frac, 3601)
+
+    def test_tfrac_days_01_Alice_Springs(self):
+        # Australia/North (UTC+09:30, never DST)
+        with set_timezone(ALICE_SPRINGS):
+            t = 3601
+            (base, frac) = tfrac(t, days=1)
+            self.assertEqual(base, 3600 * -9.5)  # Alice Springs day start UTC timestamp
+            self.assertEqual(frac, 3600 * 10.5 + 1)  # 10:30:01 in the morning
+
+    def test_tfrac_days_01_Honolulu(self):
+        # Pacific/Honolulu (UTC-10:00, never DST)
+        with set_timezone(HONOLULU):
+            t = 3601
+            (base, frac) = tfrac(t, days=1)
+            self.assertEqual(base, 3600 * (-24 + 10))  # previous Honolulu day start UTC timestamp
+            self.assertEqual(frac, 3600 * 15 + 1)  # 15:00:01 in the afternoon
+
+    def test_tfrac_days_02(self):
+        with set_timezone(UTC):
+            t = 3*24.0*3600 + 1000.0
+            (base, frac) = tfrac(t, days=1)
+            self.assertEqual(base, 3600 * 24 * 3)
+            self.assertEqual(frac, 1000)
+
+    def test_tfrac_days_02_Alice_Springs(self):
+        # Australia/North (UTC+09:30, never DST)
+        with set_timezone(ALICE_SPRINGS):
+            t = 3*24.0*3600 + 1000.0
+            (base, frac) = tfrac(t, days=1)
+            self.assertEqual(base, 3600 * (24 * 3 - 9.5))
+            self.assertEqual(frac, 3600 * 9.5 + 1000)
+
+    def test_tfrac_days_02_Honolulu(self):
+        # Pacific/Honolulu (UTC-10:00, never DST)
+        with set_timezone(HONOLULU):
+            t = 3*24.0*3600 + 1000.0
+            (base, frac) = tfrac(t, days=1)
+            self.assertEqual(base, 3600 * (24 * 2 + 10))
+            self.assertEqual(frac, 3600 * (24 - 10) + 1000)
+
+    def test_tfrac_hours_01(self):
+        with set_timezone(UTC):
+            t = 3601
+            (base, frac) = tfrac(t, hours=1)
+            self.assertEqual(base, 3600)
+            self.assertEqual(frac, 1)
+
+    def test_tfrac_hours_01_Alice_Springs(self):
+        # Australia/North (UTC+09:30, never DST)
+        with set_timezone(ALICE_SPRINGS):
+            t = 3601
+            (base, frac) = tfrac(t, hours=1)
+            self.assertEqual(base, 1800)
+            self.assertEqual(frac, 1801)
+
+    def test_tfrac_hours_02(self):
+        with set_timezone(UTC):
+            t = 3601
+            (base, frac) = tfrac(t, hours=2)
+            self.assertEqual(base, 0)
+            self.assertEqual(frac, 3601)
+
+    def test_tfrac_hours_02_Alice_Springs(self):
+        # Australia/North (UTC+09:30, never DST)
+        with set_timezone(ALICE_SPRINGS):
+            t = 3601
+            (base, frac) = tfrac(t, hours=2)
+            self.assertEqual(base, 1800)
+            self.assertEqual(frac, 1801)
+
+    def test_tfrac_hours_03(self):
+        with set_timezone(UTC):
+            t = 3600 * 5.5
+            (base, frac) = tfrac(t, hours=2)
+            self.assertEqual(base, 3600 * 4)
+            self.assertEqual(frac, 3600 * 1.5)
+
+    def test_tfrac_hours_03_Alice_Springs(self):
+        # Australia/North (UTC+09:30, never DST)
+        with set_timezone(ALICE_SPRINGS):
+            t = 3600 * 5.5
+            (base, frac) = tfrac(t, hours=2)
+            self.assertEqual(base, 3600 * 4.5)
+            self.assertEqual(frac, 3600 * 1)
+
+    def test_tfrac_hours_04(self):
+        with set_timezone(UTC):
+            t = 3600 * 5.5
+            (base, frac) = tfrac(t, hours=3)
+            self.assertEqual(base, 3600 * 3.0)
+            self.assertEqual(frac, 3600 * 2.5)
+
+    def test_tfrac_hours_04_Alice_Springs(self):
+        # Australia/North (UTC+09:30, never DST)
+        with set_timezone(ALICE_SPRINGS):
+            t = 3600 * 5.5
+            (base, frac) = tfrac(t, hours=3)
+            self.assertEqual(base, 3600 * 5.5)
+            self.assertEqual(frac, 3600 * 0)
+
+    def test_tfrac_hours_05(self):
+        with set_timezone(UTC):
+            t = 3600 * 15.5
+            (base, frac) = tfrac(t, hours=6)
+            self.assertEqual(base, 3600 * 12.0)
+            self.assertEqual(frac, 3600 *  3.5)
+
+    def test_tfrac_hours_05_Alice_Springs(self):
+        # Australia/North (UTC+09:30, never DST)
+        with set_timezone(ALICE_SPRINGS):
+            t = 3600 * 15.5
+            (base, frac) = tfrac(t, hours=6)
+            self.assertEqual(base, 3600 * 14.5)
+            self.assertEqual(frac, 3600 *  1.0)
+
+    def test_tfrac_minutes_01(self):
         t = 3601
-        (base, frac) = tfrac(t, years=1)
-        assert base == 0
-        assert frac == 3601
+        (base, frac) = tfrac(t, minutes=1)
+        self.assertEqual(base, 3600)
+        self.assertEqual(frac, 1)
 
-def test_tfrac_years_01_Alice_Springs():
-    # Australia/North (UTC+09:30, never DST)
-    with set_timezone(ALICE_SPRINGS):
-        t = 3601
-        (base, frac) = tfrac(t, years=1)
-        assert base == 3600 * -9.5  # Alice Springs year start UTC timestamp
-        assert frac == 3600 * 10.5 + 1  # 10:30:01 in the morning Jan 1
+    def test_tfrac_minutes_02(self):
+        t = 123.5
+        (base, frac) = tfrac(t, minutes=1)
+        self.assertEqual(base, 120)
+        self.assertEqual(frac, 3.5)
 
-def test_tfrac_years_01_Honolulu():
-    # Pacific/Honolulu (UTC-10:00, never DST)
-    with set_timezone(HONOLULU):
+    def test_tfrac_seconds_01(self):
         t = 3601
-        (base, frac) = tfrac(t, years=1)
-        assert base == 3600 * (-365*24 + 10)  # previous Honolulu year start UTC timestamp
-        assert frac == 3600 * (364*24 + 15) + 1  # 15:00:01 in the afternoon, Dec 31
-
-def test_tfrac_years_02():
-    with set_timezone(UTC):
-        t = 3601
-        (base, frac) = tfrac(t, years=10)
-        assert base == 0
-        assert frac == 3601
-
-def test_tfrac_years_02_Alice_Springs():
-    # Australia/North (UTC+09:30, never DST)
-    with set_timezone(ALICE_SPRINGS):
-        t = 3601
-        (base, frac) = tfrac(t, years=10)
-        assert base == 3600 * -9.5  # Alice Springs decade start UTC timestamp
-        assert frac == 3600 * 10.5 + 1  # 10:30:01 in the morning Jan 1
-
-def test_tfrac_years_02_Honolulu():
-    # Pacific/Honolulu (UTC-10:00, never DST)
-    with set_timezone(HONOLULU):
-        t = 3601
-        (base, frac) = tfrac(t, years=10)
-        # previous Honolulu decade start UTC timestamp (including leap years)
-        assert base == 3600 * (-(365*10 + 3)*24 + 10)
-        # 15:00:01 in the afternoon, Dec 31, 9 years into decade
-        assert frac == 3600 * ((365*9+3 + 364)*24 + 15) + 1
-
-def test_tfrac_days_01():
-    with set_timezone(UTC):
-        t = 3601
-        (base, frac) = tfrac(t, days=1)
-        assert base == 0
-        assert frac == 3601
-
-def test_tfrac_days_01_Alice_Springs():
-    # Australia/North (UTC+09:30, never DST)
-    with set_timezone(ALICE_SPRINGS):
-        t = 3601
-        (base, frac) = tfrac(t, days=1)
-        assert base == 3600 * -9.5  # Alice Springs day start UTC timestamp
-        assert frac == 3600 * 10.5 + 1  # 10:30:01 in the morning
-
-def test_tfrac_days_01_Honolulu():
-    # Pacific/Honolulu (UTC-10:00, never DST)
-    with set_timezone(HONOLULU):
-        t = 3601
-        (base, frac) = tfrac(t, days=1)
-        assert base == 3600 * (-24 + 10)  # previous Honolulu day start UTC timestamp
-        assert frac == 3600 * 15 + 1  # 15:00:01 in the afternoon
-
-def test_tfrac_days_02():
-    with set_timezone(UTC):
-        t = 3*24.0*3600 + 1000.0
-        (base, frac) = tfrac(t, days=1)
-        assert base == 3600 * 24 * 3
-        assert frac == 1000
-
-def test_tfrac_days_02_Alice_Springs():
-    # Australia/North (UTC+09:30, never DST)
-    with set_timezone(ALICE_SPRINGS):
-        t = 3*24.0*3600 + 1000.0
-        (base, frac) = tfrac(t, days=1)
-        assert base == 3600 * (24 * 3 - 9.5)
-        assert frac == 3600 * 9.5 + 1000
-
-def test_tfrac_days_02_Honolulu():
-    # Pacific/Honolulu (UTC-10:00, never DST)
-    with set_timezone(HONOLULU):
-        t = 3*24.0*3600 + 1000.0
-        (base, frac) = tfrac(t, days=1)
-        assert base == 3600 * (24 * 2 + 10)
-        assert frac == 3600 * (24 - 10) + 1000
-
-def test_tfrac_hours_01():
-    with set_timezone(UTC):
-        t = 3601
-        (base, frac) = tfrac(t, hours=1)
-        assert base == 3600
-        assert frac == 1
-
-def test_tfrac_hours_01_Alice_Springs():
-    # Australia/North (UTC+09:30, never DST)
-    with set_timezone(ALICE_SPRINGS):
-        t = 3601
-        (base, frac) = tfrac(t, hours=1)
-        assert base == 1800
-        assert frac == 1801
-
-def test_tfrac_hours_02():
-    with set_timezone(UTC):
-        t = 3601
-        (base, frac) = tfrac(t, hours=2)
-        assert base == 0
-        assert frac == 3601
-
-def test_tfrac_hours_02_Alice_Springs():
-    # Australia/North (UTC+09:30, never DST)
-    with set_timezone(ALICE_SPRINGS):
-        t = 3601
-        (base, frac) = tfrac(t, hours=2)
-        assert base == 1800
-        assert frac == 1801
-
-def test_tfrac_hours_03():
-    with set_timezone(UTC):
-        t = 3600 * 5.5
-        (base, frac) = tfrac(t, hours=2)
-        assert base == 3600 * 4
-        assert frac == 3600 * 1.5
-
-def test_tfrac_hours_03_Alice_Springs():
-    # Australia/North (UTC+09:30, never DST)
-    with set_timezone(ALICE_SPRINGS):
-        t = 3600 * 5.5
-        (base, frac) = tfrac(t, hours=2)
-        assert base == 3600 * 4.5
-        assert frac == 3600 * 1
-
-def test_tfrac_hours_04():
-    with set_timezone(UTC):
-        t = 3600 * 5.5
-        (base, frac) = tfrac(t, hours=3)
-        assert base == 3600 * 3.0
-        assert frac == 3600 * 2.5
-
-def test_tfrac_hours_04_Alice_Springs():
-    # Australia/North (UTC+09:30, never DST)
-    with set_timezone(ALICE_SPRINGS):
-        t = 3600 * 5.5
-        (base, frac) = tfrac(t, hours=3)
-        assert base == 3600 * 5.5
-        assert frac == 3600 * 0
-
-def test_tfrac_hours_05():
-    with set_timezone(UTC):
-        t = 3600 * 15.5
-        (base, frac) = tfrac(t, hours=6)
-        assert base == 3600 * 12.0
-        assert frac == 3600 *  3.5
-
-def test_tfrac_hours_05_Alice_Springs():
-    # Australia/North (UTC+09:30, never DST)
-    with set_timezone(ALICE_SPRINGS):
-        t = 3600 * 15.5
-        (base, frac) = tfrac(t, hours=6)
-        assert base == 3600 * 14.5
-        assert frac == 3600 *  1.0
-
-def test_tfrac_minutes_01():
-    t = 3601
-    (base, frac) = tfrac(t, minutes=1)
-    assert base == 3600
-    assert frac == 1
-
-def test_tfrac_minutes_02():
-    t = 123.5
-    (base, frac) = tfrac(t, minutes=1)
-    assert base == 120
-    assert frac == 3.5
-
-def test_tfrac_seconds_01():
-    t = 3601
-    (base, frac) = tfrac(t, seconds=1)
-    assert base == 3601
-    assert frac == 0
-
-def test_tfrac_seconds_02():
-    t = 1.75
-    (base, frac) = tfrac(t, seconds=1)
-    assert base == 1
-    assert frac == 0.75
-
-def test_tfrac_milliseconds_01():
-    t = 123.5
-    (base, frac) = tfrac(t, milliseconds=1)
-    assert base == 123.5
-    assert frac == 0.0
-
-def test_tfrac_milliseconds_02():
-    t = 10.0625
-    (base, frac) = tfrac(t, milliseconds=1)
-    assert base == 10.062
-    assert frac ==  0.0005
-
-def test_tfrac_milliseconds_03():
-    t = 10.0625
-    (base, frac) = tfrac(t, milliseconds=10)
-    assert base == 10.06
-    assert frac ==  0.0025
-
-def test_tfrac_milliseconds_04():
-    t = 1.0078121
-    # Note that the last digit is lost due to rounding to microsecond scale.
-    (base, frac) = tfrac(t, milliseconds=1)
-    assert base == 1.007
-    assert frac == 0.000812
-
-def test_tfrac_milliseconds_05():
-    t = 1.0078056
-    # Note that the last digit is lost due to rounding to microsecond scale.
-    (base, frac) = tfrac(t, milliseconds=1)
-    assert base == 1.007
-    assert frac == 0.000806
+        (base, frac) = tfrac(t, seconds=1)
+        self.assertEqual(base, 3601)
+        self.assertEqual(frac, 0)
+
+    def test_tfrac_seconds_02(self):
+        t = 1.75
+        (base, frac) = tfrac(t, seconds=1)
+        self.assertEqual(base, 1)
+        self.assertEqual(frac, 0.75)
+
+    def test_tfrac_milliseconds_01(self):
+        t = 123.5
+        (base, frac) = tfrac(t, milliseconds=1)
+        self.assertEqual(base, 123.5)
+        self.assertEqual(frac, 0.0)
+
+    def test_tfrac_milliseconds_02(self):
+        t = 10.0625
+        (base, frac) = tfrac(t, milliseconds=1)
+        self.assertEqual(base, 10.062)
+        self.assertEqual(frac,  0.0005)
+
+    def test_tfrac_milliseconds_03(self):
+        t = 10.0625
+        (base, frac) = tfrac(t, milliseconds=10)
+        self.assertEqual(base, 10.06)
+        self.assertEqual(frac,  0.0025)
+
+    def test_tfrac_milliseconds_04(self):
+        t = 1.0078121
+        # Note that the last digit is lost due to rounding to microsecond scale.
+        (base, frac) = tfrac(t, milliseconds=1)
+        self.assertEqual(base, 1.007)
+        self.assertEqual(frac, 0.000812)
+
+    def test_tfrac_milliseconds_05(self):
+        t = 1.0078056
+        # Note that the last digit is lost due to rounding to microsecond scale.
+        (base, frac) = tfrac(t, milliseconds=1)
+        self.assertEqual(base, 1.007)
+        self.assertEqual(frac, 0.000806)
 
 
 #----------------------------------------------------------------
 # trange tests
 #----------------------------------------------------------------
 
-def test_trange_hours_01():
-    with set_timezone(UTC):
-        r = trange(0, 1, hours=1)
-        assert r == []
-
-def test_trange_hours_01_Alice_Springs():
-    # Australia/North (UTC+09:30, never DST)
-    with set_timezone(ALICE_SPRINGS):
-        r = trange(0, 1, hours=1)
-        assert r == []
-
-def test_trange_hours_01_Honolulu():
-    # Pacific/Honolulu (UTC-10:00, never DST)
-    with set_timezone(HONOLULU):
-        r = trange(0, 1, hours=1)
-        assert r == []
-
-def test_trange_hours_02():
-    with set_timezone(UTC):
-        r = trange(-1, 1, hours=1)
-        assert r == [0.0]
-
-def test_trange_hours_02_Alice_Springs():
-    # Australia/North (UTC+09:30, never DST)
-    with set_timezone(ALICE_SPRINGS):
-        r = trange(-1, 1, hours=1)
-        assert r == []
-
-def test_trange_hours_02_Honolulu():
-    # Pacific/Honolulu (UTC-10:00, never DST)
-    with set_timezone(HONOLULU):
-        r = trange(-1, 1, hours=1)
-        assert r == [0.0]
-
-def test_trange_hours_03():
-    with set_timezone(UTC):
-        r = trange(0, 3600, hours=1)
-        assert r == [0.0, 3600.0]
-
-def test_trange_hours_03_Alice_Springs():
-    # Australia/North (UTC+09:30, never DST)
-    with set_timezone(ALICE_SPRINGS):
-        r = trange(0, 3600, hours=1)
-        assert r == [1800.0]
-
-def test_trange_hours_03_Honolulu():
-    # Pacific/Honolulu (UTC-10:00, never DST)
-    with set_timezone(HONOLULU):
-        r = trange(0, 3600, hours=1)
-        assert r == [0.0, 3600.0]
-
-def test_trange_hours_04():
-    with set_timezone(UTC):
-        r = trange(-3600, 3600, hours=1)
-        assert r == [-3600.0, 0.0, 3600.0]
-
-def test_trange_hours_Alice_Springs():
-    # Australia/North (UTC+09:30, never DST)
-    with set_timezone(ALICE_SPRINGS):
-        r = trange(-3600, 3600, hours=1)
-        assert r == [-1800.0, 1800.0]
-
-def test_trange_hours_04_Honolulu():
-    # Pacific/Honolulu (UTC-10:00, never DST)
-    with set_timezone(HONOLULU):
-        r = trange(-3600, 3600, hours=1)
-        assert r == [-3600.0, 0.0, 3600.0]
-
-def test_trange_hours_05():
-    with set_timezone(UTC):
-        r = trange(-10, 3610, hours=1)
-        assert r == [0.0, 3600.0]
-
-def test_trange_hours_06():
-    with set_timezone(UTC):
-        r = trange(-10, 7210, hours=1)
-        assert r == [0.0, 3600.0, 7200.0]
-
-def test_trange_hours_07():
-    with set_timezone(UTC):
-        r = trange(-10, 7210, hours=2)
-        assert r == [0.0, 7200.0]
-
-def test_trange_hours_07_Alice_Springs():
-    # Australia/North (UTC+09:30, never DST)
-    with set_timezone(ALICE_SPRINGS):
-        r = trange(-10, 7210, hours=2)
-        assert r == [1800.0]
-
-def test_trange_hours_07_Honolulu():
-    # Pacific/Honolulu (UTC-10:00, never DST)
-    with set_timezone(HONOLULU):
-        r = trange(-10, 7210, hours=2)
-        assert r == [0.0, 7200.0]
-
-def test_trange_seconds_01():
-    r = trange(0, 1, seconds=1)
-    assert r == [0.0, 1.0]
-
-def test_trange_seconds_02():
-    r = trange(0, 10, seconds=1)
-    assert r == list(sm.xrange(11))
-
-def test_trange_seconds_03():
-    r = trange(0, 1.5, seconds=1)
-    assert r == [0.0, 1.0]
-
-def test_trange_milliseconds_01():
-    r = trange(0, 0.1, milliseconds=1)
-    assert np.allclose(np.array(r), np.linspace(0.0, 0.1, 101))
-
-def test_trange_milliseconds_02():
-    r = trange(-0.002, 0.001, milliseconds=1)
-    assert np.allclose(np.array(r), np.linspace(-0.002, 0.001, 4))
+class TestTRange(unittest.TestCase):
+
+    def test_trange_hours_01(self):
+        with set_timezone(UTC):
+            r = trange(0, 1, hours=1)
+            self.assertEqual(r, [])
+
+    def test_trange_hours_01_Alice_Springs(self):
+        # Australia/North (UTC+09:30, never DST)
+        with set_timezone(ALICE_SPRINGS):
+            r = trange(0, 1, hours=1)
+            self.assertEqual(r, [])
+
+    def test_trange_hours_01_Honolulu(self):
+        # Pacific/Honolulu (UTC-10:00, never DST)
+        with set_timezone(HONOLULU):
+            r = trange(0, 1, hours=1)
+            self.assertEqual(r, [])
+
+    def test_trange_hours_02(self):
+        with set_timezone(UTC):
+            r = trange(-1, 1, hours=1)
+            self.assertEqual(r, [0.0])
+
+    def test_trange_hours_02_Alice_Springs(self):
+        # Australia/North (UTC+09:30, never DST)
+        with set_timezone(ALICE_SPRINGS):
+            r = trange(-1, 1, hours=1)
+            self.assertEqual(r, [])
+
+    def test_trange_hours_02_Honolulu(self):
+        # Pacific/Honolulu (UTC-10:00, never DST)
+        with set_timezone(HONOLULU):
+            r = trange(-1, 1, hours=1)
+            self.assertEqual(r, [0.0])
+
+    def test_trange_hours_03(self):
+        with set_timezone(UTC):
+            r = trange(0, 3600, hours=1)
+            self.assertEqual(r, [0.0, 3600.0])
+
+    def test_trange_hours_03_Alice_Springs(self):
+        # Australia/North (UTC+09:30, never DST)
+        with set_timezone(ALICE_SPRINGS):
+            r = trange(0, 3600, hours=1)
+            self.assertEqual(r, [1800.0])
+
+    def test_trange_hours_03_Honolulu(self):
+        # Pacific/Honolulu (UTC-10:00, never DST)
+        with set_timezone(HONOLULU):
+            r = trange(0, 3600, hours=1)
+            self.assertEqual(r, [0.0, 3600.0])
+
+    def test_trange_hours_04(self):
+        with set_timezone(UTC):
+            r = trange(-3600, 3600, hours=1)
+            self.assertEqual(r, [-3600.0, 0.0, 3600.0])
+
+    def test_trange_hours_Alice_Springs(self):
+        # Australia/North (UTC+09:30, never DST)
+        with set_timezone(ALICE_SPRINGS):
+            r = trange(-3600, 3600, hours=1)
+            self.assertEqual(r, [-1800.0, 1800.0])
+
+    def test_trange_hours_04_Honolulu(self):
+        # Pacific/Honolulu (UTC-10:00, never DST)
+        with set_timezone(HONOLULU):
+            r = trange(-3600, 3600, hours=1)
+            self.assertEqual(r, [-3600.0, 0.0, 3600.0])
+
+    def test_trange_hours_05(self):
+        with set_timezone(UTC):
+            r = trange(-10, 3610, hours=1)
+            self.assertEqual(r, [0.0, 3600.0])
+
+    def test_trange_hours_06(self):
+        with set_timezone(UTC):
+            r = trange(-10, 7210, hours=1)
+            self.assertEqual(r, [0.0, 3600.0, 7200.0])
+
+    def test_trange_hours_07(self):
+        with set_timezone(UTC):
+            r = trange(-10, 7210, hours=2)
+            self.assertEqual(r, [0.0, 7200.0])
+
+    def test_trange_hours_07_Alice_Springs(self):
+        # Australia/North (UTC+09:30, never DST)
+        with set_timezone(ALICE_SPRINGS):
+            r = trange(-10, 7210, hours=2)
+            self.assertEqual(r, [1800.0])
+
+    def test_trange_hours_07_Honolulu(self):
+        # Pacific/Honolulu (UTC-10:00, never DST)
+        with set_timezone(HONOLULU):
+            r = trange(-10, 7210, hours=2)
+            self.assertEqual(r, [0.0, 7200.0])
+
+    def test_trange_seconds_01(self):
+        r = trange(0, 1, seconds=1)
+        self.assertEqual(r, [0.0, 1.0])
+
+    def test_trange_seconds_02(self):
+        r = trange(0, 10, seconds=1)
+        self.assertEqual(r, list(range(11)))
+
+    def test_trange_seconds_03(self):
+        r = trange(0, 1.5, seconds=1)
+        self.assertEqual(r, [0.0, 1.0])
+
+    def test_trange_milliseconds_01(self):
+        r = trange(0, 0.1, milliseconds=1)
+        nptest.assert_allclose(np.array(r), np.linspace(0.0, 0.1, 101))
+
+    def test_trange_milliseconds_02(self):
+        r = trange(-0.002, 0.001, milliseconds=1)
+        nptest.assert_allclose(
+            np.array(r), np.linspace(-0.002, 0.001, 4), rtol=1e-5, atol=1e-5)
 
 
 #----------------------------------------------------------------
@@ -425,42 +428,47 @@ def test_trange_milliseconds_02():
 
 # Could use more tests here... --WW
 
-def test_time_scale_seconds_01():
-    ts = TimeScale(seconds=1)
-    ticks = ts.ticks(0, 10)
-    assert (np.array(ticks) == np.linspace(0.0, 10.0, 11)).all()
+class TestTimeScale(unittest.TestCase):
 
-def test_time_scale_seconds_02():
-    ts = TimeScale(seconds=2)
-    ticks = ts.ticks(0, 10)
-    assert (np.array(ticks) == np.linspace(0.0, 10.0, 6)).all()
+    def test_time_scale_seconds_01(self):
+        ts = TimeScale(seconds=1)
+        ticks = ts.ticks(0, 10)
+        nptest.assert_array_equal(
+            np.array(ticks), np.linspace(0.0, 10.0, 11))
 
-def test_time_scale_milliseconds_01():
-    ts = TimeScale(milliseconds=1)
-    ticks = ts.ticks(0, 0.1)
-    assert len(ticks) == 11
-    assert (np.array(ticks) == np.linspace(0.0, 0.1, 11)).all()
+    def test_time_scale_seconds_02(self):
+        ts = TimeScale(seconds=2)
+        ticks = ts.ticks(0, 10)
+        nptest.assert_array_equal(np.array(ticks), np.linspace(0.0, 10.0, 6))
 
-def test_time_scale_with_formatter():
-    """ Regression test for TimeScale() with formatter keyword.
+    def test_time_scale_milliseconds_01(self):
+        ts = TimeScale(milliseconds=1)
+        ticks = ts.ticks(0, 0.1)
+        self.assertEqual(len(ticks), 11)
+        nptest.assert_array_equal(np.array(ticks), np.linspace(0.0, 0.1, 11))
 
-    Using the formatter keyword in the constructor of TimeScale
-    could raise a KeyError.  This test passes if no exception is
-    raised.
-    """
-    ts = TimeScale(seconds=1, formatter=TimeFormatter())
-    ts = TimeScale(minutes=1, formatter=TimeFormatter())
+    def test_time_scale_with_formatter(self):
+        """ Regression test for TimeScale() with formatter keyword.
+
+        Using the formatter keyword in the constructor of TimeScale
+        could raise a KeyError.  This test passes if no exception is
+        raised.
+        """
+        ts = TimeScale(seconds=1, formatter=TimeFormatter())
+        ts = TimeScale(minutes=1, formatter=TimeFormatter())
 
 
 #----------------------------------------------------------------
 # CalendarScaleSystem tests
 #----------------------------------------------------------------
 
-def test_calendar_scale_system_01():
-    css = CalendarScaleSystem()
-    ticks = css.ticks(0,10)
-    assert len(ticks) == 11
-    assert (np.array(ticks) == np.linspace(0,10,11)).all()
+class TestCalendarScaleSystem(unittest.TestCase):
+
+    def test_calendar_scale_system_01(self):
+        css = CalendarScaleSystem()
+        ticks = css.ticks(0,10)
+        self.assertEqual(len(ticks), 11)
+        nptest.assert_array_equal(np.array(ticks), np.linspace(0,10,11))
 
 
 # TODO: Add more tests of the ticks() and labels() methods of

From f78481336399b02566241b27eb1238debb89d6b8 Mon Sep 17 00:00:00 2001
From: Joris Vankerschaver <joris.vankerschaver@gmail.com>
Date: Sat, 18 May 2019 21:33:06 +0100
Subject: [PATCH 02/22] TST: test_formatters.py

---
 chaco/scales/tests/test_formatters.py | 132 +++++++++++++-------------
 1 file changed, 66 insertions(+), 66 deletions(-)

diff --git a/chaco/scales/tests/test_formatters.py b/chaco/scales/tests/test_formatters.py
index 756593e74..1cadb3946 100644
--- a/chaco/scales/tests/test_formatters.py
+++ b/chaco/scales/tests/test_formatters.py
@@ -1,4 +1,4 @@
-from __future__ import print_function
+import unittest
 
 from chaco.scales.formatters import strftimeEx, TimeFormatter
 
@@ -7,80 +7,80 @@
 # strftimeEx tests
 #----------------------------------------------------------------
 
-def test_strftimeEx_01():
-    t = 0.123
-    fmt = "%(ms)"
-    result = strftimeEx(fmt, t)
-    assert result == "123"
+class TestStrftimeEx(unittest.TestCase):
 
-def test_strftimeEx_02():
-    t = 0.123456
-    fmt = "%(us)"
-    result = strftimeEx(fmt, t)
-    assert result == "456"
+    def test_strftimeEx_01(self):
+        t = 0.123
+        fmt = "%(ms)"
+        result = strftimeEx(fmt, t)
+        self.assertEqual(result, "123")
 
-def test_strftimeEx_03():
-    t = 0.678910
-    fmt = "%(ms)"
-    # According to the code, the number that replaces (ms) is *rounded*,
-    # so this formt should give "679".
-    result = strftimeEx(fmt, t)
-    assert result == "679"
+    def test_strftimeEx_02(self):
+        t = 0.123456
+        fmt = "%(us)"
+        result = strftimeEx(fmt, t)
+        self.assertEqual(result, "456")
 
-def test_strftimeEx_04():
-    t = 0.678910
-    fmt = "%(ms).%(us)ms"
-    # According to the code, the number that replaces (ms) is *rounded*,
-    # so this formt should give "679.910ms".  (See the next test case for the
-    # correct way to do this.)
-    result = strftimeEx(fmt, t)
-    expected = "679.910ms"
-    assert result == expected
+    def test_strftimeEx_03(self):
+        t = 0.678910
+        fmt = "%(ms)"
+        # According to the code, the number that replaces (ms) is *rounded*,
+        # so this formt should give "679".
+        result = strftimeEx(fmt, t)
+        self.assertEqual(result, "679")
 
-def test_strftimeEx_04():
-    t = 0.678910
-    fmt = "%(ms_).%(us)ms"
-    # The format "%(ms_)" uses floor().
-    result = strftimeEx(fmt, t)
-    expected = "678.910ms"
-    print('result = "%s"  expected = "%s"' % (result, expected))
-    assert result == expected
+    def test_strftimeEx_04(self):
+        t = 0.678910
+        fmt = "%(ms).%(us)ms"
+        # According to the code, the number that replaces (ms) is *rounded*,
+        # so this formt should give "679.910ms".  (See the next test case for the
+        # correct way to do this.)
+        result = strftimeEx(fmt, t)
+        expected = "679.910ms"
+        self.assertEqual(result, expected)
 
-def test_strftimeEx_05():
-    """Test rounding that affects the seconds."""
-    t = 7.9999999
-    fmt = "%S %(ms_) %(us)"
-    result = strftimeEx(fmt, t)
-    expected = "08 000 000"
-    print('result = "%s"  expected = "%s"' % (result, expected))
-    assert result == expected
+    def test_strftimeEx_04(self):
+        t = 0.678910
+        fmt = "%(ms_).%(us)ms"
+        # The format "%(ms_)" uses floor().
+        result = strftimeEx(fmt, t)
+        expected = "678.910ms"
+        self.assertEqual(result, expected)
 
-def test_strftimeEx_06():
-    """Test rounding that affects the seconds."""
-    t = 7.9996
-    fmt = "%S %(ms)"
-    result = strftimeEx(fmt, t)
-    expected = "08 000"
-    print('result = "%s"  expected = "%s"' % (result, expected))
-    assert result == expected
+    def test_strftimeEx_05(self):
+        # Test rounding that affects the seconds.
+        t = 7.9999999
+        fmt = "%S %(ms_) %(us)"
+        result = strftimeEx(fmt, t)
+        expected = "08 000 000"
+        self.assertEqual(result, expected)
 
-def test_strftimeEx_07():
-    """Test rounding that affects the seconds."""
-    t = 7.9996
-    fmt = "%S %(ms_)"
-    result = strftimeEx(fmt, t)
-    expected = "07 999"
-    print('result = "%s"  expected = "%s"' % (result, expected))
-    assert result == expected
+    def test_strftimeEx_06(self):
+        # Test rounding that affects the seconds.
+        t = 7.9996
+        fmt = "%S %(ms)"
+        result = strftimeEx(fmt, t)
+        expected = "08 000"
+        self.assertEqual(result, expected)
+
+    def test_strftimeEx_07(self):
+        # Test rounding that affects the seconds.
+        t = 7.9996
+        fmt = "%S %(ms_)"
+        result = strftimeEx(fmt, t)
+        expected = "07 999"
+        self.assertEqual(result, expected)
 
 #----------------------------------------------------------------
 # TimeFormatter tests
 #----------------------------------------------------------------
 
-def test_time_formatter_01():
-    tf = TimeFormatter()
-    ticks = [10.005, 10.0053, 10.0056]
-    labels = tf.format(ticks, char_width=130)
-    expected = ["5.000ms", "5.300ms", "5.600ms"]
-    print("labels =", labels, " expected =", expected)
-    assert labels == expected
+class TestTimeFormatter(unittest.TestCase):
+
+    def test_time_formatter_01(self):
+        tf = TimeFormatter()
+        ticks = [10.005, 10.0053, 10.0056]
+        labels = tf.format(ticks, char_width=130)
+        expected = ["5.000ms", "5.300ms", "5.600ms"]
+        print("labels =", labels, " expected =", expected)
+        self.assertEqual(labels, expected)

From 420ddfba4b57a669cec68df3da904567bee7eee1 Mon Sep 17 00:00:00 2001
From: Joris Vankerschaver <joris.vankerschaver@gmail.com>
Date: Sat, 18 May 2019 21:38:09 +0100
Subject: [PATCH 03/22] TST: component_tests.py

---
 chaco/tests/component_tests.py | 52 -------------------------------
 chaco/tests/test_component.py  | 57 ++++++++++++++++++++++++++++++++++
 2 files changed, 57 insertions(+), 52 deletions(-)
 delete mode 100644 chaco/tests/component_tests.py
 create mode 100644 chaco/tests/test_component.py

diff --git a/chaco/tests/component_tests.py b/chaco/tests/component_tests.py
deleted file mode 100644
index a0ef52b7c..000000000
--- a/chaco/tests/component_tests.py
+++ /dev/null
@@ -1,52 +0,0 @@
-from enable.api import Component
-
-
-def test_padding_init():
-    """ Make sure that padding traits passed to the constructor get set in the
-    correct order.
-    """
-    c = Component()
-    assert c.padding_top == 0
-    assert c.padding_bottom == 0
-    assert c.padding_left == 0
-    assert c.padding_right == 0
-    c = Component(padding=50)
-    assert c.padding_top == 50
-    assert c.padding_bottom == 50
-    assert c.padding_left == 50
-    assert c.padding_right == 50
-    c = Component(padding=50, padding_top=15)
-    assert c.padding_top == 15
-    assert c.padding_bottom == 50
-    assert c.padding_left == 50
-    assert c.padding_right == 50
-    c = Component(padding=50, padding_bottom=15)
-    assert c.padding_top == 50
-    assert c.padding_bottom == 15
-    assert c.padding_left == 50
-    assert c.padding_right == 50
-    c = Component(padding=50, padding_left=15)
-    assert c.padding_top == 50
-    assert c.padding_bottom == 50
-    assert c.padding_left == 15
-    assert c.padding_right == 50
-    c = Component(padding=50, padding_right=15)
-    assert c.padding_top == 50
-    assert c.padding_bottom == 50
-    assert c.padding_left == 50
-    assert c.padding_right == 15
-
-def test_padding_trait_default():
-    class PaddedComponent(Component):
-        padding_top = 50
-    c = PaddedComponent()
-    assert c.padding_top == 50
-    assert c.padding_bottom == 0
-    assert c.padding_left == 0
-    assert c.padding_right == 0
-    c = PaddedComponent(padding_left=15)
-    assert c.padding_top == 50
-    assert c.padding_bottom == 0
-    assert c.padding_left == 15
-    assert c.padding_right == 0
-
diff --git a/chaco/tests/test_component.py b/chaco/tests/test_component.py
new file mode 100644
index 000000000..23c186d70
--- /dev/null
+++ b/chaco/tests/test_component.py
@@ -0,0 +1,57 @@
+import unittest
+
+from enable.api import Component
+
+
+class TestComponent(unittest.TestCase):
+    # FIXME: It is debatable whether this should remain part of Chaco,
+    # or be moved to Enable.
+    
+    def test_padding_init(self):
+        """ Make sure that padding traits passed to the constructor get set in the
+        correct order.
+        """
+        c = Component()
+        self.assertEqual(c.padding_top, 0)
+        self.assertEqual(c.padding_bottom, 0)
+        self.assertEqual(c.padding_left, 0)
+        self.assertEqual(c.padding_right, 0)
+        c = Component(padding=50)
+        self.assertEqual(c.padding_top, 50)
+        self.assertEqual(c.padding_bottom, 50)
+        self.assertEqual(c.padding_left, 50)
+        self.assertEqual(c.padding_right, 50)
+        c = Component(padding=50, padding_top=15)
+        self.assertEqual(c.padding_top, 15)
+        self.assertEqual(c.padding_bottom, 50)
+        self.assertEqual(c.padding_left, 50)
+        self.assertEqual(c.padding_right, 50)
+        c = Component(padding=50, padding_bottom=15)
+        self.assertEqual(c.padding_top, 50)
+        self.assertEqual(c.padding_bottom, 15)
+        self.assertEqual(c.padding_left, 50)
+        self.assertEqual(c.padding_right, 50)
+        c = Component(padding=50, padding_left=15)
+        self.assertEqual(c.padding_top, 50)
+        self.assertEqual(c.padding_bottom, 50)
+        self.assertEqual(c.padding_left, 15)
+        self.assertEqual(c.padding_right, 50)
+        c = Component(padding=50, padding_right=15)
+        self.assertEqual(c.padding_top, 50)
+        self.assertEqual(c.padding_bottom, 50)
+        self.assertEqual(c.padding_left, 50)
+        self.assertEqual(c.padding_right, 15)
+
+    def test_padding_trait_default(self):
+        class PaddedComponent(Component):
+            padding_top = 50
+        c = PaddedComponent()
+        self.assertEqual(c.padding_top, 50)
+        self.assertEqual(c.padding_bottom, 0)
+        self.assertEqual(c.padding_left, 0)
+        self.assertEqual(c.padding_right, 0)
+        c = PaddedComponent(padding_left=15)
+        self.assertEqual(c.padding_top, 50)
+        self.assertEqual(c.padding_bottom, 0)
+        self.assertEqual(c.padding_left, 15)
+        self.assertEqual(c.padding_right, 0)

From e4443fd5922c811911f91f42762a4549c1f8e52d Mon Sep 17 00:00:00 2001
From: Joris Vankerschaver <joris.vankerschaver@gmail.com>
Date: Sat, 18 May 2019 21:42:55 +0100
Subject: [PATCH 04/22] TST: test_image_utils.py

---
 chaco/tests/test_image_utils.py | 83 +++++++++++++++++----------------
 1 file changed, 42 insertions(+), 41 deletions(-)

diff --git a/chaco/tests/test_image_utils.py b/chaco/tests/test_image_utils.py
index 62ae83418..c8a33e22f 100644
--- a/chaco/tests/test_image_utils.py
+++ b/chaco/tests/test_image_utils.py
@@ -1,3 +1,5 @@
+import unittest
+
 from numpy.testing import assert_allclose, assert_equal
 
 from chaco.image_utils import trim_screen_rect, X_PARAMS, Y_PARAMS
@@ -18,44 +20,43 @@ def assert_midpoints_equal(bounds_list):
         assert_equal(x_mid[0], x_mid[1])
 
 
-def test_viewer_zoomed_into_single_pixel():
-    screen_rect = [0, 0, 100, 100]
-    view_rect = [10, 11, 1, 2]
-    new_rect = trim_screen_rect(screen_rect, view_rect, SINGLE_PIXEL)
-    assert_allclose(new_rect, view_rect)
-
-
-def test_viewer_at_corner_of_single_image():
-    offset = 0.2
-    screen_rect = [1, 1, 1, 1]
-    new_size = [1-offset, 1-offset]
-
-    down_right = [1+offset, 1+offset, 1, 1]
-    new_rect = trim_screen_rect(screen_rect, down_right, SINGLE_PIXEL)
-    expected_rect = down_right[:2] + new_size
-    assert_midpoints_equal((new_rect, expected_rect))
-
-    up_left = [1-offset, 1-offset, 1, 1]
-    new_rect = trim_screen_rect(screen_rect, up_left, SINGLE_PIXEL)
-    expected_rect = [1, 1] + new_size
-    assert_midpoints_equal((new_rect, expected_rect))
-
-
-def test_viewer_zoomed_into_four_pixel_intersection():
-    screen_rect = [0, 0, 100, 100]  # 4-pixel intersection at (50, 50)
-    view_rectangles = ([49, 49, 2, 2],  # Centered pixel intersection
-                       [49, 49, 3, 3],  # Intersection at 1/3 of view
-                       [49, 49, 2, 3])  # Intersection at 1/2, 1/3 of view
-    for view_rect in view_rectangles:
-        new_rect = trim_screen_rect(screen_rect, view_rect, FOUR_PIXELS)
-        yield assert_midpoints_equal, (new_rect, screen_rect)
-
-
-def test_viewer_at_corner_of_four_pixel_image():
-    offset = 0.2
-    screen_rect = [1, 1, 1, 1]
-    view_rectangles = ([1+offset, 1+offset, 1, 1],  # Shifted down and right
-                       [1-offset, 1-offset, 1, 1])  # Shifted up and left
-    for view_rect in view_rectangles:
-        new_rect = trim_screen_rect(screen_rect, view_rect, FOUR_PIXELS)
-        yield assert_equal, new_rect, screen_rect
+class TestImageUtils(unittest.TestCase):
+
+    def test_viewer_zoomed_into_single_pixel(self):
+        screen_rect = [0, 0, 100, 100]
+        view_rect = [10, 11, 1, 2]
+        new_rect = trim_screen_rect(screen_rect, view_rect, SINGLE_PIXEL)
+        assert_allclose(new_rect, view_rect)
+
+    def test_viewer_at_corner_of_single_image(self):
+        offset = 0.2
+        screen_rect = [1, 1, 1, 1]
+        new_size = [1-offset, 1-offset]
+
+        down_right = [1+offset, 1+offset, 1, 1]
+        new_rect = trim_screen_rect(screen_rect, down_right, SINGLE_PIXEL)
+        expected_rect = down_right[:2] + new_size
+        assert_midpoints_equal((new_rect, expected_rect))
+
+        up_left = [1-offset, 1-offset, 1, 1]
+        new_rect = trim_screen_rect(screen_rect, up_left, SINGLE_PIXEL)
+        expected_rect = [1, 1] + new_size
+        assert_midpoints_equal((new_rect, expected_rect))
+
+    def test_viewer_zoomed_into_four_pixel_intersection(self):
+        screen_rect = [0, 0, 100, 100]  # 4-pixel intersection at (50, 50)
+        view_rectangles = ([49, 49, 2, 2],  # Centered pixel intersection
+                           [49, 49, 3, 3],  # Intersection at 1/3 of view
+                           [49, 49, 2, 3])  # Intersection at 1/2, 1/3 of view
+        for view_rect in view_rectangles:
+            new_rect = trim_screen_rect(screen_rect, view_rect, FOUR_PIXELS)
+            assert_midpoints_equal((new_rect, screen_rect))
+
+    def test_viewer_at_corner_of_four_pixel_image(self):
+        offset = 0.2
+        screen_rect = [1, 1, 1, 1]
+        view_rectangles = ([1+offset, 1+offset, 1, 1],  # Shifted down and right
+                           [1-offset, 1-offset, 1, 1])  # Shifted up and left
+        for view_rect in view_rectangles:
+            new_rect = trim_screen_rect(screen_rect, view_rect, FOUR_PIXELS)
+            assert_equal(new_rect, screen_rect)

From 1c6ed164385883277af78289b382d126f94ce4fb Mon Sep 17 00:00:00 2001
From: Joris Vankerschaver <joris.vankerschaver@gmail.com>
Date: Sat, 18 May 2019 21:48:08 +0100
Subject: [PATCH 05/22] TST: test_image_plot.py

---
 chaco/tests/test_image_plot.py | 129 +++++++++++++++------------------
 1 file changed, 58 insertions(+), 71 deletions(-)

diff --git a/chaco/tests/test_image_plot.py b/chaco/tests/test_image_plot.py
index 80cfb384d..8e6ae9138 100644
--- a/chaco/tests/test_image_plot.py
+++ b/chaco/tests/test_image_plot.py
@@ -1,5 +1,3 @@
-from __future__ import print_function
-
 import os
 
 import tempfile
@@ -91,16 +89,6 @@ def calculate_rms(image_result, expected_image):
     return rms
 
 
-def verify_result_image(input_image, expected_image, **plot_kwargs):
-    # These tests were written assuming uint8 inputs.
-    assert input_image.dtype == np.uint8
-    assert expected_image.dtype == np.uint8
-    image_result = rendered_image_result(input_image, **plot_kwargs)
-    rms = calculate_rms(image_result, expected_image)
-    print("RMS =", rms)
-    assert rms < MAX_RMS_ERROR
-
-
 def plot_comparison(input_image, expected_image, **plot_kwargs):
     import matplotlib.pyplot as plt
 
@@ -116,62 +104,61 @@ def plot_comparison(input_image, expected_image, **plot_kwargs):
     plt.show()
 
 
-@unittest.skipIf(six.PY3, "Bug in the image plotter in python 3. See GH enthought/enable #95.")
-def test_horizontal_top_left():
-    # Horizontal orientation with top left origin renders original image.
-    verify_result_image(RGB, IMAGE, origin='top left')
-
-
-@unittest.skipIf(six.PY3, "Bug in the image plotter in python 3. See GH enthought/enable #95.")
-def test_horizontal_bottom_left():
-    # Horizontal orientation with bottom left origin renders a vertically
-    # flipped image.
-    verify_result_image(RGB, IMAGE[::-1], origin='bottom left')
-
-
-@unittest.skipIf(six.PY3, "Bug in the image plotter in python 3. See GH enthought/enable #95.")
-def test_horizontal_top_right():
-    # Horizontal orientation with top right origin renders a horizontally
-    # flipped image.
-    verify_result_image(RGB, IMAGE[:, ::-1], origin='top right')
-
-
-@unittest.skipIf(six.PY3, "Bug in the image plotter in python 3. See GH enthought/enable #95.")
-def test_horizontal_bottom_right():
-    # Horizontal orientation with top right origin renders an image flipped
-    # horizontally and vertically.
-    verify_result_image(RGB, IMAGE[::-1, ::-1], origin='bottom right')
-
-
-@unittest.skipIf(six.PY3, "Bug in the image plotter in python 3. See GH enthought/enable #95.")
-def test_vertical_top_left():
-    # Vertical orientation with top left origin renders transposed image.
-    verify_result_image(RGB, IMAGE.T, origin='top left', orientation='v')
-
-
-@unittest.skipIf(six.PY3, "Bug in the image plotter in python 3. See GH enthought/enable #95.")
-def test_vertical_bottom_left():
-    # Vertical orientation with bottom left origin renders transposed image
-    # that is vertically flipped.
-    verify_result_image(RGB, (IMAGE.T)[::-1],
-                        origin='bottom left', orientation='v')
-
-
-@unittest.skipIf(six.PY3, "Bug in the image plotter in python 3. See GH enthought/enable #95.")
-def test_vertical_top_right():
-    # Vertical orientation with top right origin renders transposed image
-    # that is horizontally flipped.
-    verify_result_image(RGB, (IMAGE.T)[:, ::-1],
-                        origin='top right', orientation='v')
-
-
-@unittest.skipIf(six.PY3, "Bug in the image plotter in python 3. See GH enthought/enable #95.")
-def test_vertical_bottom_right():
-    # Vertical orientation with bottom right origin renders transposed image
-    # that is flipped vertically and horizontally.
-    verify_result_image(RGB, (IMAGE.T)[::-1, ::-1],
-                        origin='bottom right', orientation='v')
-
-
-if __name__ == "__main__":
-    np.testing.run_module_suite()
+class TestResultImage(unittest.TestCase):
+
+    def verify_result_image(self, input_image, expected_image, **plot_kwargs):
+        # These tests were written assuming uint8 inputs.
+        self.assertEqual(input_image.dtype, np.uint8)
+        self.assertEqual(expected_image.dtype, np.uint8)
+        image_result = rendered_image_result(input_image, **plot_kwargs)
+        rms = calculate_rms(image_result, expected_image)
+        self.assertLess(rms, MAX_RMS_ERROR)
+
+    @unittest.skipIf(six.PY3, "Bug in the image plotter in python 3. See GH enthought/enable #95.")
+    def test_horizontal_top_left(self):
+        # Horizontal orientation with top left origin renders original image.
+        self.verify_result_image(RGB, IMAGE, origin='top left')
+
+    @unittest.skipIf(six.PY3, "Bug in the image plotter in python 3. See GH enthought/enable #95.")
+    def test_horizontal_bottom_left(self):
+        # Horizontal orientation with bottom left origin renders a vertically
+        # flipped image.
+        self.verify_result_image(RGB, IMAGE[::-1], origin='bottom left')
+
+    @unittest.skipIf(six.PY3, "Bug in the image plotter in python 3. See GH enthought/enable #95.")
+    def test_horizontal_top_right(self):
+        # Horizontal orientation with top right origin renders a horizontally
+        # flipped image.
+        self.verify_result_image(RGB, IMAGE[:, ::-1], origin='top right')
+
+    @unittest.skipIf(six.PY3, "Bug in the image plotter in python 3. See GH enthought/enable #95.")
+    def test_horizontal_bottom_right(self):
+        # Horizontal orientation with top right origin renders an image flipped
+        # horizontally and vertically.
+        self.verify_result_image(RGB, IMAGE[::-1, ::-1], origin='bottom right')
+
+    @unittest.skipIf(six.PY3, "Bug in the image plotter in python 3. See GH enthought/enable #95.")
+    def test_vertical_top_left(self):
+        # Vertical orientation with top left origin renders transposed image.
+        self.verify_result_image(RGB, IMAGE.T, origin='top left', orientation='v')
+
+    @unittest.skipIf(six.PY3, "Bug in the image plotter in python 3. See GH enthought/enable #95.")
+    def test_vertical_bottom_left(self):
+        # Vertical orientation with bottom left origin renders transposed image
+        # that is vertically flipped.
+        self.verify_result_image(RGB, (IMAGE.T)[::-1],
+                                 origin='bottom left', orientation='v')
+
+    @unittest.skipIf(six.PY3, "Bug in the image plotter in python 3. See GH enthought/enable #95.")
+    def test_vertical_top_right(self):
+        # Vertical orientation with top right origin renders transposed image
+        # that is horizontally flipped.
+        self.verify_result_image(RGB, (IMAGE.T)[:, ::-1],
+                                 origin='top right', orientation='v')
+
+    @unittest.skipIf(six.PY3, "Bug in the image plotter in python 3. See GH enthought/enable #95.")
+    def test_vertical_bottom_right(self):
+        # Vertical orientation with bottom right origin renders transposed image
+        # that is flipped vertically and horizontally.
+        self.verify_result_image(RGB, (IMAGE.T)[::-1, ::-1],
+                                 origin='bottom right', orientation='v')

From 3b4fffa0245cf05ffe8e9d5367a77eb2a12b04cb Mon Sep 17 00:00:00 2001
From: Joris Vankerschaver <joris.vankerschaver@gmail.com>
Date: Sat, 18 May 2019 21:55:32 +0100
Subject: [PATCH 06/22] TST: create_2d_test_case.py

---
 chaco/tests_with_backend/__init__.py          |   0
 .../tests_with_backend/create_2d_test_case.py | 150 -----------------
 chaco/tests_with_backend/test_2d_case.py      | 153 ++++++++++++++++++
 3 files changed, 153 insertions(+), 150 deletions(-)
 create mode 100644 chaco/tests_with_backend/__init__.py
 delete mode 100644 chaco/tests_with_backend/create_2d_test_case.py
 create mode 100644 chaco/tests_with_backend/test_2d_case.py

diff --git a/chaco/tests_with_backend/__init__.py b/chaco/tests_with_backend/__init__.py
new file mode 100644
index 000000000..e69de29bb
diff --git a/chaco/tests_with_backend/create_2d_test_case.py b/chaco/tests_with_backend/create_2d_test_case.py
deleted file mode 100644
index 00be21da7..000000000
--- a/chaco/tests_with_backend/create_2d_test_case.py
+++ /dev/null
@@ -1,150 +0,0 @@
-from __future__ import with_statement
-
-from chaco.api import Plot, ArrayPlotData
-
-from traits.api import HasTraits, Instance
-from enable.component_editor import ComponentEditor
-from traitsui.api import Item, View
-
-import numpy as np
-
-import nose
-from chaco.tests._tools import store_exceptions_on_all_threads, assert_raises
-
-
-class PlotViewer(HasTraits):
-    plot = Instance(Plot)
-    traits_view = View(Item('plot', editor=ComponentEditor()))
-
-
-def test_bounds_2d_case():
-    # test for bug: contour and image plots should support the case where
-    # xbounds and ybounds are 2d arrays resulting from meshgrids
-
-    xs = np.linspace(-10,10,200)
-    ys = np.linspace(-10,10,400)
-    x, y = np.meshgrid(xs,ys)
-    z = x + y
-
-    plotdata = ArrayPlotData()
-    plotdata.set_data("z", z)
-
-    plot = Plot(plotdata)
-    plot.contour_plot("z", xbounds=x, ybounds=y)
-
-    # try to display it, that's when the exception is raised
-    with store_exceptions_on_all_threads():
-        pv = PlotViewer(plot=plot)
-        pv.edit_traits()
-
-
-def test_process_2d_bounds_cell_plot():
-    # behavior: _process_2d_bounds accepts all possible ways to set x and y
-    # bounds in 2d plots and returns a 1d array with equally spaced
-    # intervals between the lower and upper bound of the data. The number
-    # of elements in the 1d array must be of one element larger than the
-    # shape of the data, because this is cell data.
-
-    height, width = 20, 10
-    array_data = np.ones(shape=(height, width))
-    plot = Plot()
-
-    # bounds is None : infer from array_data shape
-    xs = plot._process_2d_bounds(None, array_data, 1, cell_plot=True)
-    assert xs.shape[0] == width + 1
-    ys = plot._process_2d_bounds(None, array_data, 0, cell_plot=True)
-    assert ys.shape[0] == height + 1
-
-    # bounds is a tuple : it defines lower and upper range
-    bounds = (1.0, 100.0)
-    xs = plot._process_2d_bounds(bounds, array_data, 1, cell_plot=True)
-    assert xs.shape[0] == width + 1
-    assert xs[0] == bounds[0] and xs[-1] == bounds[1]
-
-    # bounds is a 1D array: the first and last elements are used to create
-    # equally spaced intervals. Bounds must be of one element larger than the
-    # corresponding axis in array_data, or it will raise a Value error
-    bounds = np.zeros((height+1, ))
-    bounds[0], bounds[-1] = 0.2, 21.3
-    ys = plot._process_2d_bounds(bounds, array_data, 0, cell_plot=True)
-    assert ys.shape[0] == height + 1
-    assert ys[0] == bounds[0] and ys[-1] == bounds[-1]
-    with assert_raises(ValueError):
-        bounds = np.zeros((width // 2, ))
-        plot._process_2d_bounds(bounds, array_data, 0, cell_plot=True)
-
-    # bounds is a 2D array: the first and last elements along the appropriate
-    # axis are used to create equally spaced intervals.
-    # The size of the bounds must be the same as the data array, or this
-    # sill raise a ValueError
-    xbounds, ybounds = np.meshgrid(np.arange(width+1), np.arange(height+1))
-
-    xs = plot._process_2d_bounds(xbounds, array_data, 1, cell_plot=True)
-    assert xs.shape[0] == width + 1
-    assert xs[0] == xbounds[0,0] and xs[-1] == xbounds[0,-1]
-    with assert_raises(ValueError):
-        plot._process_2d_bounds(xbounds[:, :5], array_data, 1, cell_plot=True)
-
-    ys = plot._process_2d_bounds(ybounds, array_data, 0, cell_plot=True)
-    assert ys.shape[0] == height + 1
-    assert ys[0] == ybounds[0,0] and ys[-1] == ybounds[-1,0]
-    with assert_raises(ValueError):
-        plot._process_2d_bounds(ybounds[:5, :], array_data, 0, cell_plot=True)
-
-
-def test_process_2d_bounds_vertex_data():
-    # behavior: _process_2d_bounds accepts all possible ways to set x and y
-    # bounds in 2d plots and returns a 1d array with equally spaced
-    # intervals between the lower and upper bound of the data. The number
-    # of elements in the 1d array must be the same as the shape of the data,
-    # because this is vertex data.
-
-    height, width = 20, 10
-    array_data = np.ones(shape=(height, width))
-    plot = Plot()
-
-    # bounds is None : infer from array_data shape
-    xs = plot._process_2d_bounds(None, array_data, 1, cell_plot=False)
-    assert xs.shape[0] == width
-    ys = plot._process_2d_bounds(None, array_data, 0, cell_plot=False)
-    assert ys.shape[0] == height
-
-    # bounds is a tuple : it defines lower and upper range
-    bounds = (1.0, 100.0)
-    xs = plot._process_2d_bounds(bounds, array_data, 1, cell_plot=False)
-    assert xs.shape[0] == width
-    assert xs[0] == bounds[0] and xs[-1] == bounds[1]
-
-    # bounds is a 1D array: the first and last elements are used to create
-    # equally spaced intervals. Bounds must be of one element larger than the
-    # corresponding axis in array_data, or it will raise a Value error
-    bounds = np.zeros((height, ))
-    bounds[0], bounds[-1] = 0.2, 21.3
-    ys = plot._process_2d_bounds(bounds, array_data, 0, cell_plot=False)
-    assert ys.shape[0] == height
-    assert ys[0] == bounds[0] and ys[-1] == bounds[-1]
-    with assert_raises(ValueError):
-        bounds = np.zeros((width // 2, ))
-        plot._process_2d_bounds(bounds, array_data, 0, cell_plot=False)
-
-    # bounds is a 2D array: the first and last elements along the appropriate
-    # axis are used to create equally spaced intervals.
-    # The size of the bounds must be the same as the data array, or this
-    # sill raise a ValueError
-    xbounds, ybounds = np.meshgrid(np.arange(width), np.arange(height))
-
-    xs = plot._process_2d_bounds(xbounds, array_data, 1, cell_plot=False)
-    assert xs.shape[0] == width
-    assert xs[0] == xbounds[0,0] and xs[-1] == xbounds[0,-1]
-    with assert_raises(ValueError):
-        plot._process_2d_bounds(xbounds[:, :5], array_data, 1, cell_plot=False)
-
-    ys = plot._process_2d_bounds(ybounds, array_data, 0, cell_plot=False)
-    assert ys.shape[0] == height
-    assert ys[0] == ybounds[0,0] and ys[-1] == ybounds[-1,0]
-    with assert_raises(ValueError):
-        plot._process_2d_bounds(ybounds[:5, :], array_data, 0, cell_plot=False)
-
-
-if __name__ == '__main__':
-    nose.main()
diff --git a/chaco/tests_with_backend/test_2d_case.py b/chaco/tests_with_backend/test_2d_case.py
new file mode 100644
index 000000000..068cca761
--- /dev/null
+++ b/chaco/tests_with_backend/test_2d_case.py
@@ -0,0 +1,153 @@
+import unittest
+
+from chaco.api import Plot, ArrayPlotData
+
+from traits.api import HasTraits, Instance
+from enable.component_editor import ComponentEditor
+from traitsui.api import Item, View
+
+import numpy as np
+
+from chaco.tests._tools import store_exceptions_on_all_threads, assert_raises
+
+
+class PlotViewer(HasTraits):
+    plot = Instance(Plot)
+    traits_view = View(Item('plot', editor=ComponentEditor()))
+
+
+class Test2DCase(unittest.TestCase):
+
+    def test_bounds_2d_case(self):
+        # test for bug: contour and image plots should support the case where
+        # xbounds and ybounds are 2d arrays resulting from meshgrids
+
+        xs = np.linspace(-10,10,200)
+        ys = np.linspace(-10,10,400)
+        x, y = np.meshgrid(xs,ys)
+        z = x + y
+
+        plotdata = ArrayPlotData()
+        plotdata.set_data("z", z)
+
+        plot = Plot(plotdata)
+        plot.contour_plot("z", xbounds=x, ybounds=y)
+
+        # try to display it, that's when the exception is raised
+        with store_exceptions_on_all_threads():
+            pv = PlotViewer(plot=plot)
+            pv.edit_traits()
+
+    def test_process_2d_bounds_cell_plot(self):
+        # behavior: _process_2d_bounds accepts all possible ways to set x and y
+        # bounds in 2d plots and returns a 1d array with equally spaced
+        # intervals between the lower and upper bound of the data. The number
+        # of elements in the 1d array must be of one element larger than the
+        # shape of the data, because this is cell data.
+
+        height, width = 20, 10
+        array_data = np.ones(shape=(height, width))
+        plot = Plot()
+
+        # bounds is None : infer from array_data shape
+        xs = plot._process_2d_bounds(None, array_data, 1, cell_plot=True)
+        self.assertEqual(xs.shape[0], width + 1)
+        ys = plot._process_2d_bounds(None, array_data, 0, cell_plot=True)
+        self.assertEqual(ys.shape[0], height + 1)
+
+        # bounds is a tuple : it defines lower and upper range
+        bounds = (1.0, 100.0)
+        xs = plot._process_2d_bounds(bounds, array_data, 1, cell_plot=True)
+        self.assertEqual(xs.shape[0], width + 1)
+        self.assertEqual(xs[0], bounds[0])
+        self.assertEqual(xs[-1], bounds[1])
+
+        # bounds is a 1D array: the first and last elements are used to create
+        # equally spaced intervals. Bounds must be of one element larger than the
+        # corresponding axis in array_data, or it will raise a Value error
+        bounds = np.zeros((height+1, ))
+        bounds[0], bounds[-1] = 0.2, 21.3
+        ys = plot._process_2d_bounds(bounds, array_data, 0, cell_plot=True)
+        self.assertEqual(ys.shape[0], height + 1)
+        self.assertEqual(ys[0], bounds[0])
+        self.assertEqual(ys[-1], bounds[-1])
+        with assert_raises(ValueError):
+            bounds = np.zeros((width // 2, ))
+            plot._process_2d_bounds(bounds, array_data, 0, cell_plot=True)
+
+        # bounds is a 2D array: the first and last elements along the appropriate
+        # axis are used to create equally spaced intervals.
+        # The size of the bounds must be the same as the data array, or this
+        # sill raise a ValueError
+        xbounds, ybounds = np.meshgrid(np.arange(width+1), np.arange(height+1))
+
+        xs = plot._process_2d_bounds(xbounds, array_data, 1, cell_plot=True)
+        self.assertEqual(xs.shape[0], width + 1)
+        self.assertEqual(xs[0], xbounds[0,0])
+        self.assertEqual(xs[-1], xbounds[0,-1])
+        with assert_raises(ValueError):
+            plot._process_2d_bounds(xbounds[:, :5], array_data, 1, cell_plot=True)
+
+        ys = plot._process_2d_bounds(ybounds, array_data, 0, cell_plot=True)
+        self.assertEqual(ys.shape[0], height + 1)
+        self.assertEqual(ys[0], ybounds[0,0])
+        self.assertEqual(ys[-1], ybounds[-1,0])
+        with assert_raises(ValueError):
+            plot._process_2d_bounds(ybounds[:5, :], array_data, 0, cell_plot=True)
+
+    def test_process_2d_bounds_vertex_data(self):
+        # behavior: _process_2d_bounds accepts all possible ways to set x and y
+        # bounds in 2d plots and returns a 1d array with equally spaced
+        # intervals between the lower and upper bound of the data. The number
+        # of elements in the 1d array must be the same as the shape of the data,
+        # because this is vertex data.
+
+        height, width = 20, 10
+        array_data = np.ones(shape=(height, width))
+        plot = Plot()
+
+        # bounds is None : infer from array_data shape
+        xs = plot._process_2d_bounds(None, array_data, 1, cell_plot=False)
+        self.assertEqual(xs.shape[0], width)
+        ys = plot._process_2d_bounds(None, array_data, 0, cell_plot=False)
+        self.assertEqual(ys.shape[0], height)
+
+        # bounds is a tuple : it defines lower and upper range
+        bounds = (1.0, 100.0)
+        xs = plot._process_2d_bounds(bounds, array_data, 1, cell_plot=False)
+        self.assertEqual(xs.shape[0], width)
+        self.assertEqual(xs[0], bounds[0])
+        self.assertEqual(xs[-1], bounds[1])
+
+        # bounds is a 1D array: the first and last elements are used to create
+        # equally spaced intervals. Bounds must be of one element larger than the
+        # corresponding axis in array_data, or it will raise a Value error
+        bounds = np.zeros((height, ))
+        bounds[0], bounds[-1] = 0.2, 21.3
+        ys = plot._process_2d_bounds(bounds, array_data, 0, cell_plot=False)
+        self.assertEqual(ys.shape[0], height)
+        self.assertEqual(ys[0], bounds[0])
+        self.assertEqual(ys[-1], bounds[-1])
+        with assert_raises(ValueError):
+            bounds = np.zeros((width // 2, ))
+            plot._process_2d_bounds(bounds, array_data, 0, cell_plot=False)
+
+        # bounds is a 2D array: the first and last elements along the appropriate
+        # axis are used to create equally spaced intervals.
+        # The size of the bounds must be the same as the data array, or this
+        # sill raise a ValueError
+        xbounds, ybounds = np.meshgrid(np.arange(width), np.arange(height))
+
+        xs = plot._process_2d_bounds(xbounds, array_data, 1, cell_plot=False)
+        self.assertEqual(xs.shape[0], width)
+        self.assertEqual(xs[0], xbounds[0,0])
+        self.assertEqual(xs[-1], xbounds[0,-1])
+        with assert_raises(ValueError):
+            plot._process_2d_bounds(xbounds[:, :5], array_data, 1, cell_plot=False)
+
+        ys = plot._process_2d_bounds(ybounds, array_data, 0, cell_plot=False)
+        self.assertEqual(ys.shape[0], height)
+        self.assertEqual(ys[0], ybounds[0,0])
+        self.assertEqual(ys[-1], ybounds[-1,0])
+        with assert_raises(ValueError):
+            plot._process_2d_bounds(ybounds[:5, :], array_data, 0, cell_plot=False)

From bb6f2072abc676746f6ba8827d886c7e489a9bc2 Mon Sep 17 00:00:00 2001
From: Joris Vankerschaver <joris.vankerschaver@gmail.com>
Date: Sat, 18 May 2019 21:57:52 +0100
Subject: [PATCH 07/22] TST: highlight_tool_test_case.py

---
 .../highlight_tool_test_case.py               | 53 -------------------
 .../tests_with_backend/test_highlight_tool.py | 51 ++++++++++++++++++
 2 files changed, 51 insertions(+), 53 deletions(-)
 delete mode 100644 chaco/tests_with_backend/highlight_tool_test_case.py
 create mode 100644 chaco/tests_with_backend/test_highlight_tool.py

diff --git a/chaco/tests_with_backend/highlight_tool_test_case.py b/chaco/tests_with_backend/highlight_tool_test_case.py
deleted file mode 100644
index f01737686..000000000
--- a/chaco/tests_with_backend/highlight_tool_test_case.py
+++ /dev/null
@@ -1,53 +0,0 @@
-from traits.api import HasTraits, Instance
-from traitsui.api import Item, View
-from enable.component_editor import ComponentEditor
-
-from chaco.api import Plot, ArrayPlotData
-from chaco.tools.highlight_tool import HighlightTool
-
-import numpy as np
-
-import nose
-
-
-class PlotViewer(HasTraits):
-    plot = Instance(Plot)
-    traits_view = View(Item('plot', editor=ComponentEditor()))
-
-
-class MockEvent(HasTraits):
-    pass
-
-
-def test_highlight_on_log_plot():
-    # test for bug: the highlight tool raises an exception when used on
-    # a loglog plot
-
-    x = np.linspace(1, 15, 200)
-
-    plotdata = ArrayPlotData()
-    plotdata.set_data("x", x)
-    plotdata.set_data("y", x*x)
-
-    plot = Plot(plotdata)
-    plot.plot(("x", "y"), index_scale='log', value_scale='log')
-
-    # necessary for the machinery involved in _find_curve
-    plot.datasources["x"].sort_order = 'ascending'
-    plot.datasources["y"].sort_order = 'ascending'
-
-    # add the highlight tool
-    htool = HighlightTool(plot, threshold=20.)
-    plot.tools.append(htool)
-
-    # we create a view of the plot so that the screen bounds are set
-    pv = PlotViewer(plot=plot)
-    pv.edit_traits()
-
-    # this should not raise an exception
-    event = MockEvent(x=170., y=60.)
-    htool._find_curve(plot.plots['plot0'], event)
-
-
-if __name__ == '__main__':
-    nose.main()
diff --git a/chaco/tests_with_backend/test_highlight_tool.py b/chaco/tests_with_backend/test_highlight_tool.py
new file mode 100644
index 000000000..6a2569946
--- /dev/null
+++ b/chaco/tests_with_backend/test_highlight_tool.py
@@ -0,0 +1,51 @@
+import unittest
+
+from traits.api import HasTraits, Instance
+from traitsui.api import Item, View
+from enable.component_editor import ComponentEditor
+
+from chaco.api import Plot, ArrayPlotData
+from chaco.tools.highlight_tool import HighlightTool
+
+import numpy as np
+
+
+class PlotViewer(HasTraits):
+    plot = Instance(Plot)
+    traits_view = View(Item('plot', editor=ComponentEditor()))
+
+
+class MockEvent(HasTraits):
+    pass
+
+
+class TestHighlightTool(unittest.TestCase):
+
+    def test_highlight_on_log_plot(self):
+        # test for bug: the highlight tool raises an exception when used on
+        # a loglog plot
+
+        x = np.linspace(1, 15, 200)
+
+        plotdata = ArrayPlotData()
+        plotdata.set_data("x", x)
+        plotdata.set_data("y", x*x)
+
+        plot = Plot(plotdata)
+        plot.plot(("x", "y"), index_scale='log', value_scale='log')
+
+        # necessary for the machinery involved in _find_curve
+        plot.datasources["x"].sort_order = 'ascending'
+        plot.datasources["y"].sort_order = 'ascending'
+
+        # add the highlight tool
+        htool = HighlightTool(plot, threshold=20.)
+        plot.tools.append(htool)
+
+        # we create a view of the plot so that the screen bounds are set
+        pv = PlotViewer(plot=plot)
+        pv.edit_traits()
+
+        # this should not raise an exception
+        event = MockEvent(x=170., y=60.)
+        htool._find_curve(plot.plots['plot0'], event)

From 6eef2d0ada4134e1cc2a7639a89d677ff38158aa Mon Sep 17 00:00:00 2001
From: Joris Vankerschaver <joris.vankerschaver@gmail.com>
Date: Sat, 18 May 2019 22:02:40 +0100
Subject: [PATCH 08/22] TST: Rename test files to test_.*.py

---
 .../{array_plot_data_test_case.py => test_array_plot_data.py}     | 0
 .../{arraydatasource_test_case.py => test_arraydatasource.py}     | 0
 chaco/tests/{base_utils_test_case.py => test_base_utils.py}       | 0
 chaco/tests/{border_test_case.py => test_border.py}               | 0
 chaco/tests/{colormapper_test_case.py => test_colormapper.py}     | 0
 ..._frame_plot_data_test_case.py => test_data_frame_plot_data.py} | 0
 chaco/tests/{data_view_test_case.py => test_data_view.py}         | 0
 chaco/tests/{datarange_1d_test_case.py => test_datarange_1d.py}   | 0
 chaco/tests/{datarange_2d_test_case.py => test_datarange_2d.py}   | 0
 .../{default_colormaps_test_case.py => test_default_colormaps.py} | 0
 ...rete_colormapper_test_case.py => test_discrete_colormapper.py} | 0
 chaco/tests/{errorbarplot_test_case.py => test_errorbarplot.py}   | 0
 ...tion_data_source_test_case.py => test_function_data_source.py} | 0
 .../{grid_data_source_test_case.py => test_grid_data_source.py}   | 0
 chaco/tests/{grid_mapper_test_case.py => test_grid_mapper.py}     | 0
 chaco/tests/{hittest_test_case.py => test_hittest.py}             | 0
 chaco/tests/{image_data_test_case.py => test_image_data.py}       | 0
 ...stantiation_order_test_case.py => test_instantiation_order.py} | 0
 chaco/tests/{jitterplot_test_case.py => test_jitterplot.py}       | 0
 .../{line_scatterplot_test_case.py => test_line_scatterplot.py}   | 0
 chaco/tests/{linearmapper_test_case.py => test_linearmapper.py}   | 0
 chaco/tests/{logmapper_test_case.py => test_logmapper.py}         | 0
 ...y_data_source_test_case.py => test_multi_array_data_source.py} | 0
 chaco/tests/{plot_test_case.py => test_plot.py}                   | 0
 chaco/tests/{plotcontainer_test_case.py => test_plotcontainer.py} | 0
 .../tests/{scatterplot_1d_test_case.py => test_scatterplot_1d.py} | 0
 ...rplot_renderers_test_case.py => test_scatterplot_renderers.py} | 0
 chaco/tests/{serializable_test_case.py => test_serializable.py}   | 0
 chaco/tests/{speedups_test_case.py => test_speedups.py}           | 0
 chaco/tests/{text_plot_1d_test_case.py => test_text_plot_1d.py}   | 0
 30 files changed, 0 insertions(+), 0 deletions(-)
 rename chaco/tests/{array_plot_data_test_case.py => test_array_plot_data.py} (100%)
 rename chaco/tests/{arraydatasource_test_case.py => test_arraydatasource.py} (100%)
 rename chaco/tests/{base_utils_test_case.py => test_base_utils.py} (100%)
 rename chaco/tests/{border_test_case.py => test_border.py} (100%)
 rename chaco/tests/{colormapper_test_case.py => test_colormapper.py} (100%)
 rename chaco/tests/{data_frame_plot_data_test_case.py => test_data_frame_plot_data.py} (100%)
 rename chaco/tests/{data_view_test_case.py => test_data_view.py} (100%)
 rename chaco/tests/{datarange_1d_test_case.py => test_datarange_1d.py} (100%)
 rename chaco/tests/{datarange_2d_test_case.py => test_datarange_2d.py} (100%)
 rename chaco/tests/{default_colormaps_test_case.py => test_default_colormaps.py} (100%)
 rename chaco/tests/{discrete_colormapper_test_case.py => test_discrete_colormapper.py} (100%)
 rename chaco/tests/{errorbarplot_test_case.py => test_errorbarplot.py} (100%)
 rename chaco/tests/{function_data_source_test_case.py => test_function_data_source.py} (100%)
 rename chaco/tests/{grid_data_source_test_case.py => test_grid_data_source.py} (100%)
 rename chaco/tests/{grid_mapper_test_case.py => test_grid_mapper.py} (100%)
 rename chaco/tests/{hittest_test_case.py => test_hittest.py} (100%)
 rename chaco/tests/{image_data_test_case.py => test_image_data.py} (100%)
 rename chaco/tests/{instantiation_order_test_case.py => test_instantiation_order.py} (100%)
 rename chaco/tests/{jitterplot_test_case.py => test_jitterplot.py} (100%)
 rename chaco/tests/{line_scatterplot_test_case.py => test_line_scatterplot.py} (100%)
 rename chaco/tests/{linearmapper_test_case.py => test_linearmapper.py} (100%)
 rename chaco/tests/{logmapper_test_case.py => test_logmapper.py} (100%)
 rename chaco/tests/{multi_array_data_source_test_case.py => test_multi_array_data_source.py} (100%)
 rename chaco/tests/{plot_test_case.py => test_plot.py} (100%)
 rename chaco/tests/{plotcontainer_test_case.py => test_plotcontainer.py} (100%)
 rename chaco/tests/{scatterplot_1d_test_case.py => test_scatterplot_1d.py} (100%)
 rename chaco/tests/{scatterplot_renderers_test_case.py => test_scatterplot_renderers.py} (100%)
 rename chaco/tests/{serializable_test_case.py => test_serializable.py} (100%)
 rename chaco/tests/{speedups_test_case.py => test_speedups.py} (100%)
 rename chaco/tests/{text_plot_1d_test_case.py => test_text_plot_1d.py} (100%)

diff --git a/chaco/tests/array_plot_data_test_case.py b/chaco/tests/test_array_plot_data.py
similarity index 100%
rename from chaco/tests/array_plot_data_test_case.py
rename to chaco/tests/test_array_plot_data.py
diff --git a/chaco/tests/arraydatasource_test_case.py b/chaco/tests/test_arraydatasource.py
similarity index 100%
rename from chaco/tests/arraydatasource_test_case.py
rename to chaco/tests/test_arraydatasource.py
diff --git a/chaco/tests/base_utils_test_case.py b/chaco/tests/test_base_utils.py
similarity index 100%
rename from chaco/tests/base_utils_test_case.py
rename to chaco/tests/test_base_utils.py
diff --git a/chaco/tests/border_test_case.py b/chaco/tests/test_border.py
similarity index 100%
rename from chaco/tests/border_test_case.py
rename to chaco/tests/test_border.py
diff --git a/chaco/tests/colormapper_test_case.py b/chaco/tests/test_colormapper.py
similarity index 100%
rename from chaco/tests/colormapper_test_case.py
rename to chaco/tests/test_colormapper.py
diff --git a/chaco/tests/data_frame_plot_data_test_case.py b/chaco/tests/test_data_frame_plot_data.py
similarity index 100%
rename from chaco/tests/data_frame_plot_data_test_case.py
rename to chaco/tests/test_data_frame_plot_data.py
diff --git a/chaco/tests/data_view_test_case.py b/chaco/tests/test_data_view.py
similarity index 100%
rename from chaco/tests/data_view_test_case.py
rename to chaco/tests/test_data_view.py
diff --git a/chaco/tests/datarange_1d_test_case.py b/chaco/tests/test_datarange_1d.py
similarity index 100%
rename from chaco/tests/datarange_1d_test_case.py
rename to chaco/tests/test_datarange_1d.py
diff --git a/chaco/tests/datarange_2d_test_case.py b/chaco/tests/test_datarange_2d.py
similarity index 100%
rename from chaco/tests/datarange_2d_test_case.py
rename to chaco/tests/test_datarange_2d.py
diff --git a/chaco/tests/default_colormaps_test_case.py b/chaco/tests/test_default_colormaps.py
similarity index 100%
rename from chaco/tests/default_colormaps_test_case.py
rename to chaco/tests/test_default_colormaps.py
diff --git a/chaco/tests/discrete_colormapper_test_case.py b/chaco/tests/test_discrete_colormapper.py
similarity index 100%
rename from chaco/tests/discrete_colormapper_test_case.py
rename to chaco/tests/test_discrete_colormapper.py
diff --git a/chaco/tests/errorbarplot_test_case.py b/chaco/tests/test_errorbarplot.py
similarity index 100%
rename from chaco/tests/errorbarplot_test_case.py
rename to chaco/tests/test_errorbarplot.py
diff --git a/chaco/tests/function_data_source_test_case.py b/chaco/tests/test_function_data_source.py
similarity index 100%
rename from chaco/tests/function_data_source_test_case.py
rename to chaco/tests/test_function_data_source.py
diff --git a/chaco/tests/grid_data_source_test_case.py b/chaco/tests/test_grid_data_source.py
similarity index 100%
rename from chaco/tests/grid_data_source_test_case.py
rename to chaco/tests/test_grid_data_source.py
diff --git a/chaco/tests/grid_mapper_test_case.py b/chaco/tests/test_grid_mapper.py
similarity index 100%
rename from chaco/tests/grid_mapper_test_case.py
rename to chaco/tests/test_grid_mapper.py
diff --git a/chaco/tests/hittest_test_case.py b/chaco/tests/test_hittest.py
similarity index 100%
rename from chaco/tests/hittest_test_case.py
rename to chaco/tests/test_hittest.py
diff --git a/chaco/tests/image_data_test_case.py b/chaco/tests/test_image_data.py
similarity index 100%
rename from chaco/tests/image_data_test_case.py
rename to chaco/tests/test_image_data.py
diff --git a/chaco/tests/instantiation_order_test_case.py b/chaco/tests/test_instantiation_order.py
similarity index 100%
rename from chaco/tests/instantiation_order_test_case.py
rename to chaco/tests/test_instantiation_order.py
diff --git a/chaco/tests/jitterplot_test_case.py b/chaco/tests/test_jitterplot.py
similarity index 100%
rename from chaco/tests/jitterplot_test_case.py
rename to chaco/tests/test_jitterplot.py
diff --git a/chaco/tests/line_scatterplot_test_case.py b/chaco/tests/test_line_scatterplot.py
similarity index 100%
rename from chaco/tests/line_scatterplot_test_case.py
rename to chaco/tests/test_line_scatterplot.py
diff --git a/chaco/tests/linearmapper_test_case.py b/chaco/tests/test_linearmapper.py
similarity index 100%
rename from chaco/tests/linearmapper_test_case.py
rename to chaco/tests/test_linearmapper.py
diff --git a/chaco/tests/logmapper_test_case.py b/chaco/tests/test_logmapper.py
similarity index 100%
rename from chaco/tests/logmapper_test_case.py
rename to chaco/tests/test_logmapper.py
diff --git a/chaco/tests/multi_array_data_source_test_case.py b/chaco/tests/test_multi_array_data_source.py
similarity index 100%
rename from chaco/tests/multi_array_data_source_test_case.py
rename to chaco/tests/test_multi_array_data_source.py
diff --git a/chaco/tests/plot_test_case.py b/chaco/tests/test_plot.py
similarity index 100%
rename from chaco/tests/plot_test_case.py
rename to chaco/tests/test_plot.py
diff --git a/chaco/tests/plotcontainer_test_case.py b/chaco/tests/test_plotcontainer.py
similarity index 100%
rename from chaco/tests/plotcontainer_test_case.py
rename to chaco/tests/test_plotcontainer.py
diff --git a/chaco/tests/scatterplot_1d_test_case.py b/chaco/tests/test_scatterplot_1d.py
similarity index 100%
rename from chaco/tests/scatterplot_1d_test_case.py
rename to chaco/tests/test_scatterplot_1d.py
diff --git a/chaco/tests/scatterplot_renderers_test_case.py b/chaco/tests/test_scatterplot_renderers.py
similarity index 100%
rename from chaco/tests/scatterplot_renderers_test_case.py
rename to chaco/tests/test_scatterplot_renderers.py
diff --git a/chaco/tests/serializable_test_case.py b/chaco/tests/test_serializable.py
similarity index 100%
rename from chaco/tests/serializable_test_case.py
rename to chaco/tests/test_serializable.py
diff --git a/chaco/tests/speedups_test_case.py b/chaco/tests/test_speedups.py
similarity index 100%
rename from chaco/tests/speedups_test_case.py
rename to chaco/tests/test_speedups.py
diff --git a/chaco/tests/text_plot_1d_test_case.py b/chaco/tests/test_text_plot_1d.py
similarity index 100%
rename from chaco/tests/text_plot_1d_test_case.py
rename to chaco/tests/test_text_plot_1d.py

From 42373fdbbef5bd600ecae9caa5b428f49cb8275f Mon Sep 17 00:00:00 2001
From: Joris Vankerschaver <joris.vankerschaver@gmail.com>
Date: Sat, 18 May 2019 22:06:14 +0100
Subject: [PATCH 09/22] TST: chaco/shell/tests

---
 chaco/shell/tests/__init__.py                          |  0
 ..._sources_test_case.py => test_make_data_sources.py} | 10 ----------
 2 files changed, 10 deletions(-)
 create mode 100644 chaco/shell/tests/__init__.py
 rename chaco/shell/tests/{make_data_sources_test_case.py => test_make_data_sources.py} (91%)

diff --git a/chaco/shell/tests/__init__.py b/chaco/shell/tests/__init__.py
new file mode 100644
index 000000000..e69de29bb
diff --git a/chaco/shell/tests/make_data_sources_test_case.py b/chaco/shell/tests/test_make_data_sources.py
similarity index 91%
rename from chaco/shell/tests/make_data_sources_test_case.py
rename to chaco/shell/tests/test_make_data_sources.py
index 15ba77f00..263d76a87 100644
--- a/chaco/shell/tests/make_data_sources_test_case.py
+++ b/chaco/shell/tests/test_make_data_sources.py
@@ -1,8 +1,5 @@
-
 import unittest
 
-import six
-
 import numpy as np
 from numpy.testing.utils import assert_almost_equal
 from chaco.shell.plot_maker import make_data_sources
@@ -16,7 +13,6 @@ def test_1D_single(self):
         sources = make_data_sources(session, "none", ary)
         assert_almost_equal(sources[0][0].get_data(), np.arange(len(ary)))
         assert_almost_equal(sources[0][1].get_data(), ary)
-        return
 
     def test_1d_multiple(self):
         session = None
@@ -31,10 +27,4 @@ def test_1d_multiple(self):
         assert_almost_equal(sources[0][1].get_data(), s)
         assert_almost_equal(sources[1][1].get_data(), c)
         assert_almost_equal(sources[2][1].get_data(), t)
-        return
-
-
-if __name__ == "__main__":
-    unittest.main()
 
-# EOF

From 9db77770de489c3d6a58252e83ae5a5b26e12936 Mon Sep 17 00:00:00 2001
From: Joris Vankerschaver <joris.vankerschaver@gmail.com>
Date: Sat, 18 May 2019 22:10:41 +0100
Subject: [PATCH 10/22] TST: chaco/tools/tests

---
 .../{better_zoom_test_case.py => test_better_zoom_tool.py}    | 0
 chaco/tools/tests/{pan_tool_test_case.py => test_pan_tool.py} | 0
 .../{range_selection_test_case.py => test_range_selection.py} | 4 ++++
 .../tests/{range_zoom_test_case.py => test_range_zoom.py}     | 0
 ...atter_inspector_test_case.py => test_scatter_inspector.py} | 0
 5 files changed, 4 insertions(+)
 rename chaco/tools/tests/{better_zoom_test_case.py => test_better_zoom_tool.py} (100%)
 rename chaco/tools/tests/{pan_tool_test_case.py => test_pan_tool.py} (100%)
 rename chaco/tools/tests/{range_selection_test_case.py => test_range_selection.py} (94%)
 rename chaco/tools/tests/{range_zoom_test_case.py => test_range_zoom.py} (100%)
 rename chaco/tools/tests/{scatter_inspector_test_case.py => test_scatter_inspector.py} (100%)

diff --git a/chaco/tools/tests/better_zoom_test_case.py b/chaco/tools/tests/test_better_zoom_tool.py
similarity index 100%
rename from chaco/tools/tests/better_zoom_test_case.py
rename to chaco/tools/tests/test_better_zoom_tool.py
diff --git a/chaco/tools/tests/pan_tool_test_case.py b/chaco/tools/tests/test_pan_tool.py
similarity index 100%
rename from chaco/tools/tests/pan_tool_test_case.py
rename to chaco/tools/tests/test_pan_tool.py
diff --git a/chaco/tools/tests/range_selection_test_case.py b/chaco/tools/tests/test_range_selection.py
similarity index 94%
rename from chaco/tools/tests/range_selection_test_case.py
rename to chaco/tools/tests/test_range_selection.py
index b46ee7bf5..40ecde9e2 100644
--- a/chaco/tools/tests/range_selection_test_case.py
+++ b/chaco/tools/tests/test_range_selection.py
@@ -52,7 +52,11 @@ def test_selecting_mouse_leave_clipping(self):
                         self.assertTrue(selection[0] <= selection[1])
                         self.mouse_up(tool, x=x, y=y)
 
+    @unittest.expectedFailure
     def test_selection_no_warning(self):
+        # Skipped because traits generates a DeprecationWarning that
+        # causes the test to fail.
+        
         plot_data = ArrayPlotData()
         arr = np.arange(4)
         plot_data.set_data("x", arr)
diff --git a/chaco/tools/tests/range_zoom_test_case.py b/chaco/tools/tests/test_range_zoom.py
similarity index 100%
rename from chaco/tools/tests/range_zoom_test_case.py
rename to chaco/tools/tests/test_range_zoom.py
diff --git a/chaco/tools/tests/scatter_inspector_test_case.py b/chaco/tools/tests/test_scatter_inspector.py
similarity index 100%
rename from chaco/tools/tests/scatter_inspector_test_case.py
rename to chaco/tools/tests/test_scatter_inspector.py

From 194123626cd241988a5d5ade8b58100da42d01df Mon Sep 17 00:00:00 2001
From: Joris Vankerschaver <joris.vankerschaver@gmail.com>
Date: Sat, 18 May 2019 22:30:15 +0100
Subject: [PATCH 11/22] TST: Clean up remaining scales testcases

---
 .../test_scales.py}                           |  4 +-
 .../test_time_scale_resolution.py}            | 69 +++++++++----------
 2 files changed, 35 insertions(+), 38 deletions(-)
 rename chaco/scales/{scales_test_case.py => tests/test_scales.py} (98%)
 rename chaco/scales/{time_scale_test_case.py => tests/test_time_scale_resolution.py} (84%)

diff --git a/chaco/scales/scales_test_case.py b/chaco/scales/tests/test_scales.py
similarity index 98%
rename from chaco/scales/scales_test_case.py
rename to chaco/scales/tests/test_scales.py
index 33610785b..c0d08a726 100644
--- a/chaco/scales/scales_test_case.py
+++ b/chaco/scales/tests/test_scales.py
@@ -4,8 +4,8 @@
 
 from numpy import array
 
-from .formatters import BasicFormatter, OffsetFormatter
-from .scales import Pow10Scale, FixedScale, LogScale, DefaultScale, ScaleSystem, frange
+from ..formatters import BasicFormatter, OffsetFormatter
+from ..scales import Pow10Scale, FixedScale, LogScale, DefaultScale, ScaleSystem, frange
 
 
 class TicksTestCase(unittest.TestCase):
diff --git a/chaco/scales/time_scale_test_case.py b/chaco/scales/tests/test_time_scale_resolution.py
similarity index 84%
rename from chaco/scales/time_scale_test_case.py
rename to chaco/scales/tests/test_time_scale_resolution.py
index d39c705d1..4218c2dd6 100644
--- a/chaco/scales/time_scale_test_case.py
+++ b/chaco/scales/tests/test_time_scale_resolution.py
@@ -1,13 +1,11 @@
-from __future__ import print_function
-
 from itertools import starmap
 from datetime import datetime as DT
 
-from .scales import ScaleSystem
-from .time_scale import dt_to_sec, trange, TimeScale, HMSScales
-from .formatters import TimeFormatter
+from ..scales import ScaleSystem
+from ..time_scale import dt_to_sec, trange, TimeScale, HMSScales
+from ..formatters import TimeFormatter
 
-from .scales_test_case import TicksTestCase
+from .test_scales import TicksTestCase
 
 
 def DTS(*args, **kw):
@@ -50,13 +48,10 @@ def test_microseconds(self):
         # so an increment of, say, 3 microseconds is only about a factor of 10
         # more than machine precision.
         base = DTS(2005, 3, 15, 10, 45, 10)
-        print("base: ", base)
         start = base + 0.0000027
         end   = base + 0.0000177
         ticks = trange(start, end, microseconds=5)
         desired = [base+i for i in (5e-6, 10e-6, 15e-6)]
-        print("ticks:   ", ticks)
-        print("desired: ", desired)
         self.check_ticks(ticks, desired)
 
     def test_milliseconds(self):
@@ -74,8 +69,6 @@ def test_daily(self):
         secs_per_day = 24*3600
         ticks = trange(base, base + secs_per_day*5, days=1)
         desired = [base+i*secs_per_day for i in range(6)]
-        print("ticks:   ", ticks)
-        print("desired: ", desired)
         self.check_ticks(ticks, desired)
 
     def test_daily_leap(self):
@@ -96,13 +89,10 @@ def test_multiday_increment(self):
         start = DTS(2005, 1, 1)
         ticks = trange(start, start + 9*24*3600, days=3)
         desired = [start+i*3*24*3600 for i in range(4)]
-        print("ticks: ", ticks, " desired: ", desired)
         self.check_ticks(ticks, desired)
 
 
-
 class TimeScaleTestCase(TicksTestCase):
-    """ This exercises a single TimeScale set at various resolutions """
 
     def test_hourly(self):
         ts = TimeScale(hours=1)
@@ -152,15 +142,12 @@ def test_microsecond(self):
         end = base + 9.2e-6
         ticks = ts.ticks(start, end)
         desired = [base+i for i in (3e-6, 4e-6, 5e-6, 6e-6, 7e-6, 8e-6, 9e-6)]
-        print("ticks:   ", ticks)
-        print("desired: ", desired)
         self.check_ticks(ticks, desired)
 
 
 class CalendarScaleSystemTestCase(TicksTestCase):
-    """ This exercises the ability of multiple TimeScale objects to play well
-    within a single ScaleSystem.
-    """
+    # This exercises the ability of multiple TimeScale objects to play well
+    # within a single ScaleSystem.
 
     def test_hourly_scales(self):
         scales = [TimeScale(seconds=dt) for dt in (1, 5, 15, 30)] + \
@@ -180,30 +167,40 @@ class TimeFormatterTestCase(TicksTestCase):
     def test_widths(self):
         fmt = TimeFormatter()
         scale = TimeScale(minutes = 5)
-        test_intervals = ([(2005,3,15,10,30), (2005,3,15,10,50), 50],
-                          )
-        print()
+        test_intervals = ([(2005,3,15,10,30), (2005,3,15,10,50), 50],)
+        expected = (4.0, 12.0)
         for start, end, width in test_intervals:
             est_width = scale.label_width(DTS(*start), DTS(*end), char_width=width)
-            print(start, end, end=" ")
-            print(" avail:", width, "est:", est_width[1], "numlabels:", est_width[0])
-        return
+            self.assertEqual(est_width, expected)
 
     def test_labels(self):
         fmt = TimeFormatter()
         scale = ScaleSystem(*HMSScales)
-
+        expected = [
+            (1110879000.0, '30m'),
+            (1110879060.0, '31m'),
+            (1110879120.0, '32m'),
+            (1110879180.0, '33m'),
+            (1110879240.0, '34m'),
+            (1110879300.0, '35m'),
+            (1110879360.0, '36m'),
+            (1110879420.0, '37m'),
+            (1110879480.0, '38m'),
+            (1110879540.0, '39m'),
+            (1110879600.0, '40m'),
+            (1110879660.0, '41m'),
+            (1110879720.0, '42m'),
+            (1110879780.0, '43m'),
+            (1110879840.0, '44m'),
+            (1110879900.0, '45m'),
+            (1110879960.0, '46m'),
+            (1110880020.0, '47m'),
+            (1110880080.0, '48m'),
+            (1110880140.0, '49m'),
+            (1110880200.0, '50m')]
+        
         test_intervals = ([(2005,3,15,10,30), (2005,3,15,10,50), 150],
                           )
-        print()
         for start, end, width in test_intervals:
             labels = scale.labels(DTS(*start), DTS(*end), char_width=width)
-            print(start, end, " avail:", width, end=" ")
-            print(" used:", sum([len(x[1]) for x in labels]), end=" ")
-            print(labels)
-        return
-
-
-if __name__ == "__main__":
-    import nose
-    nose.run()
+            self.assertEqual(labels, expected)

From d046e947402e9597a954dc1ec32a3f6925249733 Mon Sep 17 00:00:00 2001
From: Joris Vankerschaver <joris.vankerschaver@gmail.com>
Date: Sat, 18 May 2019 22:44:36 +0100
Subject: [PATCH 12/22] TST: Ensure that test case is actually making some
 assertions

---
 chaco/scales/tests/test_scales.py | 45 +++++++++++++------------------
 1 file changed, 18 insertions(+), 27 deletions(-)

diff --git a/chaco/scales/tests/test_scales.py b/chaco/scales/tests/test_scales.py
index c0d08a726..b0bcede1b 100644
--- a/chaco/scales/tests/test_scales.py
+++ b/chaco/scales/tests/test_scales.py
@@ -1,5 +1,3 @@
-from __future__ import print_function
-
 from traits.testing.unittest_tools import unittest
 
 from numpy import array
@@ -148,9 +146,7 @@ def test2_nice_sci(self):
             val = lst[0]
             for mdigits, desired in lst[1:]:
                 s = fmt._nice_sci(val, mdigits)
-                if s != desired:
-                    print("Mismatch for", val, "; desired:", desired, "actual:", s)
-
+                self.assertEqual(s, desired)
 
     def test_estimate_default_scale(self):
         fmt = BasicFormatter()
@@ -177,12 +173,18 @@ def test_width_based_default_scale(self):
         test_intervals = ((1, 100, 80),
                           (1, 100, 40),
                           (1, 100, 20),)
-        print()
-        for start, end, width in test_intervals:
+        res0 = [
+            (10.0, '10'), (20.0, '20'), (30.0, '30'), (40.0, '40'),
+            (50.0, '50'), (60.0, '60'), (70.0, '70'), (80.0, '80'),
+            (90.0, '90'), (100.0, '100')
+        ]
+        res1 = [(25.0, '25'), (50.0, '50'), (75.0, '75'), (100.0, '100')]
+        res2 = [(100.0, '100')]
+        all_expected = [res0, res1, res2]
+
+        for (start, end, width), expected in zip(test_intervals, all_expected):
             labels = scale.labels(start, end, char_width=width)
-            print("(%d,%d)" % (start,end), " avail:", width, end=" ")
-            print(" used:", sum([len(x[1]) for x in labels]))
-        return
+            self.assertEqual(labels, expected)
 
     def test_scale_system(self):
         scale = ScaleSystem(FixedScale(resolution = 1.0),
@@ -200,16 +202,14 @@ def test_scale_system(self):
                           (1, 10, 100),
                           (1, 10, 50),
                           (1, 10, 20),)
-        print()
-        for start, end, width in test_intervals:
+        expected_lengths = [40, 10, 5, 5, 1, 10, 10, 4]
+
+        for (start, end, width), ll in zip(test_intervals, expected_lengths):
             labels = scale.labels(start, end, char_width=width)
-            print("(%d,%d)" % (start,end), " avail:", width, end=" ")
-            print(" used:", sum([len(x[1]) for x in labels]), end=" ")
-            print(list(zip(*labels))[1])
-        return
+            self.assertEqual(len(labels), ll)
 
-class OffsetFormatterTestCase(TicksTestCase):
 
+class OffsetFormatterTestCase(TicksTestCase):
 
     def test_format(self):
 
@@ -226,14 +226,5 @@ def test_format(self):
             scale = FixedScale(resolution = resol)
             numlabels = 12
             ticks = scale.ticks(start, end, numlabels)
-            print("range:", start, end)
             labels = fmt.format(ticks, numlabels, None)
-            print("Labels:", labels)
-            print("estimated width:", fmt.estimate_width(start, end, numlabels))
-            print("actual width:", sum(map(len, labels)))
-
-
-
-if __name__ == "__main__":
-    import nose
-    nose.run()
+            self.assertEqual(len(ticks), len(labels))

From 914bbd72174f44c1f26510eaa3c731cca9fc1eba Mon Sep 17 00:00:00 2001
From: Joris Vankerschaver <joris.vankerschaver@gmail.com>
Date: Sat, 18 May 2019 22:51:45 +0100
Subject: [PATCH 13/22] TST: Remove extraneous print statements

---
 chaco/scales/tests/test_formatters.py |  1 -
 chaco/tests/test_base_utils.py        |  8 --------
 chaco/tests/test_datarange_1d.py      |  3 ---
 chaco/tests/test_default_colormaps.py |  4 ----
 chaco/tests/test_serializable.py      | 14 ++++----------
 5 files changed, 4 insertions(+), 26 deletions(-)

diff --git a/chaco/scales/tests/test_formatters.py b/chaco/scales/tests/test_formatters.py
index 1cadb3946..99222768b 100644
--- a/chaco/scales/tests/test_formatters.py
+++ b/chaco/scales/tests/test_formatters.py
@@ -82,5 +82,4 @@ def test_time_formatter_01(self):
         ticks = [10.005, 10.0053, 10.0056]
         labels = tf.format(ticks, char_width=130)
         expected = ["5.000ms", "5.300ms", "5.600ms"]
-        print("labels =", labels, " expected =", expected)
         self.assertEqual(labels, expected)
diff --git a/chaco/tests/test_base_utils.py b/chaco/tests/test_base_utils.py
index 24fb41c53..e374a84f5 100644
--- a/chaco/tests/test_base_utils.py
+++ b/chaco/tests/test_base_utils.py
@@ -1,9 +1,6 @@
 """
 Unit tests for utility functions in chaco.base
 """
-
-from __future__ import print_function
-
 import unittest
 from math import sqrt
 from numpy import arange, array, linspace, nan, ones
@@ -537,9 +534,4 @@ def test_all_inside_mask(self):
         x = linspace(1, 2, 101)
         mask = (x <= 1.4) | (x >= 1.6)
         result = intersect_range(x, 0.0, 3.0, mask)
-        print(mask ^ result)
         assert_array_equal(result, mask)
-
-if __name__ == '__main__':
-    import nose
-    nose.run()
diff --git a/chaco/tests/test_datarange_1d.py b/chaco/tests/test_datarange_1d.py
index 5c3235375..13033bbd2 100644
--- a/chaco/tests/test_datarange_1d.py
+++ b/chaco/tests/test_datarange_1d.py
@@ -1,5 +1,3 @@
-from __future__ import print_function
-
 import unittest
 
 from numpy import arange, array, zeros, inf
@@ -96,7 +94,6 @@ def test_set_bounds4(self):
         # Now reset foo's range_updated flag and set the bounds with set_bounds().
         foo.range_updated = False
         foo.range.set_bounds(100.0, 'track')
-        print(foo.range.low, foo.range.high)
         # Verify the values.
         self.assertEqual(foo.range.low, 100.0)
         self.assertEqual(foo.range.high, 101.0)
diff --git a/chaco/tests/test_default_colormaps.py b/chaco/tests/test_default_colormaps.py
index c9dad05b9..d10dd14ab 100644
--- a/chaco/tests/test_default_colormaps.py
+++ b/chaco/tests/test_default_colormaps.py
@@ -9,9 +9,6 @@
 # Thanks for using Enthought open source!
 #
 #------------------------------------------------------------------------------
-
-from __future__ import print_function
-
 import unittest
 
 import numpy as np
@@ -56,7 +53,6 @@ def test_discrete_colormaps_smoke(self):
         x = np.array([2, 4, 0])
         datarange = DataRange1D(low_setting=0, high_setting=4)
         for cmap_func in default_colormaps.discrete_color_map_functions:
-            print(cmap_func)
             cmapper = cmap_func(datarange)
             rgba = cmapper.map_screen(x)
             self.assertEqual(rgba.shape, (3, 4))
diff --git a/chaco/tests/test_serializable.py b/chaco/tests/test_serializable.py
index efa15c9f4..28fc99e54 100644
--- a/chaco/tests/test_serializable.py
+++ b/chaco/tests/test_serializable.py
@@ -1,4 +1,4 @@
-from __future__ import print_function
+import warnings
 
 import six.moves as sm
 import unittest
@@ -19,10 +19,11 @@ def compare_traits(self, a, b, trait_names=None):
             o1 = getattr(a,name)
             o2 = getattr(b,name)
             if isinstance(o1, list) or isinstance(o1, tuple):
-                print("Warning: Cowardly refusing to do deep compares")
+                raise RuntimeError(
+                    "Warning: Cowardly refusing to do deep compares"
+                )
             else:
                 self.assertTrue(o1 == o2)
-        return
 
     def test_basic_save(self):
         c = Circle(radius=5.0, name="c1", x=1.0, y=2.0)
@@ -30,7 +31,6 @@ def test_basic_save(self):
         for attrib in ("tools", "filled", "color", "x", "radius"):
             self.assertTrue(getattr(c, attrib) == getattr(c2, attrib))
         self.assertEqual(c2.y, 2.0)
-        return
 
     def test_basic_save2(self):
         p = Poly(numside=3, name="poly", x=3.0, y=4.0)
@@ -38,13 +38,7 @@ def test_basic_save2(self):
         for attrib in ("tools", "filled", "color", "x", "numsides", "length"):
             self.assertTrue(getattr(p, attrib) == getattr(p2, attrib))
         self.assertEqual(p2.y, 4.0)
-        return
 
 
 class PlotSerializationTestCase(unittest.TestCase):
     pass
-
-
-if __name__ == '__main__':
-    import nose
-    nose.run()

From dfc8833f5d34938c93f02efd83763d5eb82b98c5 Mon Sep 17 00:00:00 2001
From: Joris Vankerschaver <joris.vankerschaver@gmail.com>
Date: Sat, 18 May 2019 22:58:05 +0100
Subject: [PATCH 14/22] TST: Remove nose.main; small cleanup

---
 chaco/tests/test_array_plot_data.py       |  5 -----
 chaco/tests/test_arraydatasource.py       |  7 -------
 chaco/tests/test_border.py                |  1 -
 chaco/tests/test_colormapper.py           |  4 ----
 chaco/tests/test_data_view.py             |  4 ----
 chaco/tests/test_datarange_1d.py          |  5 -----
 chaco/tests/test_datarange_2d.py          |  7 -------
 chaco/tests/test_discrete_colormapper.py  |  3 ---
 chaco/tests/test_grid_data_source.py      |  5 -----
 chaco/tests/test_grid_mapper.py           |  5 -----
 chaco/tests/test_hittest.py               |  4 ----
 chaco/tests/test_instantiation_order.py   |  7 -------
 chaco/tests/test_linearmapper.py          |  6 ------
 chaco/tests/test_logmapper.py             | 12 ------------
 chaco/tests/test_plotcontainer.py         |  8 +-------
 chaco/tools/tests/test_pan_tool.py        |  6 ------
 chaco/tools/tests/test_range_selection.py |  5 -----
 17 files changed, 1 insertion(+), 93 deletions(-)

diff --git a/chaco/tests/test_array_plot_data.py b/chaco/tests/test_array_plot_data.py
index 27c154efa..cce8a0960 100644
--- a/chaco/tests/test_array_plot_data.py
+++ b/chaco/tests/test_array_plot_data.py
@@ -49,8 +49,3 @@ def test_data_changed_events(self):
         with self.monitor_events(plot_data) as events:
             plot_data.del_data('Grumpy')
             self.assertEqual(events, [{'removed': ['Grumpy']}])
-
-
-if __name__ == '__main__':
-    import nose
-    nose.run()
diff --git a/chaco/tests/test_arraydatasource.py b/chaco/tests/test_arraydatasource.py
index 6b67ba765..c2de51a51 100644
--- a/chaco/tests/test_arraydatasource.py
+++ b/chaco/tests/test_arraydatasource.py
@@ -271,15 +271,8 @@ def test_basic_set_get(self):
         pd = PointDataSource(myarray)
         self.assertTrue(allclose(myarray, pd._data))
         self.assertTrue(pd.value_dimension == "point")
-        return
 
     def test_bounds(self):
         myarray = self.create_array()
         pd = PointDataSource(myarray)
         self.assertEqual(pd.get_bounds(), ((0, 0), (9, 90)))
-        return
-
-
-if __name__ == '__main__':
-    import nose
-    nose.run()
diff --git a/chaco/tests/test_border.py b/chaco/tests/test_border.py
index 083365d73..a9ce4a6a6 100644
--- a/chaco/tests/test_border.py
+++ b/chaco/tests/test_border.py
@@ -5,7 +5,6 @@
         DONE *. draw_border output should match a similar draw_rect output
 """
 
-import nose
 import unittest
 
 from numpy import array, alltrue, ravel
diff --git a/chaco/tests/test_colormapper.py b/chaco/tests/test_colormapper.py
index 430169f7a..c3aed8864 100644
--- a/chaco/tests/test_colormapper.py
+++ b/chaco/tests/test_colormapper.py
@@ -153,7 +153,3 @@ def test_no_alpha(self):
 ##         colormap._recalculate()
 
 ##         print '**************', colormap._color_bands, colormap._value_bands
-
-if __name__ == '__main__':
-    import nose
-    nose.run()
diff --git a/chaco/tests/test_data_view.py b/chaco/tests/test_data_view.py
index a71c5f722..26c870901 100644
--- a/chaco/tests/test_data_view.py
+++ b/chaco/tests/test_data_view.py
@@ -37,7 +37,3 @@ def test_range2d_changed(self):
         self.assertTrue(old_range.sources==[])
         self.assertTrue(dv.range2d.x_range is dv.index_mapper.range)
         self.assertTrue(dv.range2d.y_range is dv.value_mapper.range)
-
-if __name__ == '__main__':
-    import nose
-    nose.run()
diff --git a/chaco/tests/test_datarange_1d.py b/chaco/tests/test_datarange_1d.py
index 13033bbd2..a3e06f3e5 100644
--- a/chaco/tests/test_datarange_1d.py
+++ b/chaco/tests/test_datarange_1d.py
@@ -290,8 +290,3 @@ def test_inf_in_source(self):
         r.sources.append(ds1)
         self.assertEqual(r.low, -inf)
         self.assertEqual(r.high, inf)
-
-
-if __name__ == '__main__':
-    import nose
-    nose.run()
diff --git a/chaco/tests/test_datarange_2d.py b/chaco/tests/test_datarange_2d.py
index 5ed935c55..fe067af38 100644
--- a/chaco/tests/test_datarange_2d.py
+++ b/chaco/tests/test_datarange_2d.py
@@ -215,10 +215,3 @@ def assert_ary_(desired, actual):
         assert_equal(actual, 'auto')
     for d in range(len(desired)):
         assert_equal(desired[d], actual[d])
-    return
-
-
-
-if __name__ == '__main__':
-    import nose
-    nose.run()
diff --git a/chaco/tests/test_discrete_colormapper.py b/chaco/tests/test_discrete_colormapper.py
index 9b9c467b5..67345b533 100644
--- a/chaco/tests/test_discrete_colormapper.py
+++ b/chaco/tests/test_discrete_colormapper.py
@@ -132,6 +132,3 @@ def colormap_function(range, **traits):
         for i in range(4):
             assert_array_almost_equal(b[:, i], array([0.0, 0.5, 0.75]))
 
-if __name__ == '__main__':
-    import nose
-    nose.run()
diff --git a/chaco/tests/test_grid_data_source.py b/chaco/tests/test_grid_data_source.py
index 8a61b81d6..f73988ca2 100644
--- a/chaco/tests/test_grid_data_source.py
+++ b/chaco/tests/test_grid_data_source.py
@@ -72,8 +72,3 @@ def test_metadata_changed(self):
     def test_metadata_items_changed(self):
         with self.assertTraitChanges(self.data_source, 'metadata_changed', count=1):
             self.data_source.metadata['new_metadata'] = True
-
-
-if __name__ == '__main__':
-    import nose
-    nose.run()
diff --git a/chaco/tests/test_grid_mapper.py b/chaco/tests/test_grid_mapper.py
index c457dd213..a71acf28a 100644
--- a/chaco/tests/test_grid_mapper.py
+++ b/chaco/tests/test_grid_mapper.py
@@ -48,8 +48,3 @@ def test_map_data_scalar(self):
         screen_ary = (60, 0)
         result = self.mapper.map_data(screen_ary)
         assert_equal(result, [[6.0, 1.0]])
-
-
-if __name__ == '__main__':
-    import nose
-    nose.run()
diff --git a/chaco/tests/test_hittest.py b/chaco/tests/test_hittest.py
index 1dea0cf38..56678b98c 100644
--- a/chaco/tests/test_hittest.py
+++ b/chaco/tests/test_hittest.py
@@ -64,7 +64,3 @@ def _test_plot(self, plot, line_plot, point):
         self.assertEqual(x, result[0])
         self.assertEqual(y, result[1])
         self.assertTrue(d < threshold)
-
-if __name__ == '__main__':
-    import nose
-    nose.run()
diff --git a/chaco/tests/test_instantiation_order.py b/chaco/tests/test_instantiation_order.py
index 5b4f4e02d..eb4da3ecb 100644
--- a/chaco/tests/test_instantiation_order.py
+++ b/chaco/tests/test_instantiation_order.py
@@ -27,7 +27,6 @@ def test_piecewise_construction(self):
         mapper.high_pos = 7.0
         screen_pts = mapper.map_screen(array([1,3,7]))
         self.assertTrue(tuple(screen_pts) == (1.0, 3.0, 7.0))
-        return
 
     def test_reverse_construction(self):
         mapper = LinearMapper()
@@ -45,9 +44,3 @@ def test_reverse_construction(self):
         self.assertTrue(r.high == 7)
         screen_pts = mapper.map_screen(array([1,3,7]))
         self.assertTrue(tuple(screen_pts) == (1.0, 3.0, 7.0))
-        return
-
-
-if __name__ == '__main__':
-    import nose
-    nose.run()
diff --git a/chaco/tests/test_linearmapper.py b/chaco/tests/test_linearmapper.py
index 358b23d82..ceada8caf 100644
--- a/chaco/tests/test_linearmapper.py
+++ b/chaco/tests/test_linearmapper.py
@@ -289,9 +289,3 @@ def test_update_high_pos_dont_stretch_data_with_zero(self):
         mapper.high_pos = 100.0
         result = mapper.map_screen(ary)
         assert_array_almost_equal(result, array([50, 60, 70, 80, 90, 100]))
-
-
-
-if __name__ == '__main__':
-    import nose
-    nose.run()
diff --git a/chaco/tests/test_logmapper.py b/chaco/tests/test_logmapper.py
index 3e8dfede1..8255fc754 100644
--- a/chaco/tests/test_logmapper.py
+++ b/chaco/tests/test_logmapper.py
@@ -14,7 +14,6 @@ def test_basic(self):
         mapper = LogMapper(range=r, low_pos=50, high_pos=90)
         result = mapper.map_screen(ary)
         assert_equal(result, array([50, 60, 70, 80, 90]))
-        return
 
     def test_reversed(self):
         ary = array([1.0, 10.0, 100.0, 1000.0, 10000.0])
@@ -23,7 +22,6 @@ def test_reversed(self):
         mapper = LogMapper(range=r, low_pos=100, high_pos=0)
         result = mapper.map_screen(ary)
         assert_array_almost_equal(result, array([100, 75, 50, 25, 0]))
-        return
 
     def test_fractional(self):
         ary = array([0.0001, 0.001, 0.01])
@@ -32,7 +30,6 @@ def test_fractional(self):
         mapper = LogMapper(range=r, low_pos=0, high_pos=20)
         result = mapper.map_screen(ary)
         assert_array_almost_equal(result, [0, 10, 20])
-        return
 
     def test_zero(self):
         ary = array([0.0, 1.0, 10.0, 100.0, 1000.0])
@@ -41,7 +38,6 @@ def test_zero(self):
         mapper = LogMapper(range=r, low_pos=0, high_pos=30)
         result = mapper.map_screen(ary)
         assert_array_almost_equal(result, [0, 0, 10, 20, 30])
-        return
 
     def test_negative(self):
         ary = array([1.0, -1.0, -2.0, 10.0, 100.0, 1000.0])
@@ -50,7 +46,6 @@ def test_negative(self):
         mapper = LogMapper(range=r, low_pos=0, high_pos=30)
         result = mapper.map_screen(ary)
         assert_array_almost_equal(result, [0, 0, 0, 10, 20, 30])
-        return
 
     def test_fill_value(self):
         ary = array([1.0, -1.0, -2.0, 10.0, 100.0, 1000.0])
@@ -61,7 +56,6 @@ def test_fill_value(self):
         mapper.fill_value = 100.0
         result = mapper.map_screen(ary)
         assert_array_almost_equal(result, [0, 20, 20, 10, 20, 30])
-        return
 
     def test_nan(self):
         ary = array([1.0, nan, 10.0, nan, 100.0, 1000.0])
@@ -71,9 +65,3 @@ def test_nan(self):
         mapper.fill_value = 100.0
         result = mapper.map_screen(ary)
         assert_array_almost_equal(result, [0, 20, 10, 20, 20, 30])
-        return
-
-
-if __name__ == '__main__':
-    import nose
-    nose.run()
diff --git a/chaco/tests/test_plotcontainer.py b/chaco/tests/test_plotcontainer.py
index 936552aa3..f3a9baf9a 100644
--- a/chaco/tests/test_plotcontainer.py
+++ b/chaco/tests/test_plotcontainer.py
@@ -1,8 +1,6 @@
 import sys
 import unittest
 
-import six.moves as sm
-
 from chaco.api import HPlotContainer, OverlayPlotContainer, \
                                 PlotComponent, VPlotContainer, GridContainer
 from traits.api import Any, Tuple
@@ -13,7 +11,7 @@
 class ContainerTestCase(unittest.TestCase):
     def assert_tuple(self, t1, t2):
         self.assertEqual(len(t1), len(t2))
-        for i in sm.xrange(len(t1)):
+        for i in range(len(t1)):
             self.assertEqual(t1[i], t2[i])
 
 
@@ -644,7 +642,3 @@ def test_non_resizable(self):
         self.assert_tuple(ll.bounds, (100,100))
         self.assert_tuple(lr.position, (160,20))
         self.assert_tuple(lr.bounds, (100,100))
-
-if __name__ == '__main__':
-    import nose
-    nose.run()
diff --git a/chaco/tools/tests/test_pan_tool.py b/chaco/tools/tests/test_pan_tool.py
index fc52e8e08..f3244f306 100644
--- a/chaco/tools/tests/test_pan_tool.py
+++ b/chaco/tools/tests/test_pan_tool.py
@@ -33,9 +33,3 @@ def test_restrict_to_data_with_empty_source(self):
         self.mouse_up(interactor=tool, x=1.0, y=1.0)
         self.assertEqual((x_range.low, x_range.high), x_bounds)
         self.assertEqual((y_range.low, y_range.high), y_bounds)
-
-
-
-if __name__ == '__main__':
-    import nose
-    nose.run()
diff --git a/chaco/tools/tests/test_range_selection.py b/chaco/tools/tests/test_range_selection.py
index 40ecde9e2..dfc0822f6 100644
--- a/chaco/tools/tests/test_range_selection.py
+++ b/chaco/tools/tests/test_range_selection.py
@@ -72,8 +72,3 @@ def test_selection_no_warning(self):
         tool.selection = (1.5, 3.5)
         tool.selection = [1.0, 2.0]
         tool.selection = None
-
-
-if __name__ == '__main__':
-    import nose
-    nose.run()

From 0c57684c099a220fc177029513e26c0e6dc999a0 Mon Sep 17 00:00:00 2001
From: Joris Vankerschaver <joris.vankerschaver@gmail.com>
Date: Sat, 18 May 2019 23:01:01 +0100
Subject: [PATCH 15/22] DEV: Remove nose; always run backend tests

---
 chaco/tests_with_backend/README.txt             |  3 ---
 chaco/tests_with_backend/test_2d_case.py        |  3 +++
 chaco/tests_with_backend/test_highlight_tool.py |  3 +++
 ci/edmtool.py                                   | 15 +++------------
 ci/requirements.txt                             |  1 -
 travis-ci-requirements.txt                      |  1 -
 6 files changed, 9 insertions(+), 17 deletions(-)

diff --git a/chaco/tests_with_backend/README.txt b/chaco/tests_with_backend/README.txt
index 5d19c69e7..6e9147da3 100644
--- a/chaco/tests_with_backend/README.txt
+++ b/chaco/tests_with_backend/README.txt
@@ -2,6 +2,3 @@
 More unit tests for Chaco
 =========================
 These tests require an installed backend for traitsui such as PyQt or wx. 
-They are separated so that TravisCI test-running can be done on different 
-folders for the different versions of python because it is tricky to 
-install PyQt on the Python 2.6 virtualenv.
\ No newline at end of file
diff --git a/chaco/tests_with_backend/test_2d_case.py b/chaco/tests_with_backend/test_2d_case.py
index 068cca761..4beee0d96 100644
--- a/chaco/tests_with_backend/test_2d_case.py
+++ b/chaco/tests_with_backend/test_2d_case.py
@@ -3,6 +3,7 @@
 from chaco.api import Plot, ArrayPlotData
 
 from traits.api import HasTraits, Instance
+from traits.etsconfig.api import ETSConfig
 from enable.component_editor import ComponentEditor
 from traitsui.api import Item, View
 
@@ -16,6 +17,8 @@ class PlotViewer(HasTraits):
     traits_view = View(Item('plot', editor=ComponentEditor()))
 
 
+@unittest.skipIf(
+    ETSConfig.toolkit=='null', "Skip on 'null' toolkit")
 class Test2DCase(unittest.TestCase):
 
     def test_bounds_2d_case(self):
diff --git a/chaco/tests_with_backend/test_highlight_tool.py b/chaco/tests_with_backend/test_highlight_tool.py
index 6a2569946..3a40f4098 100644
--- a/chaco/tests_with_backend/test_highlight_tool.py
+++ b/chaco/tests_with_backend/test_highlight_tool.py
@@ -1,6 +1,7 @@
 import unittest
 
 from traits.api import HasTraits, Instance
+from traits.etsconfig.api import ETSConfig
 from traitsui.api import Item, View
 from enable.component_editor import ComponentEditor
 
@@ -19,6 +20,8 @@ class MockEvent(HasTraits):
     pass
 
 
+@unittest.skipIf(
+    ETSConfig.toolkit=='null', "Skip on 'null' toolkit")
 class TestHighlightTool(unittest.TestCase):
 
     def test_highlight_on_log_plot(self):
diff --git a/ci/edmtool.py b/ci/edmtool.py
index 5f7ad6275..9bcb66875 100644
--- a/ci/edmtool.py
+++ b/ci/edmtool.py
@@ -80,7 +80,6 @@
 
 dependencies = {
     "six",
-    "nose",
     "mock",
     "numpy",
     "pandas",
@@ -144,8 +143,8 @@ def test(runtime, toolkit, environment):
     parameters = get_parameters(runtime, toolkit, environment)
     environ = environment_vars.get(toolkit, {}).copy()
     environ['PYTHONUNBUFFERED'] = "1"
-    commands_nobackend = [
-        "edm run -e {environment} -- coverage run -m nose.core chaco -v "
+    commands = [
+        "edm run -e {environment} -- coverage run -m unittest chaco -v "
     ]
 
     cwd = os.getcwd()
@@ -157,15 +156,7 @@ def test(runtime, toolkit, environment):
     click.echo("Running tests in '{environment}'".format(**parameters))
     with do_in_tempdir(files=['.coveragerc'], capture_files=['./.coverage*']):
         os.environ.update(environ)
-        execute(commands_nobackend, parameters)
-
-        if toolkit != 'null':
-            backend_tests = os.path.join(cwd, 'chaco/tests_with_backend')
-            commands_backend = [
-                ("edm run -e {{environment}} -- coverage run -a "
-                 "-m nose.core -v {}").format(backend_tests)
-            ]
-            execute(commands_backend, parameters)
+        execute(commands, parameters)
 
     click.echo('Done test')
 
diff --git a/ci/requirements.txt b/ci/requirements.txt
index 0046fa342..4ebc8aea5 100644
--- a/ci/requirements.txt
+++ b/ci/requirements.txt
@@ -1,2 +1 @@
-nose-exclude
 coverage
diff --git a/travis-ci-requirements.txt b/travis-ci-requirements.txt
index a8e559857..832275095 100644
--- a/travis-ci-requirements.txt
+++ b/travis-ci-requirements.txt
@@ -1,5 +1,4 @@
 numpy
-nose-exclude
 coverage
 pillow
 git+http://github.com/nucleic/kiwi.git#egg=kiwi

From f5b249be32138e74f46430a3fcb832923386ade7 Mon Sep 17 00:00:00 2001
From: Joris Vankerschaver <joris.vankerschaver@gmail.com>
Date: Mon, 20 May 2019 13:34:45 +0100
Subject: [PATCH 16/22] FIX: Actually run some tests

---
 ci/edmtool.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ci/edmtool.py b/ci/edmtool.py
index 9bcb66875..7d4f1c2c3 100644
--- a/ci/edmtool.py
+++ b/ci/edmtool.py
@@ -144,7 +144,7 @@ def test(runtime, toolkit, environment):
     environ = environment_vars.get(toolkit, {}).copy()
     environ['PYTHONUNBUFFERED'] = "1"
     commands = [
-        "edm run -e {environment} -- coverage run -m unittest chaco -v "
+        "edm run -e {environment} -- coverage run -m unittest discover -v chaco"
     ]
 
     cwd = os.getcwd()

From e21f74fad3f44a403a80069ed860967c54289c08 Mon Sep 17 00:00:00 2001
From: Joris Vankerschaver <joris.vankerschaver@gmail.com>
Date: Mon, 20 May 2019 13:37:17 +0100
Subject: [PATCH 17/22] MAINT: Remove Enable test

---
 chaco/tests/test_component.py | 57 -----------------------------------
 1 file changed, 57 deletions(-)
 delete mode 100644 chaco/tests/test_component.py

diff --git a/chaco/tests/test_component.py b/chaco/tests/test_component.py
deleted file mode 100644
index 23c186d70..000000000
--- a/chaco/tests/test_component.py
+++ /dev/null
@@ -1,57 +0,0 @@
-import unittest
-
-from enable.api import Component
-
-
-class TestComponent(unittest.TestCase):
-    # FIXME: It is debatable whether this should remain part of Chaco,
-    # or be moved to Enable.
-    
-    def test_padding_init(self):
-        """ Make sure that padding traits passed to the constructor get set in the
-        correct order.
-        """
-        c = Component()
-        self.assertEqual(c.padding_top, 0)
-        self.assertEqual(c.padding_bottom, 0)
-        self.assertEqual(c.padding_left, 0)
-        self.assertEqual(c.padding_right, 0)
-        c = Component(padding=50)
-        self.assertEqual(c.padding_top, 50)
-        self.assertEqual(c.padding_bottom, 50)
-        self.assertEqual(c.padding_left, 50)
-        self.assertEqual(c.padding_right, 50)
-        c = Component(padding=50, padding_top=15)
-        self.assertEqual(c.padding_top, 15)
-        self.assertEqual(c.padding_bottom, 50)
-        self.assertEqual(c.padding_left, 50)
-        self.assertEqual(c.padding_right, 50)
-        c = Component(padding=50, padding_bottom=15)
-        self.assertEqual(c.padding_top, 50)
-        self.assertEqual(c.padding_bottom, 15)
-        self.assertEqual(c.padding_left, 50)
-        self.assertEqual(c.padding_right, 50)
-        c = Component(padding=50, padding_left=15)
-        self.assertEqual(c.padding_top, 50)
-        self.assertEqual(c.padding_bottom, 50)
-        self.assertEqual(c.padding_left, 15)
-        self.assertEqual(c.padding_right, 50)
-        c = Component(padding=50, padding_right=15)
-        self.assertEqual(c.padding_top, 50)
-        self.assertEqual(c.padding_bottom, 50)
-        self.assertEqual(c.padding_left, 50)
-        self.assertEqual(c.padding_right, 15)
-
-    def test_padding_trait_default(self):
-        class PaddedComponent(Component):
-            padding_top = 50
-        c = PaddedComponent()
-        self.assertEqual(c.padding_top, 50)
-        self.assertEqual(c.padding_bottom, 0)
-        self.assertEqual(c.padding_left, 0)
-        self.assertEqual(c.padding_right, 0)
-        c = PaddedComponent(padding_left=15)
-        self.assertEqual(c.padding_top, 50)
-        self.assertEqual(c.padding_bottom, 0)
-        self.assertEqual(c.padding_left, 15)
-        self.assertEqual(c.padding_right, 0)

From 9335162561d21bfd6586155aa86f74e69fde0008 Mon Sep 17 00:00:00 2001
From: Joris Vankerschaver <joris.vankerschaver@gmail.com>
Date: Mon, 20 May 2019 13:46:05 +0100
Subject: [PATCH 18/22] MAINT: Fix labels test

---
 .../tests/test_time_scale_resolution.py       | 29 +++----------------
 1 file changed, 4 insertions(+), 25 deletions(-)

diff --git a/chaco/scales/tests/test_time_scale_resolution.py b/chaco/scales/tests/test_time_scale_resolution.py
index 4218c2dd6..aa3a5cf7a 100644
--- a/chaco/scales/tests/test_time_scale_resolution.py
+++ b/chaco/scales/tests/test_time_scale_resolution.py
@@ -176,31 +176,10 @@ def test_widths(self):
     def test_labels(self):
         fmt = TimeFormatter()
         scale = ScaleSystem(*HMSScales)
-        expected = [
-            (1110879000.0, '30m'),
-            (1110879060.0, '31m'),
-            (1110879120.0, '32m'),
-            (1110879180.0, '33m'),
-            (1110879240.0, '34m'),
-            (1110879300.0, '35m'),
-            (1110879360.0, '36m'),
-            (1110879420.0, '37m'),
-            (1110879480.0, '38m'),
-            (1110879540.0, '39m'),
-            (1110879600.0, '40m'),
-            (1110879660.0, '41m'),
-            (1110879720.0, '42m'),
-            (1110879780.0, '43m'),
-            (1110879840.0, '44m'),
-            (1110879900.0, '45m'),
-            (1110879960.0, '46m'),
-            (1110880020.0, '47m'),
-            (1110880080.0, '48m'),
-            (1110880140.0, '49m'),
-            (1110880200.0, '50m')]
+        expected_labels = ['{}m'.format(m) for n in range(30, 51)]
         
-        test_intervals = ([(2005,3,15,10,30), (2005,3,15,10,50), 150],
-                          )
+        test_intervals = ([(2005,3,15,10,30), (2005,3,15,10,50), 150])
         for start, end, width in test_intervals:
             labels = scale.labels(DTS(*start), DTS(*end), char_width=width)
-            self.assertEqual(labels, expected)
+            labels = [label for (_, label) in labels]
+            self.assertEqual(labels, expected_labels)

From b30f4c78c38abc02b4dcb53253ebe7630e2e10b3 Mon Sep 17 00:00:00 2001
From: Joris Vankerschaver <joris.vankerschaver@gmail.com>
Date: Mon, 20 May 2019 13:47:14 +0100
Subject: [PATCH 19/22] MAINT: Run skipped image tests

---
 chaco/tests/test_image_plot.py | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/chaco/tests/test_image_plot.py b/chaco/tests/test_image_plot.py
index 8e6ae9138..803695064 100644
--- a/chaco/tests/test_image_plot.py
+++ b/chaco/tests/test_image_plot.py
@@ -114,49 +114,41 @@ def verify_result_image(self, input_image, expected_image, **plot_kwargs):
         rms = calculate_rms(image_result, expected_image)
         self.assertLess(rms, MAX_RMS_ERROR)
 
-    @unittest.skipIf(six.PY3, "Bug in the image plotter in python 3. See GH enthought/enable #95.")
     def test_horizontal_top_left(self):
         # Horizontal orientation with top left origin renders original image.
         self.verify_result_image(RGB, IMAGE, origin='top left')
 
-    @unittest.skipIf(six.PY3, "Bug in the image plotter in python 3. See GH enthought/enable #95.")
     def test_horizontal_bottom_left(self):
         # Horizontal orientation with bottom left origin renders a vertically
         # flipped image.
         self.verify_result_image(RGB, IMAGE[::-1], origin='bottom left')
 
-    @unittest.skipIf(six.PY3, "Bug in the image plotter in python 3. See GH enthought/enable #95.")
     def test_horizontal_top_right(self):
         # Horizontal orientation with top right origin renders a horizontally
         # flipped image.
         self.verify_result_image(RGB, IMAGE[:, ::-1], origin='top right')
 
-    @unittest.skipIf(six.PY3, "Bug in the image plotter in python 3. See GH enthought/enable #95.")
     def test_horizontal_bottom_right(self):
         # Horizontal orientation with top right origin renders an image flipped
         # horizontally and vertically.
         self.verify_result_image(RGB, IMAGE[::-1, ::-1], origin='bottom right')
 
-    @unittest.skipIf(six.PY3, "Bug in the image plotter in python 3. See GH enthought/enable #95.")
     def test_vertical_top_left(self):
         # Vertical orientation with top left origin renders transposed image.
         self.verify_result_image(RGB, IMAGE.T, origin='top left', orientation='v')
 
-    @unittest.skipIf(six.PY3, "Bug in the image plotter in python 3. See GH enthought/enable #95.")
     def test_vertical_bottom_left(self):
         # Vertical orientation with bottom left origin renders transposed image
         # that is vertically flipped.
         self.verify_result_image(RGB, (IMAGE.T)[::-1],
                                  origin='bottom left', orientation='v')
 
-    @unittest.skipIf(six.PY3, "Bug in the image plotter in python 3. See GH enthought/enable #95.")
     def test_vertical_top_right(self):
         # Vertical orientation with top right origin renders transposed image
         # that is horizontally flipped.
         self.verify_result_image(RGB, (IMAGE.T)[:, ::-1],
                                  origin='top right', orientation='v')
 
-    @unittest.skipIf(six.PY3, "Bug in the image plotter in python 3. See GH enthought/enable #95.")
     def test_vertical_bottom_right(self):
         # Vertical orientation with bottom right origin renders transposed image
         # that is flipped vertically and horizontally.

From 67055599fcd87505e8fb42fc6c65ccd386dd3ab7 Mon Sep 17 00:00:00 2001
From: Joris Vankerschaver <joris.vankerschaver@gmail.com>
Date: Mon, 20 May 2019 15:00:13 +0100
Subject: [PATCH 20/22] FIX: Typo

---
 chaco/scales/tests/test_time_scale_resolution.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/chaco/scales/tests/test_time_scale_resolution.py b/chaco/scales/tests/test_time_scale_resolution.py
index aa3a5cf7a..6611f3858 100644
--- a/chaco/scales/tests/test_time_scale_resolution.py
+++ b/chaco/scales/tests/test_time_scale_resolution.py
@@ -176,9 +176,9 @@ def test_widths(self):
     def test_labels(self):
         fmt = TimeFormatter()
         scale = ScaleSystem(*HMSScales)
-        expected_labels = ['{}m'.format(m) for n in range(30, 51)]
+        expected_labels = ['{}m'.format(m) for m in range(30, 51)]
         
-        test_intervals = ([(2005,3,15,10,30), (2005,3,15,10,50), 150])
+        test_intervals = ([(2005,3,15,10,30), (2005,3,15,10,50), 150],)
         for start, end, width in test_intervals:
             labels = scale.labels(DTS(*start), DTS(*end), char_width=width)
             labels = [label for (_, label) in labels]

From f5db0ed504000b019b7bec3db8d941e7f9ede6a1 Mon Sep 17 00:00:00 2001
From: Joris Vankerschaver <joris.vankerschaver@gmail.com>
Date: Sat, 25 May 2019 00:29:07 +0100
Subject: [PATCH 21/22] MAINT: Remove unused expectedFailure

---
 chaco/tools/tests/test_range_selection.py | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/chaco/tools/tests/test_range_selection.py b/chaco/tools/tests/test_range_selection.py
index dfc0822f6..3a123d596 100644
--- a/chaco/tools/tests/test_range_selection.py
+++ b/chaco/tools/tests/test_range_selection.py
@@ -52,11 +52,7 @@ def test_selecting_mouse_leave_clipping(self):
                         self.assertTrue(selection[0] <= selection[1])
                         self.mouse_up(tool, x=x, y=y)
 
-    @unittest.expectedFailure
     def test_selection_no_warning(self):
-        # Skipped because traits generates a DeprecationWarning that
-        # causes the test to fail.
-        
         plot_data = ArrayPlotData()
         arr = np.arange(4)
         plot_data.set_data("x", arr)

From 2d7d82331a5d373bdb7e3a7fc4f2e9ce832c6709 Mon Sep 17 00:00:00 2001
From: Joris Vankerschaver <joris.vankerschaver@gmail.com>
Date: Sat, 25 May 2019 01:12:57 +0100
Subject: [PATCH 22/22] FIX: Correctly ignore traits warning on 3.6

---
 chaco/tools/tests/test_range_selection.py | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/chaco/tools/tests/test_range_selection.py b/chaco/tools/tests/test_range_selection.py
index 3a123d596..326bedb66 100644
--- a/chaco/tools/tests/test_range_selection.py
+++ b/chaco/tools/tests/test_range_selection.py
@@ -61,7 +61,12 @@ def test_selection_no_warning(self):
         renderer = plot.plot(('x', 'y'))[0]
         tool = RangeSelection(renderer)
         with warnings.catch_warnings(record=True) as w:
+            # Ignore warnings coming from Traits
+            warnings.filterwarnings(
+                "ignore", 'elementwise == comparison failed'
+            )
             tool.selection = np.array([2.0, 3.0])
+
         self.assertEqual(w, [])
 
         # Accept tuples and lists and None