From 968eead09f59467210bba0fc33d2322a575a298d Mon Sep 17 00:00:00 2001 From: Orien Madgwick <497874+orien@users.noreply.github.com> Date: Sun, 7 Dec 2025 07:31:18 +0700 Subject: [PATCH 1/2] docs: remove maintainers section from the readme document --- README.md | 5 ----- 1 file changed, 5 deletions(-) diff --git a/README.md b/README.md index e6cc62a1..901fae7f 100644 --- a/README.md +++ b/README.md @@ -794,11 +794,6 @@ CLI directly rather than via a stack update. applied in CloudFormation. This can happen if the template or computed parameters have changed in code and the change hasn't been applied to this stack. -## Maintainers - -- [Steve Hodgkiss](https://github.com/stevehodgkiss) -- [Glen Stampoultzis](https://github.com/gstamp) - ## License StackMaster uses the MIT license. See [LICENSE.txt](https://github.com/envato/stack_master/blob/master/LICENSE.txt) for details. From 3c876f031078b84e682ea987b4d96a802d8efe64 Mon Sep 17 00:00:00 2001 From: Orien Madgwick <497874+orien@users.noreply.github.com> Date: Sun, 7 Dec 2025 14:07:06 +0700 Subject: [PATCH 2/2] tests: avoid matching on error messages that differ by Ruby release --- spec/stack_master/parameter_resolvers/one_password_spec.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spec/stack_master/parameter_resolvers/one_password_spec.rb b/spec/stack_master/parameter_resolvers/one_password_spec.rb index e358528b..72940b32 100644 --- a/spec/stack_master/parameter_resolvers/one_password_spec.rb +++ b/spec/stack_master/parameter_resolvers/one_password_spec.rb @@ -135,7 +135,7 @@ before do ENV['OP_SESSION_something'] = 'session' end - + it 'we return an error' do allow_any_instance_of(described_class).to receive(:`).with("op --version").and_raise(Errno::ENOENT) expect { resolver.resolve(the_password) }.to raise_error(StackMaster::ParameterResolvers::OnePassword::OnePasswordBinaryNotFound, "The op cli needs to be installed and in the PATH, No such file or directory") @@ -158,7 +158,7 @@ it 'we return an error' do allow_any_instance_of(described_class).to receive(:`).with("op --version").and_return(true) allow_any_instance_of(described_class).to receive(:`).with("op get item --vault='Shared' 'password title' 2>&1").and_return('{key: value }') - expect { resolver.resolve(the_password) }.to raise_error(StackMaster::ParameterResolvers::OnePassword::OnePasswordInvalidResponse, /Failed to parse JSON returned, {key: value }:.* unexpected token at '{key: value }'/) + expect { resolver.resolve(the_password) }.to raise_error(StackMaster::ParameterResolvers::OnePassword::OnePasswordInvalidResponse, /Failed to parse JSON returned, {key: value }:/) end end end