From 13fc9f2aefe3ced1ae1db615994b4b19d07b84be Mon Sep 17 00:00:00 2001 From: Harvey Tuch Date: Mon, 30 Oct 2017 13:54:06 -0400 Subject: [PATCH 1/2] cds: update cluster name restrictions in Cluster. In response to https://github.com/envoyproxy/envoy/pull/1806 and https://github.com/envoyproxy/envoy/pull/1871. Signed-off-by: Harvey Tuch --- api/cds.proto | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/api/cds.proto b/api/cds.proto index 6365fe480..18e7ba2bc 100644 --- a/api/cds.proto +++ b/api/cds.proto @@ -63,8 +63,7 @@ message CircuitBreakers { message Cluster { // Supplies the name of the cluster which must be unique across all clusters. - // The cluster name is used when emitting statistics. The cluster name can be - // at most 60 characters long, and must not contain :. + // Any : in the cluster name will be converted to _ when emitting statistics. string name = 1; // The service discovery type to use for resolving the cluster. From a29f4e8362b34429b3fdaf1d7b6012e9a7da42f7 Mon Sep 17 00:00:00 2001 From: Harvey Tuch Date: Mon, 30 Oct 2017 14:05:11 -0400 Subject: [PATCH 2/2] TODO to add cross-link to CLI docs. Signed-off-by: Harvey Tuch --- api/cds.proto | 2 ++ 1 file changed, 2 insertions(+) diff --git a/api/cds.proto b/api/cds.proto index 18e7ba2bc..75a42e55a 100644 --- a/api/cds.proto +++ b/api/cds.proto @@ -64,6 +64,8 @@ message CircuitBreakers { message Cluster { // Supplies the name of the cluster which must be unique across all clusters. // Any : in the cluster name will be converted to _ when emitting statistics. + // TODO(htuch): cross-link to + // https://www.envoyproxy.io/envoy/operations/cli#cmdoption-max-obj-name-len. string name = 1; // The service discovery type to use for resolving the cluster.