From f2c883a65c42ded8a8fe7e2ef01cddd86115dbc5 Mon Sep 17 00:00:00 2001 From: Kuat Yessenov Date: Thu, 26 Dec 2019 10:26:15 -0800 Subject: [PATCH 1/2] fix examples Signed-off-by: Kuat Yessenov --- echo2_config.cc | 2 +- http-filter-example/http_filter_config.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/echo2_config.cc b/echo2_config.cc index 33c3c2811..5f4b8bd35 100644 --- a/echo2_config.cc +++ b/echo2_config.cc @@ -25,7 +25,7 @@ class Echo2ConfigFactory : public NamedNetworkFilterConfigFactory { return ProtobufTypes::MessagePtr{new Envoy::ProtobufWkt::Empty()}; } - std::string name() override { return "echo2"; } + const std::string name() const override { return "echo2"; } bool isTerminalFilter() override { return true; } }; diff --git a/http-filter-example/http_filter_config.cc b/http-filter-example/http_filter_config.cc index 648cbaaa7..5c8b098a9 100644 --- a/http-filter-example/http_filter_config.cc +++ b/http-filter-example/http_filter_config.cc @@ -28,7 +28,7 @@ class HttpSampleDecoderFilterConfig : public NamedHttpFilterConfigFactory { return ProtobufTypes::MessagePtr{new sample::Decoder()}; } - std::string name() override { return "sample"; } + const std::string name() const override { return "sample"; } private: Http::FilterFactoryCb createFilter(const sample::Decoder& proto_config, FactoryContext&) { From 51107b6f5ca2bff8c917e04cc26f33e224bb3f39 Mon Sep 17 00:00:00 2001 From: Kuat Yessenov Date: Mon, 30 Dec 2019 13:45:02 -0800 Subject: [PATCH 2/2] drop const from string Signed-off-by: Kuat Yessenov --- echo2_config.cc | 2 +- http-filter-example/http_filter_config.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/echo2_config.cc b/echo2_config.cc index 5f4b8bd35..011a6f5bf 100644 --- a/echo2_config.cc +++ b/echo2_config.cc @@ -25,7 +25,7 @@ class Echo2ConfigFactory : public NamedNetworkFilterConfigFactory { return ProtobufTypes::MessagePtr{new Envoy::ProtobufWkt::Empty()}; } - const std::string name() const override { return "echo2"; } + std::string name() const override { return "echo2"; } bool isTerminalFilter() override { return true; } }; diff --git a/http-filter-example/http_filter_config.cc b/http-filter-example/http_filter_config.cc index 5c8b098a9..b946e96d5 100644 --- a/http-filter-example/http_filter_config.cc +++ b/http-filter-example/http_filter_config.cc @@ -28,7 +28,7 @@ class HttpSampleDecoderFilterConfig : public NamedHttpFilterConfigFactory { return ProtobufTypes::MessagePtr{new sample::Decoder()}; } - const std::string name() const override { return "sample"; } + std::string name() const override { return "sample"; } private: Http::FilterFactoryCb createFilter(const sample::Decoder& proto_config, FactoryContext&) {