From e21c13be193ee213708b06546166c4af554b76ae Mon Sep 17 00:00:00 2001 From: Jose Nino Date: Tue, 13 Sep 2016 15:02:42 -0700 Subject: [PATCH 1/2] Bandaid fix to fix CI failures --- test/server/http/admin_test.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/server/http/admin_test.cc b/test/server/http/admin_test.cc index 4f70a3940d9c3..5bd77f9db37a6 100644 --- a/test/server/http/admin_test.cc +++ b/test/server/http/admin_test.cc @@ -9,8 +9,9 @@ namespace Server { class AdminFilterTest : public testing::Test { public: + //TODO: change the port. This is a hacky fix for CI. AdminFilterTest() - : admin_("/dev/null", 9001, server_), filter_(admin_), request_headers_{{":path", "/"}} { + : admin_("/dev/null", 9002, server_), filter_(admin_), request_headers_{{":path", "/"}} { filter_.setDecoderFilterCallbacks(callbacks_); } From 642f58297798d10f1caae638ccff0fd3bfa85a3f Mon Sep 17 00:00:00 2001 From: Matt Klein Date: Tue, 13 Sep 2016 15:17:12 -0700 Subject: [PATCH 2/2] Update admin_test.cc --- test/server/http/admin_test.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/server/http/admin_test.cc b/test/server/http/admin_test.cc index 5bd77f9db37a6..2fe60dddc644a 100644 --- a/test/server/http/admin_test.cc +++ b/test/server/http/admin_test.cc @@ -9,7 +9,7 @@ namespace Server { class AdminFilterTest : public testing::Test { public: - //TODO: change the port. This is a hacky fix for CI. + // TODO: Switch to mocks and do not bind to a real port. AdminFilterTest() : admin_("/dev/null", 9002, server_), filter_(admin_), request_headers_{{":path", "/"}} { filter_.setDecoderFilterCallbacks(callbacks_);