Support SMPTE ST12-3 high frame rate variants#66
Merged
eoyilmaz merged 6 commits intoeoyilmaz:developfrom Dec 29, 2025
Merged
Conversation
….88) - Update `timecode/__init__.py` to handle "119.88" framerate explicitly, setting `_int_framerate` to 120 and enabling drop frame. - Add support for 72, 96, 100, 120 fps via generic integer handling (verified). - Add comprehensive tests in `tests/test_timecode.py` for new frame rates, including string representation, frame count, and rollover behavior.
Change names of tests where name didn't match what was actually tested
|
You could automate NTSC detection to anything multiple of 23.976 or 29.97. All of the following framerates are valid NTSC rates, some of which can be seen in studios, and occasionally on consumer-grade products.
and so on. Of course, drop frame does not apply to multiples of 23.976 that aren't a multiple of 29.97 as well. Perhaps 47.952 is the most common of the bunch. TV broadcast of HFR theatrical features (e.g. The Hobbit) are typically rate changed to 47.952 and a pulldown is applied to make them display at 59.94. |
Owner
|
Thanks for the PR, merged 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This required only minor code changes to handle 119.88 drop frame, but significant additional testing to check correctness.
Closes #37