From a05005521e28cc88bfd7d28c930dfcd776875878 Mon Sep 17 00:00:00 2001 From: PowerStream3604 <63450340+PowerStream3604@users.noreply.github.com> Date: Sat, 31 Aug 2024 23:41:57 +0900 Subject: [PATCH 1/2] fix: uninit userop validation --- src/account/ModuleManagerInternals.sol | 1 + 1 file changed, 1 insertion(+) diff --git a/src/account/ModuleManagerInternals.sol b/src/account/ModuleManagerInternals.sol index 31ae1452..2bc302ad 100644 --- a/src/account/ModuleManagerInternals.sol +++ b/src/account/ModuleManagerInternals.sol @@ -97,6 +97,7 @@ abstract contract ModuleManagerInternals is IModularAccount { _validationData.isGlobal = false; _validationData.isSignatureValidation = false; + _validationData.isUserOpValidation = false; // Clear the selectors uint256 length = _validationData.selectors.length(); From 89be871c2f157ddf7a27e1c8707135fc91d9ca4b Mon Sep 17 00:00:00 2001 From: PowerStream3604 <63450340+PowerStream3604@users.noreply.github.com> Date: Sat, 31 Aug 2024 23:51:52 +0900 Subject: [PATCH 2/2] fix: remove redundant selector clearing code --- src/account/ModuleManagerInternals.sol | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/account/ModuleManagerInternals.sol b/src/account/ModuleManagerInternals.sol index 2bc302ad..adfef508 100644 --- a/src/account/ModuleManagerInternals.sol +++ b/src/account/ModuleManagerInternals.sol @@ -98,12 +98,6 @@ abstract contract ModuleManagerInternals is IModularAccount { _validationData.isGlobal = false; _validationData.isSignatureValidation = false; _validationData.isUserOpValidation = false; - - // Clear the selectors - uint256 length = _validationData.selectors.length(); - for (uint256 i = 0; i < length; ++i) { - _validationData.selectors.remove(_validationData.selectors.at(0)); - } } function _addExecHooks(EnumerableSet.Bytes32Set storage hooks, HookConfig hookConfig) internal {