[BUG] Update 2.0.0 to 2.1.0 collect.query_store_collector missing columns

[ryanvs]

Component

Installer (GUI)

Performance Monitor Version

2.1.0

SQL Server Version

SQL Server 2022 RTM - 16.0.1000.6

Windows Version

Windows Server 2022 Standard

Describe the Bug

When upgrading from PerformanceInstaller 2.0.0 GUI to 2.1.0 GUI, an error was thrown:

Executing 09_collect_query_store.sql...
[ERROR] 09_collect_query_store.sql - FAILED: Batch 4 failed:
ALTER PROCEDURE
    collect.query_store_collector
(
    @debug bit = 0 /*Print debugging information*/
)
WITH RECOMPILE
AS
BEGIN
    SET NOCOUNT ON;
    SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;

    DECLARE
        @rows_collected bigint = 0,
        @start_time datetime2(7) = SYSDATETIME(),
        @last_collection_time datetimeoffset(7) = NULL,
        @collection_interval_minutes integer = NULL,
        @cutoff_time datetimeoffset(7) = NULL,
        @sql nvarchar(max... [truncated, total length: 28887]

Original error: Invalid column name 'collect_query'.
Invalid column name 'collect_plan'.

Steps to Reproduce

1. Begin with PerformanceMonitor 2.0.0
2. Start PerformanceMonitorInstallerGui.exe
3. Press "Test Connection"
4. Press "Install"
5. Observe "Installation Log"

Expected Behavior

Expected successful completion of all installation and upgrade scripts

Actual Behavior

File install\09_collect_query_store.sql failed -- I also tried from SSMS:

Msg 207, Level 16, State 1, Procedure query_store_collector, Line 180 [Batch Start Line 31]
Invalid column name 'collect_query'.
Msg 207, Level 16, State 1, Procedure query_store_collector, Line 181 [Batch Start Line 31]
Invalid column name 'collect_plan'.

Error Messages / Log Output

Screenshots

No response

Additional Context

No response

[erikdarlingdata]

Hi! This is a known issue — the GUI installer had a bug where it wasn't picking up the scripts in the upgrades/ folder during an upgrade from 2.0.0 to 2.1.0 (see #409, fixed in PR #414).

The collect_query and collect_plan columns that the procedure references are added by the upgrade script upgrades/2.0.0-to-2.1.0/01_collection_schedule_optional_text.sql. If you navigate to that folder from the installer download, you can run that SQL manually, and then the procedure will create successfully.