[BUG] Invalid Column Name errors for collect.database_size_stats_collector

[IzGonnaDie]

Component

Full Dashboard

Performance Monitor Version

2.5.0

SQL Server Version

Microsoft SQL Server 2022 (RTM-CU18) (KB5050771) - 16.0.4185.3 (X64) Feb 28 2025 18:24:49 Copyright (C) 2022 Microsoft Corporation Developer Edition (64-bit) on Windows 10 Enterprise 10.0 (Build 26200: ) (Hypervisor)

Windows Version

Windows 11 25H2

Describe the Bug

When updating from 2.2.0 to 2.5.0, the update fails on 52_collect_database_size_stats.sql, with the following three errors:

• Original error: Invalid column name 'is_percent_growth'.
• Invalid column name 'growth_pct'.
• Invalid column name 'vlf_count'.

Steps to Reproduce

1. Perform a fresh install of 2.2.0, using the Full PerformanceMonitorInstallerGui.exe (called InstanceA)
2. Open the Full Dashboard v2.2.0
3. Add InstanceA to the Dashboard
4. Fully close the Full Dashboard v2.2.0
5. Open the Full Dashboard v2.5.0
6. Click "Add Server"
7. Enter information for InstanceA, then click "Test Connection"
8. The "Add SQL Server" window detected version 2.2.0 installed, recognizing the database installation could be updated to 2.5.0. Select the "Update Now" option

Expected Behavior

The step to upgrade an installation from 2.2.0 to 2.5.0 should execute.

Actual Behavior

The step to upgrade an installation from 2.2.0 to 2.5.0 did not execute. It appears a normal installation occurred, likely causing the errors.

Error Messages / Log Output

Captured from the "Add Server" screen:
____________________________________________________________________________________

Checking for upgrades from v2.2.0 to v2.5.0...
Starting main installation...
Starting installation...
Executing 01_install_database.sql...
[OK] 01_install_database.sql - Success
Executing 02_create_tables.sql...
[OK] 02_create_tables.sql - Success
Executing 03_create_config_tables.sql...
[OK] 03_create_config_tables.sql - Success
Executing 04_create_schedule_table.sql...
[OK] 04_create_schedule_table.sql - Success
Executing 05_delta_framework.sql...
[OK] 05_delta_framework.sql - Success
Executing 06_ensure_collection_table.sql...
[OK] 06_ensure_collection_table.sql - Success
Executing 07_collect_wait_stats.sql...
[OK] 07_collect_wait_stats.sql - Success
Executing 08_collect_query_stats.sql...
[OK] 08_collect_query_stats.sql - Success
Executing 09_collect_query_store.sql...
[OK] 09_collect_query_store.sql - Success
Executing 10_collect_procedure_stats.sql...
[OK] 10_collect_procedure_stats.sql - Success
Executing 11_collect_query_snapshots.sql...
[OK] 11_collect_query_snapshots.sql - Success
Executing 12_query_snapshots_create_views.sql...
[OK] 12_query_snapshots_create_views.sql - Success
Executing 13_query_snapshots_retention.sql...
[OK] 13_query_snapshots_retention.sql - Success
Executing 14_collect_memory_stats.sql...
[OK] 14_collect_memory_stats.sql - Success
Executing 15_collect_memory_grant_stats.sql...
[OK] 15_collect_memory_grant_stats.sql - Success
Executing 16_collect_memory_clerks_stats.sql...
[OK] 16_collect_memory_clerks_stats.sql - Success
Executing 17_collect_cpu_scheduler_stats.sql...
[OK] 17_collect_cpu_scheduler_stats.sql - Success
Executing 18_collect_cpu_utilization_stats.sql...
[OK] 18_collect_cpu_utilization_stats.sql - Success
Executing 19_collect_perfmon_stats.sql...
[OK] 19_collect_perfmon_stats.sql - Success
Executing 20_collect_file_io_stats.sql...
[OK] 20_collect_file_io_stats.sql - Success
Executing 21_setup_blocked_process_xe.sql...
[OK] 21_setup_blocked_process_xe.sql - Success
Executing 22_collect_blocked_processes.sql...
[OK] 22_collect_blocked_processes.sql - Success
Executing 23_process_blocked_process_xml.sql...
[OK] 23_process_blocked_process_xml.sql - Success
Executing 24_collect_deadlock_xml.sql...
[OK] 24_collect_deadlock_xml.sql - Success
Executing 25_process_deadlock_xml.sql...
[OK] 25_process_deadlock_xml.sql - Success
Executing 26_blocking_deadlock_analyzer.sql...
[OK] 26_blocking_deadlock_analyzer.sql - Success
Executing 27_collect_ring_buffer_events.sql...
[OK] 27_collect_ring_buffer_events.sql - Success
Executing 28_collect_system_health_wrapper.sql...
[OK] 28_collect_system_health_wrapper.sql - Success
Executing 29_collect_default_trace.sql...
[OK] 29_collect_default_trace.sql - Success
Executing 30_collect_trace_management.sql...
[OK] 30_collect_trace_management.sql - Success
Executing 31_collect_trace_analysis.sql...
[OK] 31_collect_trace_analysis.sql - Success
Executing 32_collect_latch_stats.sql...
[OK] 32_collect_latch_stats.sql - Success
Executing 33_collect_spinlock_stats.sql...
[OK] 33_collect_spinlock_stats.sql - Success
Executing 34_collect_tempdb_stats.sql...
[OK] 34_collect_tempdb_stats.sql - Success
Executing 35_collect_plan_cache_stats.sql...
[OK] 35_collect_plan_cache_stats.sql - Success
Executing 36_collect_session_stats.sql...
[OK] 36_collect_session_stats.sql - Success
Executing 37_collect_waiting_tasks.sql...
[OK] 37_collect_waiting_tasks.sql - Success
Executing 38_collect_server_configuration.sql...
[OK] 38_collect_server_configuration.sql - Success
Executing 39_collect_database_configuration.sql...
[OK] 39_collect_database_configuration.sql - Success
Executing 41_schedule_management.sql...
[OK] 41_schedule_management.sql - Success
Executing 42_scheduled_master_collector.sql...
[OK] 42_scheduled_master_collector.sql - Success
Executing 43_data_retention.sql...
[OK] 43_data_retention.sql - Success
Executing 44_hung_job_monitor.sql...
[OK] 44_hung_job_monitor.sql - Success
Executing 45_create_agent_jobs.sql...
[OK] 45_create_agent_jobs.sql - Success
Executing 46_create_query_plan_views.sql...
[OK] 46_create_query_plan_views.sql - Success
Executing 47_create_reporting_views.sql...
[OK] 47_create_reporting_views.sql - Success
Executing 48_create_additional_reporting_views.sql...
[OK] 48_create_additional_reporting_views.sql - Success
Executing 49_health_parser_tables.sql...
[OK] 49_health_parser_tables.sql - Success
Executing 50_configuration_issues_analyzer.sql...
[OK] 50_configuration_issues_analyzer.sql - Success
Executing 51_collect_running_jobs.sql...
[OK] 51_collect_running_jobs.sql - Success
Executing 52_collect_database_size_stats.sql...
[ERROR] 52_collect_database_size_stats.sql - FAILED: Batch 4 failed:
ALTER PROCEDURE
    collect.database_size_stats_collector
(
    @debug bit = 0 /*Print debugging information*/
)
WITH RECOMPILE
AS
BEGIN
    SET NOCOUNT ON;
    SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;

    DECLARE
        @rows_collected bigint = 0,
        @start_time datetime2(7) = SYSDATETIME(),
        @error_message nvarchar(4000),
        @engine_edition integer =
            CONVERT(integer, SERVERPROPERTY(N'EngineEdition'));

    BEGIN TRY
        /*
       ... [truncated, total length: 13011]

Original error: Invalid column name 'is_percent_growth'.
Invalid column name 'growth_pct'.
Invalid column name 'vlf_count'.
Executing 53_collect_server_properties.sql...
[OK] 53_collect_server_properties.sql - Success
Executing 54_create_finops_views.sql...
[OK] 54_create_finops_views.sql - Success
Installing community dependencies...
Installing community dependencies...
Installing sp_WhoIsActive...
[OK] sp_WhoIsActive - Success (Query activity monitoring by Adam Machanic (GPLv3))
Installing DarlingData...
[OK] DarlingData - Success (sp_HealthParser, sp_HumanEventsBlockViewer by Erik Darling (MIT))
Installing First Responder Kit...
[WARN] Network error, retrying in 2s (1/3)...
[WARN] Network error, retrying in 4s (2/3)...
[ERROR] First Responder Kit - Download failed: Response status code does not indicate success: 403 (Forbidden).
[WARN] Dependencies installed: 2/3
Executing 98_validate_installation.sql...
[OK] 98_validate_installation.sql - Success
Recording installation history...
[OK] Installation history recorded
Report saved: C:\Users\USER_NAME\PerformanceMonitor_Install_INSTANCE_NAME_20260401_072840.txt
[ERROR] Installation completed with 1 error(s).


____________________________________________________________________________________

Captured from the PerformanceMonitor Install Report:
____________________________________________________________________________________

================================================================================
Performance Monitor Installation Report
================================================================================

INSTALLATION SUMMARY
--------------------------------------------------------------------------------
Status:              FAILED
Start Time:          2026-04-01 07:28:40
End Time:            2026-04-01 07:28:57
Duration:            16.6 seconds
Files Executed:      53
Files Failed:        1

SERVER INFORMATION
--------------------------------------------------------------------------------
Server Name:         INSTANCE_NAME
SQL Server Edition:  Developer Edition (64-bit)

SQL Server Version:
  Microsoft SQL Server 2022 (RTM-CU18) (KB5050771) - 16.0.4185.3 (X64)
  Feb 28 2025 18:24:49
  Copyright (C) 2022 Microsoft Corporation
  Developer Edition (64-bit) on Windows 10 Enterprise 10.0 <X64> (Build 26200: ) (Hypervisor)

INSTALLER INFORMATION
--------------------------------------------------------------------------------
Installer Version:   2.5.0
Working Directory:   \\FILE_SHARE\Performance Monitor\Performance Monitor Dashboard (2.5.0)
Machine Name:        MACHINE_NAME
User Name:           USER_NAME

ERRORS
--------------------------------------------------------------------------------
File: 52_collect_database_size_stats.sql
Error: Batch 4 failed:
ALTER PROCEDURE
    collect.database_size_stats_collector
(
    @debug bit = 0 /*Print debugging information*/
)
WITH RECOMPILE
AS
BEGIN
    SET NOCOUNT ON;
    SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;

    DECLARE
        @rows_collected bigint = 0,
        @start_time datetime2(7) = SYSDATETIME(),
        @error_message nvarchar(4000),
        @engine_edition integer =
            CONVERT(integer, SERVERPROPERTY(N'EngineEdition'));

    BEGIN TRY
   ...

================================================================================
Generated by Performance Monitor Installer
Copyright (c) 2026 Darling Data, LLC
================================================================================

Screenshots

Additional Context

1. The "network errors" when attempting to download the First Responder Kit are a non-issue. Those are caused by a firewall rule on my side.
2. The report generated through the "Add Server" dialog only depicts the error, not the full process. I'm not sure whether this is intended.
3. I selected the "Full Dashboard" component since that is how I performed the upgrade from 2.2.0 to 2.5.0. Let me know if this should have been listed as the GUI installer.

[IzGonnaDie]

I forgot to check before I submitted the report. PerformanceMonitor.config.current_version returns an installer_version of 2.2.0.0.

[erikdarlingdata]

Fixed in #774. Root cause: MSBuild mangles embedded resource names for upgrade folders (2.2.0-to-2.3.0 → _2._2._0_to_2._3._0), which broke upgrade discovery in the Dashboard's embedded resource provider. All upgrade scripts silently failed to load, so the schema changes (adding is_percent_growth, growth_pct, vlf_count columns) never ran before script 52 tried to reference them. Also added server version visibility and a Check for Updates button throughout the Dashboard UI.