Fix squished drill-down charts (#166)#178
Merged
Merged
Conversation
Charts in query/procedure drill-down windows were fixed at 250px height, making them hard to read especially on larger monitors. Changed from fixed height to proportional layout (2* chart / 3* grid) with MinHeight 250 so charts scale with window size while maintaining a minimum. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
erikdarlingdata
added a commit
that referenced
this pull request
Apr 7, 2026
- Rule 1 (Filter): Suppress trivial filters (< 128 reads/10ms actual, < 1.0 cost estimated) - Rule 3 (Serial Plan): Skip trivial statements with cost < 0.01 - Rule 15 (Join OR): Exclude Merge Interval inside anti/semi joins - Rule 20 (Local Variables): Skip trivial statements with cost < 0.01 - Rule 26 (Row Goal): Require >= 2x reduction - ShowPlanParser: Gate XML MemoryGrantWarning at 1 GB - Scalar UDF: Expanded remediation options (variable assignment, 2019+ inlining) All changes applied identically to Dashboard and Lite. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
3 tasks
erikdarlingdata
added a commit
that referenced
this pull request
Apr 7, 2026
- Suppress for TRIVIAL optimization level (can't go parallel anyway) - Suppress for 0ms actual elapsed time - Demote to Info unless user explicitly forced serial (MAXDOP 1 / hint) Ported from PerformanceStudio #178 round 2 feedback. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2 tasks
erikdarlingdata
added a commit
that referenced
this pull request
Apr 9, 2026
…round 3) PlanAnalyzer (Dashboard + Lite): - Rules 3 & 20: SubTreeCost threshold 0.01 → 1.0 (CTFP is integer) - Rule 3: Smarter MaxDOPSetToOne — 3-branch logic with query text check - Rule 5: AllocatesResources gate on zero-rows warning (Hash/Sort/Spool) - Rule 11: Enriched scan-with-predicate (cost %, elapsed %, selectivity) - Rule 12: IsFunctionOnColumnSide — fix non-SARGable false positive - Rules 25/31: GetWaitStatsAdvice for targeted parallelism advice - New Rule 32: Scan cardinality misestimate (actual plans) - New Rule 33: CE guess detection (estimated plans) ShowPlanParser (Dashboard + Lite): - Fix multi-statement batch parsing (iterate all <Statements> children) - Add synthetic root nodes for DECLARE/ASSIGN statements Closes #816. Syncs from PerformanceStudio PR #213. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code