From 4f5c0fdfed5641713523cdf87f5087ade1560626 Mon Sep 17 00:00:00 2001
From: Erik Darling <2136037+erikdarlingdata@users.noreply.github.com>
Date: Wed, 25 Feb 2026 19:26:54 -0500
Subject: [PATCH] Add missing perfmon counters to SQL collector, fix TempDB
 Pressure pack

SQL collector was missing 14 counters that sp_PressureDetector collects
and the UI packs reference. TempDB Pressure pack only showed Forwarded
Records/sec (which isn't even a tempdb counter) because the 8 actual
tempdb counters were never collected. Also missing: Full Scans/sec,
Index Searches/sec, Page Splits/sec, Free list stalls/sec, Processes
blocked, Lock Timeouts/sec.

Remove Forwarded Records/sec from TempDB Pressure pack in both apps.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
---
 Dashboard/Helpers/PerfmonPacks.cs    |  1 -
 Lite/Helpers/PerfmonPacks.cs         |  1 -
 install/19_collect_perfmon_stats.sql | 15 +++++++++++++++
 3 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/Dashboard/Helpers/PerfmonPacks.cs b/Dashboard/Helpers/PerfmonPacks.cs
index 50e9bd19..2bc016ed 100644
--- a/Dashboard/Helpers/PerfmonPacks.cs
+++ b/Dashboard/Helpers/PerfmonPacks.cs
@@ -91,7 +91,6 @@ public static class PerfmonPacks
             "Temp Tables Creation Rate",
             "Workfiles Created/sec",
             "Worktables Created/sec",
-            "Forwarded Records/sec",
         ],
         ["Lock / Blocking"] =
         [
diff --git a/Lite/Helpers/PerfmonPacks.cs b/Lite/Helpers/PerfmonPacks.cs
index a8029db4..e6923dd7 100644
--- a/Lite/Helpers/PerfmonPacks.cs
+++ b/Lite/Helpers/PerfmonPacks.cs
@@ -91,7 +91,6 @@ public static class PerfmonPacks
             "Temp Tables Creation Rate",
             "Workfiles Created/sec",
             "Worktables Created/sec",
-            "Forwarded Records/sec",
         ],
         ["Lock / Blocking"] =
         [
diff --git a/install/19_collect_perfmon_stats.sql b/install/19_collect_perfmon_stats.sql
index 062686e3..6d8bf5de 100644
--- a/install/19_collect_perfmon_stats.sql
+++ b/install/19_collect_perfmon_stats.sql
@@ -157,6 +157,9 @@ BEGIN
         (
             /*I/O counters*/
             N'Forwarded Records/sec',
+            N'Full Scans/sec',
+            N'Index Searches/sec',
+            N'Page Splits/sec',
             N'Page reads/sec',
             N'Page writes/sec',
             N'Checkpoint pages/sec',
@@ -177,6 +180,8 @@ BEGIN
             N'Lock Waits/sec',
             N'Number of Deadlocks/sec',
             N'Lock waits',
+            N'Lock Timeouts/sec',
+            N'Processes blocked',
             /*Memory counters*/
             N'Granted Workspace Memory (KB)',
             N'Lock Memory (KB)',
@@ -187,6 +192,7 @@ BEGIN
             N'Total Server Memory (KB)',
             N'Memory grant queue waits',
             N'Thread-safe memory objects waits',
+            N'Free list stalls/sec',
             /*Compilation counters*/
             N'SQL Compilations/sec',
             N'SQL Re-Compilations/sec',
@@ -205,6 +211,15 @@ BEGIN
             N'Log Flush Write Time (ms)',
             N'Log buffer waits',
             N'Log write waits',
+            /*TempDB counters*/
+            N'Version Store Size (KB)',
+            N'Free Space in tempdb (KB)',
+            N'Active Temp Tables',
+            N'Version Generation rate (KB/s)',
+            N'Version Cleanup rate (KB/s)',
+            N'Temp Tables Creation Rate',
+            N'Workfiles Created/sec',
+            N'Worktables Created/sec',
             /*Wait counters*/
             N'Network IO waits',
             N'Wait for the worker'