Some graphs don't get dark mode until they get data#322
Merged
erikdarlingdata merged 1 commit intoFeb 26, 2026
Merged
Conversation
erikdarlingdata
approved these changes
Feb 26, 2026
Owner
erikdarlingdata
left a comment
erikdarlingdata
left a comment
There was a problem hiding this comment.
All 44 charts across the 3 files are covered — verified against the XAML declarations. Clean fix.
I'll add a follow-up commit for 2 charts in SystemEventsContent.xaml (MemoryBrokerChart, MemoryBrokerRatioChart) that have the same issue.
erikdarlingdata
added a commit
that referenced
this pull request
Feb 26, 2026
Follow-up to PR #322 — SystemEventsContent had the same issue where charts flash white until data loads. Adds upfront ApplyDarkModeToChart calls for all 19 charts in the constructor. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #321
Which component(s) does this affect?
How was this tested?
Opened the tabs and checked they were in dark mode instead of light mode
Changes
Charts will show the dark background immediately when the tabs are opened, instead of flashing white while waiting for data to load. The existing ApplyDarkModeToChart calls inside the load methods are still needed because chart.Plot.Clear() resets all styling — they correctly reapply the theme after clearing.
The Lite project had the same issue. ServerTab.xaml.cs has 23 charts, all of which only had ApplyDarkTheme() called inside data-loading methods. Added upfront calls to the constructor.
Checklist
dotnet build -c Debug)