Sync PlanAnalyzer rule fixes from plan-b#334
Merged
Merged
Conversation
- Rule 5: Handle zero actual rows without division by zero (was producing Unicode infinity) - Rule 8: Add minimum row threshold for parallel skew (threadCount * 1000) to avoid false positives on low-row operators - Rule 24: Only fire Top Above Scan on inner side of Nested Loops, not standalone SELECT TOP - Lite: Full sync from Rules 1-11 to Rules 1-24 (was missing 12-24 entirely) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
erikdarlingdata
force-pushed
the
fix/plan-analyzer-rule-sync
branch
from
1f59d2d to
f4c5f26
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
threadCount * 1000) to avoid false positives on low-row operators like TopN Sort with 20 rowsTest plan
🤖 Generated with Claude Code