Skip to content

Rule 8: Lower parallel skew thresholds, remove 4-thread minimum #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erikdarlingdata merged 1 commit into from
Feb 27, 2026
Merged

Rule 8: Lower parallel skew thresholds, remove 4-thread minimum #342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Dashboard/Services/PlanAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,8 @@
{
var maxThread = node.PerThreadStats.OrderByDescending(t => t.ActualRows).First();
var skewRatio = (double)maxThread.ActualRows / totalRows;
if (skewRatio >= 0.9 && node.PerThreadStats.Count >= 4)
var skewThreshold = node.PerThreadStats.Count == 2 ? 0.75 : 0.50;
if (skewRatio >= skewThreshold)
{
node.Warnings.Add(new PlanWarning
{
Expand Down Expand Up @@ -453,7 +454,7 @@

// Rule 22: Table variables (Object name starts with @)
if (!string.IsNullOrEmpty(node.ObjectName) &&
node.ObjectName.Contains("@"))

Check warning on line 457 in Dashboard/Services/PlanAnalyzer.cs

View workflow job for this annotation

GitHub Actions / build 

Use 'string.Contains(char)' instead of 'string.Contains(string)' when searching for a single character (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1847)

Check warning on line 457 in Dashboard/Services/PlanAnalyzer.cs

View workflow job for this annotation

GitHub Actions / build 

Use 'string.Contains(char)' instead of 'string.Contains(string)' when searching for a single character (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1847)

Check warning on line 457 in Dashboard/Services/PlanAnalyzer.cs

View workflow job for this annotation

GitHub Actions / build 

Use 'string.Contains(char)' instead of 'string.Contains(string)' when searching for a single character (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1847)

Check warning on line 457 in Dashboard/Services/PlanAnalyzer.cs

View workflow job for this annotation

GitHub Actions / build 

Use 'string.Contains(char)' instead of 'string.Contains(string)' when searching for a single character (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1847)

Check warning on line 457 in Dashboard/Services/PlanAnalyzer.cs

View workflow job for this annotation

GitHub Actions / build 

Use 'string.Contains(char)' instead of 'string.Contains(string)' when searching for a single character (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1847)

Check warning on line 457 in Dashboard/Services/PlanAnalyzer.cs

View workflow job for this annotation

GitHub Actions / build 

Use 'string.Contains(char)' instead of 'string.Contains(string)' when searching for a single character (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1847)
{
node.Warnings.Add(new PlanWarning
{
Expand Down
3 changes: 2 additions & 1 deletion Lite/Services/PlanAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,8 @@
{
var maxThread = node.PerThreadStats.OrderByDescending(t => t.ActualRows).First();
var skewRatio = (double)maxThread.ActualRows / totalRows;
if (skewRatio >= 0.9 && node.PerThreadStats.Count >= 4)
var skewThreshold = node.PerThreadStats.Count == 2 ? 0.75 : 0.50;
if (skewRatio >= skewThreshold)
{
node.Warnings.Add(new PlanWarning
{
Expand Down Expand Up @@ -453,7 +454,7 @@

// Rule 22: Table variables (Object name starts with @)
if (!string.IsNullOrEmpty(node.ObjectName) &&
node.ObjectName.Contains("@"))

Check warning on line 457 in Lite/Services/PlanAnalyzer.cs

View workflow job for this annotation

GitHub Actions / build 

Use 'string.Contains(char)' instead of 'string.Contains(string)' when searching for a single character (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1847)

Check warning on line 457 in Lite/Services/PlanAnalyzer.cs

View workflow job for this annotation

GitHub Actions / build 

Use 'string.Contains(char)' instead of 'string.Contains(string)' when searching for a single character (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1847)

Check warning on line 457 in Lite/Services/PlanAnalyzer.cs

View workflow job for this annotation

GitHub Actions / build 

Use 'string.Contains(char)' instead of 'string.Contains(string)' when searching for a single character (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1847)

Check warning on line 457 in Lite/Services/PlanAnalyzer.cs

View workflow job for this annotation

GitHub Actions / build 

Use 'string.Contains(char)' instead of 'string.Contains(string)' when searching for a single character (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1847)
{
node.Warnings.Add(new PlanWarning
{
Expand Down
Loading