Fix ReadOnlyIntent connections sharing server_id in DuckDB#521
Merged
Conversation
When the same server was added twice with different ApplicationIntent (primary vs read-only replica), both produced identical server_id hashes because GetServerId() only hashed ServerName. All collected data merged under one ID, making charts identical for both tabs. Fix: GetServerNameForStorage() appends ":RO" to the server name when ReadOnlyIntent is true, producing a unique server_id and distinct server_name in DuckDB. Non-RO servers are unchanged (no migration). Also adds "(Read-Only)" indicators throughout the UI: sidebar, tab headers, status bar, alerts, tray notifications, overview cards, Manage Servers grid, and MCP tool responses. Status bar now updates on tab switch to reflect the active server. Tested with Azure SQL DB Business Critical readable replica. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
server_idhash becauseGetServerId()only hashedServerName. All collected data merged under one ID, making charts identical for both tabs.GetServerNameForStorage()now appends":RO"whenReadOnlyIntent=true, producing a uniqueserver_idand distinctserver_namein DuckDB. Non-RO servers get the same hash as before (no migration needed).Test plan
server_idvalues in DuckDB🤖 Generated with Claude Code