Skip to content

Fix SignPath signing: upload directories instead of zips #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erikdarlingdata merged 4 commits into from
Mar 12, 2026
Merged

Fix SignPath signing: upload directories instead of zips #526

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
564bab0
Fix poison wait false positives and alert log parsing (#445) (#447)
erikdarlingdata Mar 6, 2026
05c6d6a
Revert "Fix poison wait false positives and alert log parsing (#445) …
erikdarlingdata Mar 6, 2026
2331254
Merge pull request #525 from erikdarlingdata/dev
erikdarlingdata Mar 12, 2026
a995eed
Fix SignPath signing by uploading directories instead of zips
erikdarlingdata Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,23 +86,23 @@ jobs:
uses: actions/upload-artifact@v4
with:
name: Dashboard-unsigned
path: releases/PerformanceMonitorDashboard-${{ steps.version.outputs.VERSION }}.zip
path: publish/Dashboard/

- name: Upload Lite for signing
if: github.event_name == 'release'
id: upload-lite
uses: actions/upload-artifact@v4
with:
name: Lite-unsigned
path: releases/PerformanceMonitorLite-${{ steps.version.outputs.VERSION }}.zip
path: publish/Lite/

- name: Upload Installer for signing
if: github.event_name == 'release'
id: upload-installer
uses: actions/upload-artifact@v4
with:
name: Installer-unsigned
path: releases/PerformanceMonitorInstaller-${{ steps.version.outputs.VERSION }}.zip
path: publish/Installer/

- name: Sign Dashboard
if: github.event_name == 'release'
Expand Down Expand Up @@ -147,9 +147,14 @@ jobs:
if: github.event_name == 'release'
shell: pwsh
run: |
Copy-Item 'signed/Dashboard/*' 'releases/' -Force
Copy-Item 'signed/Lite/*' 'releases/' -Force
Copy-Item 'signed/Installer/*' 'releases/' -Force
$version = "${{ steps.version.outputs.VERSION }}"
# Re-zip signed files into release archives
Remove-Item "releases/PerformanceMonitorDashboard-$version.zip" -ErrorAction SilentlyContinue
Compress-Archive -Path 'signed/Dashboard/*' -DestinationPath "releases/PerformanceMonitorDashboard-$version.zip" -Force
Remove-Item "releases/PerformanceMonitorLite-$version.zip" -ErrorAction SilentlyContinue
Compress-Archive -Path 'signed/Lite/*' -DestinationPath "releases/PerformanceMonitorLite-$version.zip" -Force
Remove-Item "releases/PerformanceMonitorInstaller-$version.zip" -ErrorAction SilentlyContinue
Compress-Archive -Path 'signed/Installer/*' -DestinationPath "releases/PerformanceMonitorInstaller-$version.zip" -Force

- name: Generate checksums
if: github.event_name == 'release'
Expand Down
Loading