From c77e970fb9ce92f3a1c3cec2388185858d3bf071 Mon Sep 17 00:00:00 2001 From: Erik Darling <2136037+erikdarlingdata@users.noreply.github.com> Date: Wed, 1 Apr 2026 16:29:26 -0400 Subject: [PATCH] Fix embedded resource upgrade discovery and add server version UX (#772) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit MSBuild mangles embedded resource names for upgrade folders (e.g., "2.2.0-to-2.3.0" becomes "_2._2._0_to_2._3._0"), which caused EmbeddedResourceScriptProvider to fail parsing all upgrade folders. Dashboard upgrades silently returned zero results, so upgrade scripts never ran and schema changes were missing. Fix: use regex to match mangled names and unmangle back to original folder names. Also surface installed Monitor version throughout the Dashboard UX — NOC health cards, sidebar server list, right-click context menus, Manage Servers, and a new "Check for Updates" button in the Edit Server dialog. Pin dialog buttons outside the scroll area so they remain visible during long install/upgrade operations. Fixes #772 Co-Authored-By: Claude Opus 4.6 (1M context) --- Dashboard/AddServerDialog.xaml | 36 ++++--- Dashboard/AddServerDialog.xaml.cs | 18 ++++ Dashboard/Controls/LandingPage.xaml | 4 +- Dashboard/Controls/LandingPage.xaml.cs | 79 +++++++++++++++ Dashboard/Controls/ServerHealthCard.xaml | 13 +++ Dashboard/Controls/ServerHealthCard.xaml.cs | 20 ++++ Dashboard/MainWindow.xaml | 9 ++ Dashboard/MainWindow.xaml.cs | 71 +++++++++++++ Dashboard/ManageServersWindow.xaml | 1 + Dashboard/ManageServersWindow.xaml.cs | 107 ++++++++++++++++++++ Dashboard/Models/ServerConnectionStatus.cs | 6 ++ Dashboard/Models/ServerHealthStatus.cs | 18 ++++ Dashboard/Models/ServerListItem.cs | 17 ++++ Dashboard/Services/ServerManager.cs | 42 ++++++++ Installer.Core/Patterns.cs | 8 ++ Installer.Core/ScriptProvider.cs | 53 ++++++++-- Installer.Tests/UpgradeOrderingTests.cs | 35 +++++++ 17 files changed, 514 insertions(+), 23 deletions(-) diff --git a/Dashboard/AddServerDialog.xaml b/Dashboard/AddServerDialog.xaml index bcdb6cae..a4c788f1 100644 --- a/Dashboard/AddServerDialog.xaml +++ b/Dashboard/AddServerDialog.xaml @@ -2,13 +2,19 @@ xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" Title="Add SQL Server" - SizeToContent="Height" Width="500" MaxHeight="1050" + Height="750" Width="500" WindowStartupLocation="CenterOwner" - ResizeMode="NoResize" + ResizeMode="CanResizeWithGrip" Background="{DynamicResource BackgroundBrush}" Foreground="{DynamicResource ForegroundBrush}"> - - + + + + + + + + @@ -16,7 +22,6 @@ - @@ -217,14 +222,17 @@ Foreground="{DynamicResource ForegroundMutedBrush}" TextWrapping="Wrap" Margin="0,8,0,0" Visibility="Collapsed"/> - - -