Port warning rule improvements from PerformanceStudio#795
Merged
Conversation
- Rule 1 (Filter): Suppress trivial filters (< 128 reads/10ms actual, < 1.0 cost estimated) - Rule 3 (Serial Plan): Skip trivial statements with cost < 0.01 - Rule 15 (Join OR): Exclude Merge Interval inside anti/semi joins - Rule 20 (Local Variables): Skip trivial statements with cost < 0.01 - Rule 26 (Row Goal): Require >= 2x reduction - ShowPlanParser: Gate XML MemoryGrantWarning at 1 GB - Scalar UDF: Expanded remediation options (variable assignment, 2019+ inlining) All changes applied identically to Dashboard and Lite. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports false positive fixes and warning improvements from PerformanceStudio issue #178 (community feedback).
Rule changes (applied identically to Dashboard and Lite):
Test plan
🤖 Generated with Claude Code