Sync PlanAnalyzer + BenefitScorer from PerformanceStudio (Apr 9-16)#856
Merged
Conversation
Port PS PRs #216, #217, #219, #224, #229, #230, #231 to PM. PlanAnalyzer changes: - Rule 5: Suppress for Key Lookups (point lookups mislead per-execution estimates) - Rule 8: Enhanced parallel skew with batch mode sort detection and practical context - Rule 9: Large memory grant shows top 3 consumers sorted by row count - Rule 10: Key lookup overhaul — show output columns, check predicate filtering, softer advice - Rules 11/12/29: Suppress on 0-execution nodes (operator never ran) - Rule 11: I/O wait severity elevation when scan hits disk - Rule 24: FormatNodeRef helper includes object name for data access operators - Rule 26: Suppress when row goal prediction was correct, specific cause detection - Wait stats: DescribeWaitType with full wait type coverage, multi-wait summary - New helpers: GetWaitLabel, HasSignificantIoWaits, IdentifyRowGoalCause, FormatNodeRef - GetOperatorOwnElapsedMs changed to internal for BenefitScorer access BenefitScorer (new file): - Stage 1: MaxBenefitPercent for operator-level rules (filter, spill, lookup, etc.) - Stage 2: Wait stats benefit scoring with parallel allocation (Joe's formula) PlanModels additions: - MaxBenefitPercent and ActionableFix on PlanWarning - WaitBenefit class and WaitBenefits list on PlanStatement Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
5 tasks
pull Bot
pushed a commit
to ehtick/PerformanceMonitor
that referenced
this pull request
Apr 29, 2026
…manceStudio Ports PerformanceStudio PRs erikdarlingdata#285 and erikdarlingdata#288 (net result; the temporary R/D/G overlay from erikdarlingdata#285 was replaced by real icons in erikdarlingdata#288). PlanIconMapper.GetIconName now takes optional storageType and logicalOp: - Columnstore scans (Clustered/Index Scan with Storage="ColumnStore" on the Object element) route to the columnstore_index_* icons. Covers both CCI and NCCI for scan/delete/insert/update/merge. - The three Parallelism subtypes (Repartition/Distribute/Gather Streams) route to their own icons instead of all sharing parallelism.png. ShowPlanParser: the IconName assignment moves from immediately after PhysicalOp parsing to after StorageType and LogicalOp are populated, so the new routing has the inputs it needs. Three new icons (MIT-licensed contribution from @rferraton via PS erikdarlingdata#288) added to both Dashboard and Lite Resources/PlanIcons. The existing Resource glob in each csproj picks them up automatically. Last upstream sync from PerformanceStudio was 2026-04-16 (erikdarlingdata#856), scoped to PlanAnalyzer + BenefitScorer. This is a follow-up scoped to plan-viewer icon routing. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Syncs all PlanAnalyzer and BenefitScorer changes from PerformanceStudio since the last sync (PR #818, Apr 9). Covers PerformanceStudio PRs #216, #217, #219, #224, #229, #230, #231.
PlanAnalyzer changes (Dashboard + Lite)
FormatNodeReffor richer node references with object namesGetWaitLabel,HasSignificantIoWaits,FormatNodeRef,IdentifyRowGoalCauseGetOperatorOwnElapsedMschanged tointernalfor BenefitScorer accessBenefitScorer (NEW — Dashboard + Lite)
MaxBenefitPercent) for Rules 1-5, 7, 9-12, 16, 19, 25, 31, 32PlanModels additions (Dashboard + Lite)
MaxBenefitPercentandActionableFixonPlanWarningWaitBenefitclass +WaitBenefitslist onPlanStatementTest plan
🤖 Generated with Claude Code