fix: remove string reducer

Author: yyxi

src/example.ts

@@ -6,7 +6,6 @@ import { count } from './input/count/domain-language'
 import { group } from './input/group/domain-language'
 import { string } from './input/string/domain-language'
 
-// TODO: remove string reducer
 export const grant = string()
   .reference('GRANT')
   .description(

src/input/string/domain-language.spec.ts

@@ -1,6 +1,6 @@
 import { log, state, SYMBOL_LOG, SYMBOL_STATE } from '@escapace/fluent'
 import { assert, describe, it } from 'vitest'
-import { type LookupValues, SYMBOL_INPUT_STRING } from '../../types'
+import { SYMBOL_INPUT_STRING } from '../../types'
 import { string } from './domain-language'
 import { reducer } from './reducer'
 import { TypeAction } from './types'
@@ -92,7 +92,7 @@ describe('input/choice', () => {
 
     const test4 = test3.option('--option')
 
-    assert.hasAllKeys(test4, [SYMBOL_LOG, SYMBOL_STATE, 'default', 'reducer', 'option', 'variable'])
+    assert.hasAllKeys(test4, [SYMBOL_LOG, SYMBOL_STATE, 'default', 'option', 'variable'])
 
     assert.deepEqual(log(test4), [
       {
@@ -120,7 +120,7 @@ describe('input/choice', () => {
 
     const test5 = test4.variable('VARIABLE')
 
-    assert.hasAllKeys(test5, [SYMBOL_LOG, SYMBOL_STATE, 'default', 'reducer', 'option', 'variable'])
+    assert.hasAllKeys(test5, [SYMBOL_LOG, SYMBOL_STATE, 'default', 'option', 'variable'])
 
     assert.deepEqual(log(test5), [
       {
@@ -182,43 +182,5 @@ describe('input/choice', () => {
       type: SYMBOL_INPUT_STRING,
       variables: ['VARIABLE'],
     })
-
-    const function_ = (_: LookupValues<typeof test5>) => 1 as const
-
-    const test7 = test5.reducer(function_)
-
-    assert.hasAllKeys(test7, [SYMBOL_LOG, SYMBOL_STATE])
-
-    assert.deepEqual(log(test7), [
-      {
-        payload: function_,
-        type: TypeAction.Reducer,
-      },
-      {
-        payload: 'VARIABLE',
-        type: TypeAction.Variable,
-      },
-      {
-        payload: {
-          name: '--option',
-        },
-        type: TypeAction.Option,
-      },
-      { payload: undefined, type: TypeAction.Repeat },
-      { payload: 'ABC', type: TypeAction.Description },
-      { payload: reference, type: TypeAction.Reference },
-    ])
-
-    assert.deepEqual(state(test7), {
-      default: undefined,
-      description: 'ABC',
-      isEmpty: false,
-      options: ['--option'],
-      reducer: state(test7).reducer,
-      reference,
-      repeat: true,
-      type: SYMBOL_INPUT_STRING,
-      variables: ['VARIABLE'],
-    })
   })
 })

src/input/string/domain-language.ts

@@ -1,20 +1,16 @@
-/* eslint-disable typescript/no-unsafe-argument */
 import { builder, Options } from '@escapace/fluent'
 import { filter, find, map, reverse, some } from 'lodash-es'
 import { type Reference, SYMBOL_INPUT_STRING } from '../../types'
 import { assert } from '../../utilities/assert'
-import { normalizeString } from '../../utilities/normalize'
-import { reducer as reducerDefault } from './reducer'
+import { reducer } from './reducer'
 import {
   type ActionDefault,
   type ActionDescription,
   type ActionOption,
-  type ActionReducer,
   type ActionReference,
   type ActionRepeat,
   type Actions,
   type ActionVariable,
-  type GenericInputStringReducer,
   type Settings,
   type State,
   TypeAction,
@@ -33,15 +29,6 @@ const fluentReducer = (log: Actions): State => {
 
   const repeat = Boolean(find(log, ({ type }) => type === TypeAction.Repeat))
 
-  const reducerMaybe = (
-    find(log, (action) => action.type === TypeAction.Reducer) as ActionReducer | undefined
-  )?.payload
-
-  const reducer: GenericInputStringReducer =
-    reducerMaybe === undefined
-      ? reducerDefault
-      : (values, properties) => reducerMaybe(normalizeString(values, properties), properties)
-
   const isEmpty =
     log.length === 0 ||
     !some(log, (action) => action.type === TypeAction.Option || action.type === TypeAction.Variable)
@@ -122,7 +109,7 @@ export const string = builder<Settings>([
     [Options.Type]: TypeAction.Repeat,
   },
   {
-    [Options.Conflicts]: [TypeAction.Reducer, TypeAction.Default],
+    [Options.Conflicts]: [TypeAction.Default],
     [Options.Dependencies]: [TypeAction.Description],
     [Options.Interface]: (dispatch, _, { options }) => ({
       option(value: string) {
@@ -142,7 +129,7 @@ export const string = builder<Settings>([
     [Options.Type]: TypeAction.Option,
   },
   {
-    [Options.Conflicts]: [TypeAction.Reducer, TypeAction.Default],
+    [Options.Conflicts]: [TypeAction.Default],
     [Options.Dependencies]: [TypeAction.Description],
     [Options.Interface]: (dispatch, _, { variables }) => ({
       variable(value: string) {
@@ -160,7 +147,7 @@ export const string = builder<Settings>([
     [Options.Type]: TypeAction.Variable,
   },
   {
-    [Options.Conflicts]: [TypeAction.Reducer],
+    [Options.Conflicts]: [],
     [Options.Dependencies]: [TypeAction.Description],
     [Options.Enabled]: (_, state) => !state.isEmpty,
     [Options.Interface]: (dispatch, _, { repeat }) => ({
@@ -178,22 +165,4 @@ export const string = builder<Settings>([
     [Options.Reducer]: fluentReducer,
     [Options.Type]: TypeAction.Default,
   },
-  {
-    [Options.Conflicts]: [TypeAction.Default],
-    [Options.Enabled]: (_, state) => !state.isEmpty,
-    [Options.Interface]: (dispatch) => ({
-      reducer(value: GenericInputStringReducer) {
-        assert.function(value)
-
-        return dispatch<ActionReducer>({
-          payload: value,
-          type: TypeAction.Reducer,
-        })
-      },
-    }),
-    [Options.Keys]: ['reducer'],
-    [Options.Once]: true,
-    [Options.Reducer]: fluentReducer,
-    [Options.Type]: TypeAction.Reducer,
-  },
 ])

src/input/string/types.ts

@@ -27,7 +27,6 @@ export declare const INPUT_STRING_REDUCER: unique symbol
 export enum TypeAction {
   Default,
   Description,
-  Reducer,
   Option,
   Reference,
   Repeat,
@@ -54,11 +53,6 @@ export interface ActionDefault<T extends string | string[] = string | string[]>
   type: TypeAction.Default
 }
 
-export interface ActionReducer<T = unknown> {
-  payload: GenericInputStringReducer<T>
-  type: TypeAction.Reducer
-}
-
 export interface ActionVariable<T extends string = string> {
   payload: T
   type: TypeAction.Variable
@@ -72,13 +66,7 @@ export interface ActionOption<T extends string = string> {
 }
 
 export type Actions = Array<
-  | ActionDefault
-  | ActionDescription
-  | ActionOption
-  | ActionReducer
-  | ActionReference
-  | ActionRepeat
-  | ActionVariable
+  ActionDefault | ActionDescription | ActionOption | ActionReference | ActionRepeat | ActionVariable
 >
 
 export type LookupDefault<T extends Model<State, Actions>> = $.If<
@@ -93,7 +81,6 @@ export interface Interface<T extends Model<State, Actions>> extends FluentInterf
   option: <P extends string>(
     option: Exclude<P, $.Values<T['state']['options']>>,
   ) => Next<Settings, T, ActionOption<P>>
-  reducer: <U>(reducer: InputStringReducer<U, T>) => Next<Settings, T, ActionReducer<U>>
   reference: <U extends Reference>(reference: U) => Next<Settings, T, ActionReference<U>>
   repeat: () => Next<Settings, T, ActionRepeat>
   variable: <P extends string>(
@@ -152,7 +139,7 @@ export interface Specification<T extends Model<State>> {
   }
 
   [TypeAction.Option]: {
-    [Options.Conflicts]: typeof TypeAction.Default | typeof TypeAction.Reducer
+    [Options.Conflicts]: typeof TypeAction.Default
     [Options.Dependencies]: typeof TypeAction.Description
     [Options.Enabled]: $.True
     [Options.Keys]: 'option'
@@ -161,7 +148,7 @@ export interface Specification<T extends Model<State>> {
   }
 
   [TypeAction.Variable]: {
-    [Options.Conflicts]: typeof TypeAction.Default | typeof TypeAction.Reducer
+    [Options.Conflicts]: typeof TypeAction.Default
     [Options.Dependencies]: typeof TypeAction.Description
     [Options.Enabled]: $.True
     [Options.Keys]: 'variable'
@@ -170,22 +157,13 @@ export interface Specification<T extends Model<State>> {
   }
 
   [TypeAction.Default]: {
-    [Options.Conflicts]: typeof TypeAction.Reducer
+    [Options.Conflicts]: never
     [Options.Dependencies]: typeof TypeAction.Description
     [Options.Enabled]: $.Equal<T['state']['isEmpty'], false>
     [Options.Keys]: 'default'
     [Options.Once]: $.True
     [Options.Type]: typeof TypeAction.Default
   }
-
-  [TypeAction.Reducer]: {
-    [Options.Conflicts]: typeof TypeAction.Default
-    [Options.Dependencies]: never
-    [Options.Enabled]: $.Equal<T['state']['isEmpty'], false>
-    [Options.Keys]: 'reducer'
-    [Options.Once]: $.True
-    [Options.Type]: typeof TypeAction.Reducer
-  }
 }
 
 declare module '@escapace/typelevel/hkt' {
@@ -197,17 +175,13 @@ declare module '@escapace/typelevel/hkt' {
 }
 
 export type ReducerReducer<T extends Action[]> = $.If<
-  $.Is.Never<Payload<$.Values<T>, TypeAction.Reducer>>,
+  $.Is.Never<Payload<$.Values<T>, TypeAction.Repeat>>,
   $.If<
-    $.Is.Never<Payload<$.Values<T>, TypeAction.Repeat>>,
-    $.If<
-      $.Is.Never<Payload<$.Values<T>, TypeAction.Default>>,
-      GenericInputStringReducer<string | undefined>,
-      GenericInputStringReducer<string>
-    >,
-    GenericInputStringReducer<string[]>
+    $.Is.Never<Payload<$.Values<T>, TypeAction.Default>>,
+    GenericInputStringReducer<string | undefined>,
+    GenericInputStringReducer<string>
   >,
-  GenericInputStringReducer<ReturnType<Payload<$.Values<T>, TypeAction.Reducer>>>
+  GenericInputStringReducer<string[]>
 >
 
 export interface Reducer<T extends Action[]> {
@@ -222,9 +196,6 @@ export interface Reducer<T extends Action[]> {
     isEmpty: false
     options: Array<Payload<$.Values<T>, TypeAction.Option> extends { name: infer U } ? U : never>
   }
-  [TypeAction.Reducer]: {
-    reducer: GenericInputStringReducer<ReturnType<Payload<$.Values<T>, TypeAction.Reducer>>>
-  }
   [TypeAction.Reference]: {
     reference: Payload<$.Values<T>, TypeAction.Reference>
   }