From 015352b30c73931aded3b8609c9aff2c8ece09ec Mon Sep 17 00:00:00 2001 From: Robert Keyser Date: Fri, 8 Jul 2022 09:30:11 -0500 Subject: [PATCH 1/5] remove default analytics_id in code example. --- docs/fides/docs/installation/configuration.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/fides/docs/installation/configuration.md b/docs/fides/docs/installation/configuration.md index f5633d8cb10..f1e79632e97 100644 --- a/docs/fides/docs/installation/configuration.md +++ b/docs/fides/docs/installation/configuration.md @@ -29,7 +29,7 @@ local_mode = False server_host = "localhost" server_port = 8080 server_protocol = "http -analytics_id = "test_analytics_id" +analytics_id = "" [user] encryption_key = "test_encryption_key" From 9e4b33b36da3e5080dbcdc01a0fdbc2b922de5c9 Mon Sep 17 00:00:00 2001 From: Robert Keyser Date: Fri, 8 Jul 2022 09:30:42 -0500 Subject: [PATCH 2/5] fix syntax, missing quote --- docs/fides/docs/installation/configuration.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/fides/docs/installation/configuration.md b/docs/fides/docs/installation/configuration.md index f1e79632e97..b10a6784ee1 100644 --- a/docs/fides/docs/installation/configuration.md +++ b/docs/fides/docs/installation/configuration.md @@ -28,7 +28,7 @@ log_serialization = "" local_mode = False server_host = "localhost" server_port = 8080 -server_protocol = "http +server_protocol = "http" analytics_id = "" [user] From 200c5111379d7bddbbe63d79ee2ecdaba4c591ca Mon Sep 17 00:00:00 2001 From: Robert Keyser Date: Fri, 8 Jul 2022 09:34:44 -0500 Subject: [PATCH 3/5] changed description for analytics_id, to address #882 --- docs/fides/docs/installation/configuration.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/fides/docs/installation/configuration.md b/docs/fides/docs/installation/configuration.md index b10a6784ee1..1b9509fb442 100644 --- a/docs/fides/docs/installation/configuration.md +++ b/docs/fides/docs/installation/configuration.md @@ -60,7 +60,7 @@ To better describe the various configuration options, the following tables descr | server_host | String | localhost | The hostname of the fidesctl webserver. | | server_protocol | String | http | The protocol used by the fidesctl webserver. | | server_port | Integer | | The optional port of the fidesctl webserver. | - | analytics_id | String | "" | A fully anonymized unique identifier for the `fidesctl` CLI instance. | + | analytics_id | String | "" | An fully anonymized unique identifier that is automatically generated by the application and stored in the toml file. | === "User Section" From 1eff170b525d9bc9b8358a98eb35fc9716ccc1b2 Mon Sep 17 00:00:00 2001 From: Robert Keyser Date: Fri, 8 Jul 2022 09:39:16 -0500 Subject: [PATCH 4/5] removed tautology in default removed tautology so there wasn't a tautology in the docs --- docs/fides/docs/installation/configuration.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/fides/docs/installation/configuration.md b/docs/fides/docs/installation/configuration.md index 1b9509fb442..a48a97edb6f 100644 --- a/docs/fides/docs/installation/configuration.md +++ b/docs/fides/docs/installation/configuration.md @@ -2,7 +2,7 @@ Fidesctl supports two methods of configuration. The first is via a toml file, and the second is via environment variables. They can also be used in tandem, with the environment variables overriding the toml configuration values. -By default the fidesctl CLI doesn't require a config file and will instead leverage the default values. These are very likely to be wrong however so it is recommended to always configure your settings properly. +The fidesctl CLI doesn't require a config file and will instead leverage the default values. These are very likely to be wrong however, so it is recommended to always configure your settings properly. ## Configuration file From 4e8e6ca79df545ca047a0815fa8b67aaa360ccd0 Mon Sep 17 00:00:00 2001 From: Robert Keyser Date: Fri, 8 Jul 2022 14:31:04 -0500 Subject: [PATCH 5/5] a -> an --- docs/fides/docs/installation/configuration.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/fides/docs/installation/configuration.md b/docs/fides/docs/installation/configuration.md index a48a97edb6f..c80e8fd4789 100644 --- a/docs/fides/docs/installation/configuration.md +++ b/docs/fides/docs/installation/configuration.md @@ -60,7 +60,7 @@ To better describe the various configuration options, the following tables descr | server_host | String | localhost | The hostname of the fidesctl webserver. | | server_protocol | String | http | The protocol used by the fidesctl webserver. | | server_port | Integer | | The optional port of the fidesctl webserver. | - | analytics_id | String | "" | An fully anonymized unique identifier that is automatically generated by the application and stored in the toml file. | + | analytics_id | String | "" | A fully anonymized unique identifier that is automatically generated by the application and stored in the toml file. | === "User Section"