From d32cb9444be18c75b8956b5cac41bcbcbb0fbb5b Mon Sep 17 00:00:00 2001 From: Glenn Jackman Date: Thu, 3 Oct 2019 12:31:38 -0400 Subject: [PATCH] reverse-string: add test that exposes unquoted variable problems --- exercises/reverse-string/.meta/version | 2 +- exercises/reverse-string/example.sh | 2 +- exercises/reverse-string/reverse_string_test.sh | 7 +++++++ 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/exercises/reverse-string/.meta/version b/exercises/reverse-string/.meta/version index 26aaba0e..6085e946 100644 --- a/exercises/reverse-string/.meta/version +++ b/exercises/reverse-string/.meta/version @@ -1 +1 @@ -1.2.0 +1.2.1 diff --git a/exercises/reverse-string/example.sh b/exercises/reverse-string/example.sh index c7a664cb..9abe418c 100755 --- a/exercises/reverse-string/example.sh +++ b/exercises/reverse-string/example.sh @@ -1,3 +1,3 @@ #!/usr/bin/env bash -echo $1 | rev +echo "$1" | rev diff --git a/exercises/reverse-string/reverse_string_test.sh b/exercises/reverse-string/reverse_string_test.sh index 5d636ec5..abdf68d6 100755 --- a/exercises/reverse-string/reverse_string_test.sh +++ b/exercises/reverse-string/reverse_string_test.sh @@ -48,3 +48,10 @@ [[ $output = "reward" ]] } +@test "avoid globbing" { + [[ $BATS_RUN_SKIPPED == true ]] || skip + run bash reverse_string.sh " a * b" + + [[ $status -eq 0 ]] + [[ $output = "b * a " ]] +}