From a4d1d2a24a47b2917c8c3dc983764599e6ef2d27 Mon Sep 17 00:00:00 2001 From: Rob Keim Date: Fri, 22 Feb 2019 23:13:18 +0700 Subject: [PATCH 1/2] [Triangle] Remove unused exception --- exercises/triangle/Example.cs | 5 +---- exercises/triangle/Triangle.cs | 5 +---- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/exercises/triangle/Example.cs b/exercises/triangle/Example.cs index d9f64646cd..65e13ebba7 100644 --- a/exercises/triangle/Example.cs +++ b/exercises/triangle/Example.cs @@ -11,7 +11,6 @@ public enum TriangleKind public static class Triangle { - public static bool IsScalene(double side1, double side2, double side3) { return Kind(side1, side2, side3) == TriangleKind.Scalene; @@ -65,6 +64,4 @@ private static int UniqueSides(double side1, double side2, double side3) double[] sides = { side1, side2, side3 }; return sides.Distinct().Count(); } -} - -public class TriangleException : Exception { } \ No newline at end of file +} \ No newline at end of file diff --git a/exercises/triangle/Triangle.cs b/exercises/triangle/Triangle.cs index c50a436b93..f40ca9bed9 100644 --- a/exercises/triangle/Triangle.cs +++ b/exercises/triangle/Triangle.cs @@ -16,7 +16,4 @@ public static bool IsEquilateral(double side1, double side2, double side3) { throw new NotImplementedException("You need to implement this function."); } - -} - -public class TriangleException : Exception { } \ No newline at end of file +} \ No newline at end of file From 8c79d4d12920504293bd7b3922f8bb42ab1b960f Mon Sep 17 00:00:00 2001 From: Rob Keim Date: Fri, 22 Feb 2019 23:13:54 +0700 Subject: [PATCH 2/2] [Bowling] Make local test helper method private --- exercises/bowling/BowlingTest.cs | 2 +- generators/Exercises/Generators/Bowling.cs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/exercises/bowling/BowlingTest.cs b/exercises/bowling/BowlingTest.cs index 1d251b714a..229b258aa4 100644 --- a/exercises/bowling/BowlingTest.cs +++ b/exercises/bowling/BowlingTest.cs @@ -291,7 +291,7 @@ public void Cannot_roll_after_bonus_rolls_for_strike() Assert.Throws(() => sut.Roll(2)); } - public void DoRoll(IEnumerable rolls, BowlingGame sut) + private void DoRoll(IEnumerable rolls, BowlingGame sut) { foreach (var roll in rolls) { diff --git a/generators/Exercises/Generators/Bowling.cs b/generators/Exercises/Generators/Bowling.cs index 0df2cdc931..3fd7a9559c 100644 --- a/generators/Exercises/Generators/Bowling.cs +++ b/generators/Exercises/Generators/Bowling.cs @@ -78,7 +78,7 @@ protected override void UpdateTestClass(TestClass testClass) private static void AddDoRollMethod(TestClass testClass) { testClass.AdditionalMethods.Add(@" -public void DoRoll(IEnumerable rolls, BowlingGame sut) +private void DoRoll(IEnumerable rolls, BowlingGame sut) { foreach (var roll in rolls) {