From 9259c827b6318c4f3f9b7f17429520fd40fef449 Mon Sep 17 00:00:00 2001 From: Geoff Hubbard Date: Fri, 5 May 2017 08:10:21 +0100 Subject: [PATCH 1/2] Remove test on malformed data. This is not a string parsing exercise and there is no reason why a number should be invalid due to inconsequential non-digit characters. "2a2b3c4d5e6f7g8h9i0j" should be as valid as: "My phone number is: 223 456 7890" --- exercises/phone-number/canonical-data.json | 6 ------ 1 file changed, 6 deletions(-) diff --git a/exercises/phone-number/canonical-data.json b/exercises/phone-number/canonical-data.json index 7d789e9d79..72334460e6 100644 --- a/exercises/phone-number/canonical-data.json +++ b/exercises/phone-number/canonical-data.json @@ -70,12 +70,6 @@ "phrase": "123-@:!-7890", "expected": null }, - { - "description": "invalid with right number of digits but letters mixed in", - "property": "clean", - "phrase": "1a2b3c4d5e6f7g8h9i0j", - "expected": null - }, { "description": "invalid if area code does not start with 2-9", "property": "clean", From 440eb2f78cd4a49eb34fb0f93208c3a039f39ef1 Mon Sep 17 00:00:00 2001 From: Geoff Hubbard Date: Fri, 5 May 2017 09:52:08 +0100 Subject: [PATCH 2/2] Update version. --- exercises/phone-number/canonical-data.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exercises/phone-number/canonical-data.json b/exercises/phone-number/canonical-data.json index 72334460e6..52a68b039c 100644 --- a/exercises/phone-number/canonical-data.json +++ b/exercises/phone-number/canonical-data.json @@ -1,6 +1,6 @@ { "exercise": "phone-number", - "version": "1.1.0", + "version": "1.2.0", "cases": [ { "description": "Cleanup user-entered phone numbers",