From 0139e356fc3b0ce25bce30c6a3a34c0ef9694291 Mon Sep 17 00:00:00 2001 From: Jonas Fogelberg Date: Sun, 22 Jul 2018 20:40:49 +0200 Subject: [PATCH 1/3] saddle-point: Add missing test There is a test for multiple saddle points in a column, but no test for multiple points in a row. --- exercises/saddle-points/saddle_points_test.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/exercises/saddle-points/saddle_points_test.py b/exercises/saddle-points/saddle_points_test.py index c614f21469f..e0a9bdb0898 100644 --- a/exercises/saddle-points/saddle_points_test.py +++ b/exercises/saddle-points/saddle_points_test.py @@ -29,6 +29,11 @@ def test_identify_multiple_saddle_points(self): expected = set([(0, 1), (1, 1), (2, 1)]) self.assertEqual(saddle_points(matrix), expected) + def test_identify_multiple_saddle_points_in_row(self): + matrix = [[6, 7, 8], [5, 5, 5], [6, 5, 6]] + expected = set([(1, 0), (1, 1), (1, 2)]) + self.assertEqual(saddle_points(matrix), expected) + def test_identify_saddle_point_in_bottom_right_corner(self): matrix = [[8, 7, 9], [6, 7, 6], [3, 2, 5]] expected = set([(2, 2)]) From 5709a644463a3e6f14f0f626f719ed2ea88df193 Mon Sep 17 00:00:00 2001 From: Jonas Fogelberg Date: Sun, 22 Jul 2018 20:43:45 +0200 Subject: [PATCH 2/3] saddle-point: Clarify test name Test for multiple saddle points in the same column renamed similar to that for multiple points in a row --- exercises/saddle-points/saddle_points_test.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exercises/saddle-points/saddle_points_test.py b/exercises/saddle-points/saddle_points_test.py index e0a9bdb0898..afa030a94c8 100644 --- a/exercises/saddle-points/saddle_points_test.py +++ b/exercises/saddle-points/saddle_points_test.py @@ -24,7 +24,7 @@ def test_identify_lack_of_saddle_points_when_there_are_none(self): matrix = [[1, 2, 3], [3, 1, 2], [2, 3, 1]] self.assertEqual(saddle_points(matrix), set()) - def test_identify_multiple_saddle_points(self): + def test_identify_multiple_saddle_points_in_column(self): matrix = [[4, 5, 4], [3, 5, 5], [1, 5, 4]] expected = set([(0, 1), (1, 1), (2, 1)]) self.assertEqual(saddle_points(matrix), expected) From 6680f8eb1d7449895897a3ad173f919147daaedf Mon Sep 17 00:00:00 2001 From: Unknown Date: Fri, 27 Jul 2018 11:45:13 +0200 Subject: [PATCH 3/3] saddle-point: Update reference to canonical-data * update the version of referenced canonical-data.json * make test-data of new test same as that in referenced canonical-data.json --- exercises/saddle-points/saddle_points_test.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/exercises/saddle-points/saddle_points_test.py b/exercises/saddle-points/saddle_points_test.py index afa030a94c8..1f1cf846898 100644 --- a/exercises/saddle-points/saddle_points_test.py +++ b/exercises/saddle-points/saddle_points_test.py @@ -10,7 +10,7 @@ from saddle_points import saddle_points -# Tests adapted from `problem-specifications//canonical-data.json` @ v1.1.0 +# Tests adapted from `problem-specifications//canonical-data.json` @ v1.2.0 class SaddlePointsTest(unittest.TestCase): def test_identify_single_saddle_point(self): @@ -30,7 +30,7 @@ def test_identify_multiple_saddle_points_in_column(self): self.assertEqual(saddle_points(matrix), expected) def test_identify_multiple_saddle_points_in_row(self): - matrix = [[6, 7, 8], [5, 5, 5], [6, 5, 6]] + matrix = [[6, 7, 8], [5, 5, 5], [7, 5, 6]] expected = set([(1, 0), (1, 1), (1, 2)]) self.assertEqual(saddle_points(matrix), expected)