From e1c7b895e00a1a0a671f89942da25b639b77377b Mon Sep 17 00:00:00 2001 From: Peter Tseng Date: Wed, 18 Nov 2020 12:57:31 +0000 Subject: [PATCH] matching-brackets: rm needless collect clippy::needless_collect Instead, check whether element exists in collection during iteration. Helps address https://github.com/exercism/rust/pull/1012 --- exercises/matching-brackets/example.rs | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/exercises/matching-brackets/example.rs b/exercises/matching-brackets/example.rs index 44310d294..8d3e46858 100644 --- a/exercises/matching-brackets/example.rs +++ b/exercises/matching-brackets/example.rs @@ -57,12 +57,9 @@ impl From> for MatchingBrackets { impl MatchingBrackets { fn contains(&self, other: &char) -> bool { - let known = self - .collection - .keys() - .chain(self.collection.values()) - .collect::>(); - known.contains(&other) + self.collection + .iter() + .any(|(k, v)| k == other || v == other) } fn closer_for(&self, k: &char) -> Option<&char> {