From f621d5644bdf1e529f9acdfef0b6c0ede6a41074 Mon Sep 17 00:00:00 2001 From: Geoff Hubbard Date: Fri, 19 May 2017 20:19:55 +0100 Subject: [PATCH 1/2] Delete obsolete description.md and metadata.yml files These files were copied into their respective `.meta` directories in https://github.com/exercism/xrust/pull/285 The trackler changes to look for the metadata files in the `.meta` directory have been made now, so these versions in the old location are no longer needed. --- exercises/luhn-from/description.md | 9 --------- exercises/luhn-from/metadata.yml | 3 --- exercises/luhn-trait/description.md | 17 ----------------- exercises/luhn-trait/metadata.yml | 3 --- 4 files changed, 32 deletions(-) delete mode 100644 exercises/luhn-from/description.md delete mode 100644 exercises/luhn-from/metadata.yml delete mode 100644 exercises/luhn-trait/description.md delete mode 100644 exercises/luhn-trait/metadata.yml diff --git a/exercises/luhn-from/description.md b/exercises/luhn-from/description.md deleted file mode 100644 index 1bf1850e5..000000000 --- a/exercises/luhn-from/description.md +++ /dev/null @@ -1,9 +0,0 @@ -# Luhn: Using the From Trait - -Before doing this exercise you should probably do the original Luhn exercise. If you have not completed Luhn, you can get it by running the command: - -> `exercism fetch rust luhn` - -In the original Luhn exercise you only validated strings, but the Luhn algorithm can be applied to integers as well. - -In this exercise you'll implement the [From trait](https://doc.rust-lang.org/std/convert/trait.From.html) to convert strings, strs and unsigned integers into a Struct that performs the validation. diff --git a/exercises/luhn-from/metadata.yml b/exercises/luhn-from/metadata.yml deleted file mode 100644 index bc1e12911..000000000 --- a/exercises/luhn-from/metadata.yml +++ /dev/null @@ -1,3 +0,0 @@ ---- -blurb: "Luhn: Using the From Trait" -source: "The Rust track maintainers, based on the original Luhn exercise" diff --git a/exercises/luhn-trait/description.md b/exercises/luhn-trait/description.md deleted file mode 100644 index fd9ce2b3c..000000000 --- a/exercises/luhn-trait/description.md +++ /dev/null @@ -1,17 +0,0 @@ -# Luhn: Using a Custom Trait - -Before doing this exercise you should probably do the original Luhn exercise and its successor, "Luhn: Using the From Trait" - -To get the original Luhn exercise, run `exercism fetch rust luhn` - -To get the "Luhn: Using the From Trait" exercise, run `exercism fetch rust luhn-from` - -In the original Luhn exercise you only validated strings, but the Luhn algorithm can be applied to integers as well. - -In "Luhn: Using the From Trait" you implemented a From trait, which also required you to create a Luhn struct. - -Instead of creating a Struct just to perform the validation, what if you you validated the primitives (i.e, String, u8, etc.) themselves? - -In this exercise you'll create and implement a custom [trait](https://doc.rust-lang.org/book/traits.html) that performs the validation. - -Note: It is [not idiomatic Rust to implement traits on on primitives](https://doc.rust-lang.org/book/traits.html#rules-for-implementing-traits). In this exercise we're showing something that you _can_ do, not something you _should_ do. If you find yourself implementing traits on primitives, perhaps you have a case of [Primitive Obsession](http://wiki.c2.com/?PrimitiveObsession). diff --git a/exercises/luhn-trait/metadata.yml b/exercises/luhn-trait/metadata.yml deleted file mode 100644 index dfa0c3b26..000000000 --- a/exercises/luhn-trait/metadata.yml +++ /dev/null @@ -1,3 +0,0 @@ ---- -blurb: "Luhn: Using a Custom Trait" -source: "The Rust track maintainters, based on the original Luhn exercise" From 01ee7ae3837ff6d4c3a13d828360a5049dfd9dea Mon Sep 17 00:00:00 2001 From: Peter Tseng Date: Fri, 19 May 2017 14:29:26 -0700 Subject: [PATCH 2/2] Revert "config: Ignore description.md and metadata.yml (#284)" This reverts commit 230b91a2581e1e0f2affc2481abe6f7171641683. Since the previous commit removes the duplicate files, there is no more need to ignore them! The new copies (#285) are in the .meta directory, which is always ignored. --- config.json | 1 - 1 file changed, 1 deletion(-) diff --git a/config.json b/config.json index 81652eeb5..edf247b11 100644 --- a/config.json +++ b/config.json @@ -1,7 +1,6 @@ { "slug": "rust", "language": "Rust", - "ignore_pattern": "example|description.md|metadata.yml", "repository": "https://github.com/exercism/xrust", "active": true, "exercises": [