Skip to content

Commit bde9cfd

Browse files
OzakIOneslorber
andauthored
chore: update node engine version 18 (#9348)
Co-authored-by: Sébastien Lorber <slorber@users.noreply.github.com> Co-authored-by: sebastienlorber <lorber.sebastien@gmail.com>
1 parent a178654 commit bde9cfd

File tree

46 files changed

+54
-64
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

46 files changed

+54
-64
lines changed

.github/workflows/argos.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ jobs:
3636
- name: Use Node.js
3737
uses: actions/setup-node@v3
3838
with:
39-
node-version: 16
39+
node-version: 18
4040

4141
- name: Install dependencies
4242
run: yarn install --frozen-lockfile

.github/workflows/build-blog-only.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
- name: Set up Node
2727
uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3
2828
with:
29-
node-version: '16'
29+
node-version: '18'
3030
cache: yarn
3131
- name: Installation
3232
run: yarn

.github/workflows/build-perf.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ jobs:
4040
- name: Set up Node
4141
uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3
4242
with:
43-
node-version: '16'
43+
node-version: '18'
4444
cache: yarn
4545
- name: Track build size changes
4646
uses: preactjs/compressed-size-action@8119d3d31b6e57b167e09c81dfa877eada3bcb35 # v2

.github/workflows/canary-release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ jobs:
2323
- name: Set up Node
2424
uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3
2525
with:
26-
node-version: '16'
26+
node-version: '18'
2727
cache: yarn
2828
- name: Prepare git
2929
run: |

.github/workflows/lint.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ jobs:
2424
- name: Set up Node
2525
uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3
2626
with:
27-
node-version: '16'
27+
node-version: '18'
2828
cache: yarn
2929
- name: Installation
3030
run: yarn

.github/workflows/tests-e2e.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ jobs:
3838
runs-on: ubuntu-latest
3939
strategy:
4040
matrix:
41-
node: ['16.14', '16', '18']
41+
node: ['18.0', '18', '20']
4242
steps:
4343
- name: Checkout
4444
uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # v4.1.0
@@ -76,10 +76,10 @@ jobs:
7676
steps:
7777
- name: Checkout
7878
uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # v4.1.0
79-
- name: Use Node.js 16
79+
- name: Use Node.js 18
8080
uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3
8181
with:
82-
node-version: '16'
82+
node-version: '18'
8383
cache: yarn
8484
- name: Installation
8585
run: yarn
@@ -130,10 +130,10 @@ jobs:
130130
steps:
131131
- name: Checkout
132132
uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # v4.1.0
133-
- name: Use Node.js 16
133+
- name: Use Node.js 18
134134
uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3
135135
with:
136-
node-version: '16'
136+
node-version: '18'
137137
cache: yarn
138138
- name: Installation
139139
run: yarn
@@ -160,10 +160,10 @@ jobs:
160160
steps:
161161
- name: Checkout
162162
uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # v4.1.0
163-
- name: Use Node.js 16
163+
- name: Use Node.js 18
164164
uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3
165165
with:
166-
node-version: '16'
166+
node-version: '18'
167167
cache: yarn
168168
- name: Installation
169169
run: yarn

.github/workflows/tests-swizzle.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ jobs:
3030
- name: Set up Node
3131
uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3
3232
with:
33-
node-version: '16'
33+
node-version: '18'
3434
cache: yarn
3535
- name: Installation
3636
run: yarn

.github/workflows/tests-windows.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
runs-on: windows-latest
2727
strategy:
2828
matrix:
29-
node: ['16.14', '16', '18']
29+
node: ['18.0', '18', '20']
3030
steps:
3131
- name: Support longpaths
3232
run: git config --system core.longpaths true

.github/workflows/tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
runs-on: ubuntu-latest
2727
strategy:
2828
matrix:
29-
node: ['16.14', '16', '18']
29+
node: ['18.0', '18', '20']
3030
steps:
3131
- name: Checkout
3232
uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # v4.1.0

admin/scripts/generateExamples.js

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,6 @@
1010
import fs from 'fs-extra';
1111
import shell from 'shelljs';
1212

13-
const NODE_MAJOR_VERSION = parseInt(
14-
/** @type {string} */ (process.versions.node.split('.')[0]),
15-
10,
16-
);
17-
if (NODE_MAJOR_VERSION < 16) {
18-
throw new Error(
19-
'This generateExamples Docusaurus script requires at least Node.js 16 and npm 7. See why here: https://github.com/facebook/docusaurus/pull/5722#issuecomment-948847891',
20-
);
21-
}
22-
2313
/**
2414
* Generate one example per init template
2515
* We use those generated examples as CodeSandbox projects
@@ -78,9 +68,9 @@ async function generateTemplateExample(template) {
7868
hardReloadOnChange: true,
7969
view: 'browser',
8070
template: 'docusaurus',
81-
node: '16',
71+
node: '18',
8272
container: {
83-
node: '16',
73+
node: '18',
8474
},
8575
};
8676
await fs.writeFile(

0 commit comments

Comments
 (0)