perf(v2): add link rel preconnect for GA & google tag plugin#2062
Merged
endiliey merged 1 commit intoendi/assettagsfrom Nov 30, 2019
Merged
perf(v2): add link rel preconnect for GA & google tag plugin#2062endiliey merged 1 commit intoendi/assettagsfrom
endiliey merged 1 commit intoendi/assettagsfrom
Conversation
Contributor
Author
|
Seems that we need to modify the gtag plugin too ? Such that it doesnt wait till js load for it to append the script I’m talking about this |
Contributor
Author
|
OOps i merged it to wrong branch |
Contributor
|
Just push to master lol
…On Fri, Nov 29, 2019 at 10:27 PM Endi ***@***.***> wrote:
OOps i merged it to wrong branch
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2062?email_source=notifications&email_token=AAKBCHJAYY6FJPFWEKFF75TQWIBWHA5CNFSM4JSJZS5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFP2PTI#issuecomment-559917005>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKBCHIZTWP5L2NW55USXU3QWIBWHANCNFSM4JSJZS5A>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR requires #2057 to be looked first It's a PR for a PR. Just so that lerna changelog can pick it up
https://css-tricks.com/using-relpreconnect-to-establish-network-connections-early-and-increase-performance/
As suggested by lighthouse, can save few seconds

Have you read the Contributing Guidelines on pull requests?
yes
Test Plan