From 0a1f89437b1b94abcd27287500ce4c7f5d2df1e9 Mon Sep 17 00:00:00 2001 From: Janic Duplessis Date: Mon, 13 Mar 2017 19:14:05 -0400 Subject: [PATCH 1/2] Animated - Add missing super calls to fix native animated crash --- Libraries/Animated/src/AnimatedImplementation.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Libraries/Animated/src/AnimatedImplementation.js b/Libraries/Animated/src/AnimatedImplementation.js index 09c3c2129452a6..ba9126aceb1f38 100644 --- a/Libraries/Animated/src/AnimatedImplementation.js +++ b/Libraries/Animated/src/AnimatedImplementation.js @@ -1328,6 +1328,7 @@ class AnimatedModulo extends AnimatedWithChildren { __detach(): void { this._a.__removeChild(this); + super.__detach(); } __getNativeConfig(): any { @@ -1378,6 +1379,7 @@ class AnimatedDiffClamp extends AnimatedWithChildren { __detach(): void { this._a.__removeChild(this); + super.__detach(); } __getNativeConfig(): any { @@ -1461,6 +1463,7 @@ class AnimatedTransform extends AnimatedWithChildren { } } }); + super.__detach(); } __getNativeConfig(): any { @@ -1568,6 +1571,7 @@ class AnimatedStyle extends AnimatedWithChildren { value.__removeChild(this); } } + super.__detach(); } __makeNative() { From 6786674184dd69744f8581f51dfa91cce4f859ce Mon Sep 17 00:00:00 2001 From: Janic Duplessis Date: Tue, 28 Mar 2017 13:15:40 -0400 Subject: [PATCH 2/2] Fix test --- Libraries/Animated/src/__tests__/AnimatedNative-test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Libraries/Animated/src/__tests__/AnimatedNative-test.js b/Libraries/Animated/src/__tests__/AnimatedNative-test.js index c39079c656087e..4c3d1b467b0d0a 100644 --- a/Libraries/Animated/src/__tests__/AnimatedNative-test.js +++ b/Libraries/Animated/src/__tests__/AnimatedNative-test.js @@ -281,7 +281,7 @@ describe('Native Animated', () => { ); expect(nativeAnimatedModule.disconnectAnimatedNodes).toHaveBeenCalledTimes(2); - expect(nativeAnimatedModule.dropAnimatedNode).toHaveBeenCalledTimes(2); + expect(nativeAnimatedModule.dropAnimatedNode).toHaveBeenCalledTimes(3); }); it('sends a valid description for value, style and props nodes', () => {