From 386ad54c71bb18d63d2943d53e17848bf3d68c5d Mon Sep 17 00:00:00 2001 From: Joe Rickerby Date: Mon, 22 May 2017 15:18:09 +0100 Subject: [PATCH 1/2] Update overflow docstring to add note on Android The overflow: hidden option does not work on Android. https://react-native.canny.io/feature-requests/p/add-overflow-support-to-android --- Libraries/StyleSheet/LayoutPropTypes.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Libraries/StyleSheet/LayoutPropTypes.js b/Libraries/StyleSheet/LayoutPropTypes.js index 56e42a5af5c912..3a99cf7eadea4a 100644 --- a/Libraries/StyleSheet/LayoutPropTypes.js +++ b/Libraries/StyleSheet/LayoutPropTypes.js @@ -429,6 +429,8 @@ var LayoutPropTypes = { * It works like `overflow` in CSS (default: visible). * See https://developer.mozilla.org/en/docs/Web/CSS/overflow * for more details. + * `overflow: hidden` only works on iOS. On Android, all views will clip their + * children. */ overflow: ReactPropTypes.oneOf([ 'visible', From 61e3ff2feab24f725b08187357c1b8ade5be3bea Mon Sep 17 00:00:00 2001 From: Joe Rickerby Date: Sun, 11 Jun 2017 14:35:33 +0100 Subject: [PATCH 2/2] Fix hidden/visible confusion --- Libraries/StyleSheet/LayoutPropTypes.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Libraries/StyleSheet/LayoutPropTypes.js b/Libraries/StyleSheet/LayoutPropTypes.js index 3a99cf7eadea4a..c7020315396efd 100644 --- a/Libraries/StyleSheet/LayoutPropTypes.js +++ b/Libraries/StyleSheet/LayoutPropTypes.js @@ -429,8 +429,8 @@ var LayoutPropTypes = { * It works like `overflow` in CSS (default: visible). * See https://developer.mozilla.org/en/docs/Web/CSS/overflow * for more details. - * `overflow: hidden` only works on iOS. On Android, all views will clip their - * children. + * `overflow: visible` only works on iOS. On Android, all views will clip + * their children. */ overflow: ReactPropTypes.oneOf([ 'visible',