From 9f01180853e67b6a01da7015b514b5a40ad64f57 Mon Sep 17 00:00:00 2001 From: Marc Zehngut Date: Thu, 17 Oct 2019 13:26:35 -0400 Subject: [PATCH] Fix ActionSheet completion callback not called when dialog is dismissed --- React/CoreModules/RCTActionSheetManager.mm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/React/CoreModules/RCTActionSheetManager.mm b/React/CoreModules/RCTActionSheetManager.mm index c73aae982e57..1ca9416c52de 100644 --- a/React/CoreModules/RCTActionSheetManager.mm +++ b/React/CoreModules/RCTActionSheetManager.mm @@ -183,7 +183,7 @@ - (void)presentViewController:(UIViewController *)alertController shareController.completionWithItemsHandler = ^(NSString *activityType, BOOL completed, __unused NSArray *returnedItems, NSError *activityError) { if (activityError) { failureCallback(@[RCTJSErrorFromNSError(activityError)]); - } else if (completed) { + } else if (completed || !activityType) { successCallback(@[@(completed), RCTNullIfNil(activityType)]); } };