From 8eefa147eda76d84be199ff5ff5668f020fa07dc Mon Sep 17 00:00:00 2001 From: Nicola Corti Date: Thu, 20 Jan 2022 03:13:34 -0800 Subject: [PATCH] Do not remove libjscexecutor.so from release builds Summary: As the title says, we dont' want to remove `libjscexecutor.so` when baking release builds and having JSC enable as this leads to instacrashes. Fixes #32928 Fixes #32927 Changelog: [Android] [Fixed] - Do not remove libjscexecutor.so from release builds Differential Revision: D33681932 fbshipit-source-id: 4a71fd6cfaae35a1f24f048648e32d78d573a457 --- .../src/main/kotlin/com/facebook/react/TaskConfiguration.kt | 4 ---- react.gradle | 4 ---- 2 files changed, 8 deletions(-) diff --git a/packages/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/TaskConfiguration.kt b/packages/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/TaskConfiguration.kt index 8c0c41970f6e9f..30625c53d37d7c 100644 --- a/packages/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/TaskConfiguration.kt +++ b/packages/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/TaskConfiguration.kt @@ -240,10 +240,6 @@ private fun Project.cleanupVMFiles( } else { // For JSC, delete all the libhermes* files it.include("**/libhermes*.so") - // Delete the libjscexecutor from release build - if (cleanup) { - it.include("**/libjscexecutor.so") - } } } .visit { visit -> diff --git a/react.gradle b/react.gradle index 7e9333aaace766..0ace9be826f805 100644 --- a/react.gradle +++ b/react.gradle @@ -372,10 +372,6 @@ afterEvaluate { } else { // For JSC, delete all the libhermes* files include "**/libhermes*.so" - // Delete the libjscexecutor from release build - if (cleanup) { - include "**/libjscexecutor.so" - } } }.visit { details -> def targetVariant1 = ".*/transforms/[^/]*/${variant.name}/.*"