From 31e586bd1dc5346ecc22bcdbb9c10a16ea29639f Mon Sep 17 00:00:00 2001 From: Tomek Zawadzki Date: Wed, 10 Jul 2024 08:51:07 +0200 Subject: [PATCH] Update comments for virtual destructors of `ShadowNodeWrapper` and `ShadowNodeListWrapper` --- .../ReactCommon/react/renderer/core/ShadowNode.cpp | 8 ++++---- .../ReactCommon/react/renderer/uimanager/UIManager.cpp | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/packages/react-native/ReactCommon/react/renderer/core/ShadowNode.cpp b/packages/react-native/ReactCommon/react/renderer/core/ShadowNode.cpp index 68da528464b6..b84d539ed1c3 100644 --- a/packages/react-native/ReactCommon/react/renderer/core/ShadowNode.cpp +++ b/packages/react-native/ReactCommon/react/renderer/core/ShadowNode.cpp @@ -410,10 +410,10 @@ SharedDebugStringConvertibleList ShadowNode::getDebugProps() const { } #endif -// Explicitly define destructors here, as they need to exist in order to act as -// a "key function" for the ShadowNodeWrapper class -- this allows for RTTI to -// work properly across dynamic library boundaries (i.e. dynamic_cast that is -// used by getNativeState method) +// Explicitly define destructors here, as they have to exist in order to act as a +// "key function" for the ShadowNodeWrapper class -- this allows for RTTI to work +// properly across dynamic library boundaries (i.e. dynamic_cast that is used by +// getNativeState method) ShadowNodeWrapper::~ShadowNodeWrapper() = default; } // namespace facebook::react diff --git a/packages/react-native/ReactCommon/react/renderer/uimanager/UIManager.cpp b/packages/react-native/ReactCommon/react/renderer/uimanager/UIManager.cpp index 949f367117dd..1453c3a3c5a9 100644 --- a/packages/react-native/ReactCommon/react/renderer/uimanager/UIManager.cpp +++ b/packages/react-native/ReactCommon/react/renderer/uimanager/UIManager.cpp @@ -36,10 +36,10 @@ std::unique_ptr constructLeakCheckerIfNeeded( namespace facebook::react { -// Explicitly define destructors here, as they to exist in order to act as a -// "key function" for the ShadowNodeWrapper class -- this allow for RTTI to work +// Explicitly define destructors here, as they have to exist in order to act as a +// "key function" for the ShadowNodeWrapper class -- this allows for RTTI to work // properly across dynamic library boundaries (i.e. dynamic_cast that is used by -// isHostObject method) +// getNativeState method) ShadowNodeListWrapper::~ShadowNodeListWrapper() = default; UIManager::UIManager(