From f60ae0fa9fc611a7eb7b229ff59e730d92b11c1c Mon Sep 17 00:00:00 2001
From: Parsa Nasirimehr
Date: Sat, 9 Nov 2024 00:27:12 +0100
Subject: [PATCH] fix: unify prefetchImageWithMetadata's signature in JS and
ObjC land
---
packages/react-native/Libraries/Image/Image.ios.js | 2 +-
packages/react-native/Libraries/Image/RCTImageLoader.mm | 2 +-
.../src/private/specs/modules/NativeImageLoaderIOS.js | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/packages/react-native/Libraries/Image/Image.ios.js b/packages/react-native/Libraries/Image/Image.ios.js
index b3b9e61e50b9..083bbf148012 100644
--- a/packages/react-native/Libraries/Image/Image.ios.js
+++ b/packages/react-native/Libraries/Image/Image.ios.js
@@ -72,7 +72,7 @@ function getSizeWithHeaders(
function prefetchWithMetadata(
url: string,
- queryRootName: string,
+ queryRootName: ?string,
rootTag?: ?RootTag,
): Promise {
if (NativeImageLoaderIOS.prefetchImageWithMetadata) {
diff --git a/packages/react-native/Libraries/Image/RCTImageLoader.mm b/packages/react-native/Libraries/Image/RCTImageLoader.mm
index 68a12d351227..014c22bfd4de 100644
--- a/packages/react-native/Libraries/Image/RCTImageLoader.mm
+++ b/packages/react-native/Libraries/Image/RCTImageLoader.mm
@@ -1227,7 +1227,7 @@ - (void)cancelRequest:(id)requestToken
RCT_EXPORT_METHOD(prefetchImageWithMetadata
: (NSString *)uri queryRootName
- : (NSString *)queryRootName rootTag
+ : (nullable NSString *)queryRootName rootTag
: (double)rootTag resolve
: (RCTPromiseResolveBlock)resolve reject
: (RCTPromiseRejectBlock)reject)
diff --git a/packages/react-native/src/private/specs/modules/NativeImageLoaderIOS.js b/packages/react-native/src/private/specs/modules/NativeImageLoaderIOS.js
index b3d73201313e..1c937799c760 100644
--- a/packages/react-native/src/private/specs/modules/NativeImageLoaderIOS.js
+++ b/packages/react-native/src/private/specs/modules/NativeImageLoaderIOS.js
@@ -28,7 +28,7 @@ export interface Spec extends TurboModule {
+prefetchImage: (uri: string) => Promise;
+prefetchImageWithMetadata?: (
uri: string,
- queryRootName: string,
+ queryRootName: ?string,
rootTag: RootTag,
) => Promise;
+queryCache: (uris: Array) => Promise