From e5b0697e0ce9cb5c31a86623568b2e3c7d3873fe Mon Sep 17 00:00:00 2001 From: Eric Rozell Date: Fri, 13 Dec 2024 08:33:07 -0800 Subject: [PATCH 1/2] Remove unnecessary semi-colon before method body Summary: For some clang build configurations the semi-colon triggers `-Wsemicolon-before-method-body`. This fixes that warning in iOS sources. ## Changelog [Internal] Differential Revision: D67203041 --- .../Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.mm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-native/Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.mm b/packages/react-native/Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.mm index db3e2f8b4e1adf..206fdd26f8512c 100644 --- a/packages/react-native/Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.mm +++ b/packages/react-native/Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.mm @@ -57,7 +57,7 @@ @implementation RCTNativeAnimatedNodesManager { } - (instancetype)initWithBridge:(nullable RCTBridge *)bridge - surfacePresenter:(id)surfacePresenter; + surfacePresenter:(id)surfacePresenter { if ((self = [super init])) { _bridge = bridge; From f42d0013b0e6fc35d451e4bc4d365ced2be9363f Mon Sep 17 00:00:00 2001 From: Eric Rozell Date: Fri, 13 Dec 2024 08:33:07 -0800 Subject: [PATCH 2/2] Add override to RCTHermesInstance destructor Summary: For some clang warnings configurations, you may hit `-Winconsistent-missing-destructor-override` without this override modifier. ## Changelog [Internal] Differential Revision: D67203040 --- .../react/runtime/platform/ios/ReactCommon/RCTHermesInstance.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-native/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTHermesInstance.h b/packages/react-native/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTHermesInstance.h index f686220e69010e..86b7a2d717c96a 100644 --- a/packages/react-native/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTHermesInstance.h +++ b/packages/react-native/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTHermesInstance.h @@ -30,7 +30,7 @@ class RCTHermesInstance : public JSRuntimeFactory { std::unique_ptr createJSRuntime( std::shared_ptr msgQueueThread) noexcept override; - ~RCTHermesInstance(){}; + ~RCTHermesInstance() override{}; private: CrashManagerProvider _crashManagerProvider;