Skip to content

Conversation

@nathannewyen
Copy link

Summary

This PR adds accessibility collection support to VirtualizedList, enabling Android TalkBack to announce "item X of Y" when navigating through list items.

Closes #30975

Changes

  • VirtualizedListProps.js: Added AccessibilityCollectionItem type and included it in ListRenderItemInfo
  • VirtualizedList.js:
    • Computes accessibilityCollectionItem for each cell in _pushCells()
    • Adds accessibilityCollection (rowCount/columnCount) to ScrollView wrapper
  • VirtualizedListCellRenderer.js: Receives and applies accessibilityCollectionItem prop to cell View and passes it to renderItem callback
  • ViewAccessibility.js: Added Flow types for AccessibilityCollection and AccessibilityCollectionItem to AccessibilityPropsAndroid
  • FlatList.js: Fixed multi-column grid accessibility by computing proper row/column indices

Changelog:

[ANDROID] [ADDED] - Added accessibility collection support to VirtualizedList for TalkBack "item X of Y" announcements

Test Plan

  • All existing VirtualizedList tests pass (74 passed, 2 skipped)
  • All existing FlatList tests pass (12 passed)
  • Flow type check passes (0 errors)
  • ESLint passes

To test with TalkBack:

  1. Enable TalkBack on Android device
  2. Navigate through a FlatList/VirtualizedList
  3. TalkBack should announce "item X of Y" for each item

🤖 Generated with Claude Code

This enables Android TalkBack to announce "item X of Y" when navigating
through VirtualizedList/FlatList items.

Changes:
- Add AccessibilityCollectionItem type to VirtualizedListProps
- Compute and pass accessibilityCollectionItem to each cell in VirtualizedList
- Apply accessibilityCollectionItem prop on cell wrapper View
- Add accessibilityCollection (rowCount/columnCount) to ScrollView
- Add Flow types for AccessibilityCollection and AccessibilityCollectionItem
- Fix FlatList multi-column grid accessibility with proper row/column indices

Closes facebook#30975

🤖 Generated with [Claude Code](https://claude.ai/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@meta-cla
Copy link

meta-cla bot commented Dec 5, 2025

Hi @nathannewyen!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 5, 2025
@meta-cla
Copy link

meta-cla bot commented Dec 5, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Position in Collection not supported by VirtualizedList

2 participants