From 3caeb508e09e15bd84ee8df100caa139b3a758a3 Mon Sep 17 00:00:00 2001 From: Dan Abramov Date: Tue, 10 Oct 2017 15:49:09 +0100 Subject: [PATCH 1/2] Add a failing test for SSR It causes a false positive warning on hydration. --- .../shared/__tests__/ReactDOMServerIntegration-test.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/renderers/dom/shared/__tests__/ReactDOMServerIntegration-test.js b/src/renderers/dom/shared/__tests__/ReactDOMServerIntegration-test.js index 3f7ba7abcff..15ea880a94c 100644 --- a/src/renderers/dom/shared/__tests__/ReactDOMServerIntegration-test.js +++ b/src/renderers/dom/shared/__tests__/ReactDOMServerIntegration-test.js @@ -1344,6 +1344,14 @@ describe('ReactDOMServerIntegration', () => { }, ); + itRenders('svg element with a mixed case name', async render => { + let e = await render(); + e = e.firstChild.firstChild; + expect(e.childNodes.length).toBe(0); + expect(e.tagName).toBe('feMorphology'); + expect(e.namespaceURI).toBe('http://www.w3.org/2000/svg'); + }); + itRenders('a math element', async render => { const e = await render(); expect(e.childNodes.length).toBe(0); From f3f8a9a4c1e5e2e0f024fff47581d8b24498095a Mon Sep 17 00:00:00 2001 From: Dan Abramov Date: Tue, 10 Oct 2017 15:52:52 +0100 Subject: [PATCH 2/2] Make hydration tag comparison case insensitive --- src/renderers/dom/fiber/ReactDOMFiberEntry.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/renderers/dom/fiber/ReactDOMFiberEntry.js b/src/renderers/dom/fiber/ReactDOMFiberEntry.js index 01090873ad7..0bd998e2886 100644 --- a/src/renderers/dom/fiber/ReactDOMFiberEntry.js +++ b/src/renderers/dom/fiber/ReactDOMFiberEntry.js @@ -446,7 +446,7 @@ var DOMRenderer = ReactFiberReconciler({ ): boolean { return ( instance.nodeType === ELEMENT_NODE && - type === instance.nodeName.toLowerCase() + type.toLowerCase() === instance.nodeName.toLowerCase() ); },