From e70120dde47e8caca39fabe1da1265901f7219a5 Mon Sep 17 00:00:00 2001 From: Jason Quense Date: Tue, 19 Dec 2017 11:30:17 -0500 Subject: [PATCH 1/2] Remove extra loop (?) --- packages/react-dom/src/client/ReactDOMComponentTree.js | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/packages/react-dom/src/client/ReactDOMComponentTree.js b/packages/react-dom/src/client/ReactDOMComponentTree.js index 3aeb3c0f529..6c810f75515 100644 --- a/packages/react-dom/src/client/ReactDOMComponentTree.js +++ b/packages/react-dom/src/client/ReactDOMComponentTree.js @@ -27,10 +27,7 @@ export function getClosestInstanceFromNode(node) { return node[internalInstanceKey]; } - // Walk up the tree until we find an ancestor whose instance we have cached. - let parents = []; while (!node[internalInstanceKey]) { - parents.push(node); if (node.parentNode) { node = node.parentNode; } else { @@ -40,17 +37,14 @@ export function getClosestInstanceFromNode(node) { } } - let closest; + let inst = node[internalInstanceKey]; if (inst.tag === HostComponent || inst.tag === HostText) { // In Fiber, this will always be the deepest root. return inst; } - for (; node && (inst = node[internalInstanceKey]); node = parents.pop()) { - closest = inst; - } - return closest; + return null; } /** From d5050810a22c955a63d4244fd1f9504e44c75e00 Mon Sep 17 00:00:00 2001 From: Jason Quense Date: Tue, 19 Dec 2017 11:48:55 -0500 Subject: [PATCH 2/2] prettier --- packages/react-dom/src/client/ReactDOMComponentTree.js | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/react-dom/src/client/ReactDOMComponentTree.js b/packages/react-dom/src/client/ReactDOMComponentTree.js index 6c810f75515..d9c2e2d858a 100644 --- a/packages/react-dom/src/client/ReactDOMComponentTree.js +++ b/packages/react-dom/src/client/ReactDOMComponentTree.js @@ -37,7 +37,6 @@ export function getClosestInstanceFromNode(node) { } } - let inst = node[internalInstanceKey]; if (inst.tag === HostComponent || inst.tag === HostText) { // In Fiber, this will always be the deepest root.