From 3431d5cee0b34ce04782101a46fa5a9df498a770 Mon Sep 17 00:00:00 2001 From: Amjad Masad Date: Thu, 13 Mar 2014 18:22:39 -0400 Subject: [PATCH] Don't fail silently for null or falsy event listeners. Fix #1255 --- src/browser/ui/ReactDOMComponent.js | 5 +---- src/event/EventPluginHub.js | 2 +- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/src/browser/ui/ReactDOMComponent.js b/src/browser/ui/ReactDOMComponent.js index 5b1eface68f..db483c44ece 100644 --- a/src/browser/ui/ReactDOMComponent.js +++ b/src/browser/ui/ReactDOMComponent.js @@ -144,12 +144,9 @@ ReactDOMComponent.Mixin = { continue; } var propValue = props[propKey]; - if (propValue == null) { - continue; - } if (registrationNameModules[propKey]) { putListener(this._rootNodeID, propKey, propValue, transaction); - } else { + } else if (propValue != null) { if (propKey === STYLE) { if (propValue) { propValue = props.style = merge(props.style); diff --git a/src/event/EventPluginHub.js b/src/event/EventPluginHub.js index 92c72618ccc..66472193bca 100644 --- a/src/event/EventPluginHub.js +++ b/src/event/EventPluginHub.js @@ -159,7 +159,7 @@ var EventPluginHub = { 'Cannot call putListener() in a non-DOM environment.' ); invariant( - !listener || typeof listener === 'function', + typeof listener === 'function', 'Expected %s listener to be a function, instead got type %s', registrationName, typeof listener );