From a8a102aaa95792b8e66a49d9c645228734000298 Mon Sep 17 00:00:00 2001 From: Nate Hunzaker Date: Sat, 8 Sep 2018 10:46:39 -0700 Subject: [PATCH] Break up ReactDOMServerIntegrationForm-test In https://github.com/facebook/react/pull/13394, I encountered an issue where the ReactDOMServerIntegrationForm test suite consumed sufficient memory to crash CircleCI. Breaking up this test suite by form element type resolved the issue. This commit performs that change separate from the Symbol/Function stringification changes in #13394. --- .../ReactDOMServerIntegrationCheckbox-test.js | 99 +++ .../ReactDOMServerIntegrationForms-test.js | 802 ------------------ .../ReactDOMServerIntegrationInput-test.js | 86 ++ .../ReactDOMServerIntegrationSelect-test.js | 250 ++++++ .../ReactDOMServerIntegrationTextarea-test.js | 97 +++ ...OMServerIntegrationUserInteraction-test.js | 366 ++++++++ .../ReactDOMserverIntegrationProgress-test.js | 46 + 7 files changed, 944 insertions(+), 802 deletions(-) create mode 100644 packages/react-dom/src/__tests__/ReactDOMServerIntegrationCheckbox-test.js delete mode 100644 packages/react-dom/src/__tests__/ReactDOMServerIntegrationForms-test.js create mode 100644 packages/react-dom/src/__tests__/ReactDOMServerIntegrationInput-test.js create mode 100644 packages/react-dom/src/__tests__/ReactDOMServerIntegrationSelect-test.js create mode 100644 packages/react-dom/src/__tests__/ReactDOMServerIntegrationTextarea-test.js create mode 100644 packages/react-dom/src/__tests__/ReactDOMServerIntegrationUserInteraction-test.js create mode 100644 packages/react-dom/src/__tests__/ReactDOMserverIntegrationProgress-test.js diff --git a/packages/react-dom/src/__tests__/ReactDOMServerIntegrationCheckbox-test.js b/packages/react-dom/src/__tests__/ReactDOMServerIntegrationCheckbox-test.js new file mode 100644 index 00000000000..61c08c12958 --- /dev/null +++ b/packages/react-dom/src/__tests__/ReactDOMServerIntegrationCheckbox-test.js @@ -0,0 +1,99 @@ +/** + * Copyright (c) Facebook, Inc. and its affiliates. + * + * This source code is licensed under the MIT license found in the + * LICENSE file in the root directory of this source tree. + * + * @emails react-core + */ + +'use strict'; + +const ReactDOMServerIntegrationUtils = require('./utils/ReactDOMServerIntegrationTestUtils'); + +let React; +let ReactDOM; +let ReactDOMServer; + +function initModules() { + // Reset warning cache. + jest.resetModuleRegistry(); + React = require('react'); + ReactDOM = require('react-dom'); + ReactDOMServer = require('react-dom/server'); + + // Make them available to the helpers. + return { + ReactDOM, + ReactDOMServer, + }; +} + +const {resetModules, itRenders} = ReactDOMServerIntegrationUtils(initModules); + +describe('ReactDOMServerIntegrationCheckbox', () => { + beforeEach(() => { + resetModules(); + }); + + itRenders('a checkbox that is checked with an onChange', async render => { + const e = await render( + {}} />, + ); + expect(e.checked).toBe(true); + }); + + itRenders('a checkbox that is checked with readOnly', async render => { + const e = await render( + , + ); + expect(e.checked).toBe(true); + }); + + itRenders( + 'a checkbox that is checked and no onChange/readOnly', + async render => { + // this configuration should raise a dev warning that checked without + // onChange or readOnly is a mistake. + const e = await render(, 1); + expect(e.checked).toBe(true); + }, + ); + + itRenders('a checkbox with defaultChecked', async render => { + const e = await render(); + expect(e.checked).toBe(true); + expect(e.getAttribute('defaultChecked')).toBe(null); + }); + + itRenders('a checkbox checked overriding defaultChecked', async render => { + const e = await render( + , + 1, + ); + expect(e.checked).toBe(true); + expect(e.getAttribute('defaultChecked')).toBe(null); + }); + + itRenders( + 'a checkbox checked overriding defaultChecked no matter the prop order', + async render => { + const e = await render( + , + 1, + ); + expect(e.checked).toBe(true); + expect(e.getAttribute('defaultChecked')).toBe(null); + }, + ); +}); diff --git a/packages/react-dom/src/__tests__/ReactDOMServerIntegrationForms-test.js b/packages/react-dom/src/__tests__/ReactDOMServerIntegrationForms-test.js deleted file mode 100644 index aef376168f4..00000000000 --- a/packages/react-dom/src/__tests__/ReactDOMServerIntegrationForms-test.js +++ /dev/null @@ -1,802 +0,0 @@ -/** - * Copyright (c) Facebook, Inc. and its affiliates. - * - * This source code is licensed under the MIT license found in the - * LICENSE file in the root directory of this source tree. - * - * @emails react-core - */ - -'use strict'; - -const ReactDOMServerIntegrationUtils = require('./utils/ReactDOMServerIntegrationTestUtils'); - -let React; -let ReactDOM; -let ReactDOMServer; - -function initModules() { - // Reset warning cache. - jest.resetModuleRegistry(); - React = require('react'); - ReactDOM = require('react-dom'); - ReactDOMServer = require('react-dom/server'); - - // Make them available to the helpers. - return { - ReactDOM, - ReactDOMServer, - }; -} - -const { - resetModules, - itRenders, - itClientRenders, - itThrowsWhenRendering, - renderIntoDom, - serverRender, -} = ReactDOMServerIntegrationUtils(initModules); - -describe('ReactDOMServerIntegration', () => { - beforeEach(() => { - resetModules(); - }); - - describe('form controls', function() { - describe('inputs', function() { - itRenders('an input with a value and an onChange', async render => { - const e = await render( {}} />); - expect(e.value).toBe('foo'); - }); - - itRenders('an input with a value and readOnly', async render => { - const e = await render(); - expect(e.value).toBe('foo'); - }); - - itRenders( - 'an input with a value and no onChange/readOnly', - async render => { - // this configuration should raise a dev warning that value without - // onChange or readOnly is a mistake. - const e = await render(, 1); - expect(e.value).toBe('foo'); - expect(e.getAttribute('value')).toBe('foo'); - }, - ); - - itRenders('an input with a defaultValue', async render => { - const e = await render(); - expect(e.value).toBe('foo'); - expect(e.getAttribute('value')).toBe('foo'); - expect(e.getAttribute('defaultValue')).toBe(null); - }); - - itRenders('an input value overriding defaultValue', async render => { - const e = await render( - , - 1, - ); - expect(e.value).toBe('foo'); - expect(e.getAttribute('value')).toBe('foo'); - expect(e.getAttribute('defaultValue')).toBe(null); - }); - - itRenders( - 'an input value overriding defaultValue no matter the prop order', - async render => { - const e = await render( - , - 1, - ); - expect(e.value).toBe('foo'); - expect(e.getAttribute('value')).toBe('foo'); - expect(e.getAttribute('defaultValue')).toBe(null); - }, - ); - }); - - describe('checkboxes', function() { - itRenders('a checkbox that is checked with an onChange', async render => { - const e = await render( - {}} />, - ); - expect(e.checked).toBe(true); - }); - - itRenders('a checkbox that is checked with readOnly', async render => { - const e = await render( - , - ); - expect(e.checked).toBe(true); - }); - - itRenders( - 'a checkbox that is checked and no onChange/readOnly', - async render => { - // this configuration should raise a dev warning that checked without - // onChange or readOnly is a mistake. - const e = await render(, 1); - expect(e.checked).toBe(true); - }, - ); - - itRenders('a checkbox with defaultChecked', async render => { - const e = await render(); - expect(e.checked).toBe(true); - expect(e.getAttribute('defaultChecked')).toBe(null); - }); - - itRenders( - 'a checkbox checked overriding defaultChecked', - async render => { - const e = await render( - , - 1, - ); - expect(e.checked).toBe(true); - expect(e.getAttribute('defaultChecked')).toBe(null); - }, - ); - - itRenders( - 'a checkbox checked overriding defaultChecked no matter the prop order', - async render => { - const e = await render( - , - 1, - ); - expect(e.checked).toBe(true); - expect(e.getAttribute('defaultChecked')).toBe(null); - }, - ); - }); - - describe('textareas', function() { - // textareas - // --------- - itRenders('a textarea with a value and an onChange', async render => { - const e = await render(