From 78a67fd431365740940c331a5aeabcaa30606b20 Mon Sep 17 00:00:00 2001 From: Deniz Susman Date: Thu, 31 Jan 2019 17:24:47 +0300 Subject: [PATCH 1/2] Typo in comment "synchronously" instead of "syncrhonously". --- .../src/__tests__/createSubscription-test.internal.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/create-subscription/src/__tests__/createSubscription-test.internal.js b/packages/create-subscription/src/__tests__/createSubscription-test.internal.js index b2b081d7127..6c325a7434a 100644 --- a/packages/create-subscription/src/__tests__/createSubscription-test.internal.js +++ b/packages/create-subscription/src/__tests__/createSubscription-test.internal.js @@ -148,7 +148,7 @@ describe('createSubscription', () => { // Test a promise that resolves before render // Note that this will require an extra render anyway, - // Because there is no way to syncrhonously get a Promise's value + // Because there is no way to synchronously get a Promise's value rejectB(false); ReactNoop.render({render}); expect(ReactNoop.flush()).toEqual(['loading']); From ec9febfaaaba6533251c2abdbc07120728961d47 Mon Sep 17 00:00:00 2001 From: Deniz Susman Date: Thu, 31 Jan 2019 17:26:52 +0300 Subject: [PATCH 2/2] Update createSubscription-test.internal.js "subscribable" instead of "subsribable". --- .../src/__tests__/createSubscription-test.internal.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/create-subscription/src/__tests__/createSubscription-test.internal.js b/packages/create-subscription/src/__tests__/createSubscription-test.internal.js index 6c325a7434a..cbbb34979a3 100644 --- a/packages/create-subscription/src/__tests__/createSubscription-test.internal.js +++ b/packages/create-subscription/src/__tests__/createSubscription-test.internal.js @@ -431,7 +431,7 @@ describe('createSubscription', () => { 'Parent.componentDidUpdate', ]); - // Updates from the new subsribable should be ignored. + // Updates from the new subscribable should be ignored. observableB.next('b-1'); expect(ReactNoop.flush()).toEqual([]); expect(log).toEqual([