From 2e583eb65158f01c7969b280f5e8b272d17699be Mon Sep 17 00:00:00 2001 From: Eli White Date: Wed, 20 Feb 2019 23:29:39 -0800 Subject: [PATCH] Fix warning message for new setNativeProps method. on -> with --- .../src/ReactNativeRendererSharedExports.js | 2 +- .../src/__tests__/ReactFabric-test.internal.js | 2 +- .../src/__tests__/ReactNativeMount-test.internal.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/react-native-renderer/src/ReactNativeRendererSharedExports.js b/packages/react-native-renderer/src/ReactNativeRendererSharedExports.js index ddfd296fd20..91ddf9ed88e 100644 --- a/packages/react-native-renderer/src/ReactNativeRendererSharedExports.js +++ b/packages/react-native-renderer/src/ReactNativeRendererSharedExports.js @@ -19,7 +19,7 @@ export function setNativeProps(handle: any, nativeProps: Object): void { if (handle._nativeTag == null) { warningWithoutStack( handle._nativeTag != null, - "setNativeProps was called on a ref that isn't a " + + "setNativeProps was called with a ref that isn't a " + 'native component. Use React.forwardRef to get access to the underlying native component', ); return; diff --git a/packages/react-native-renderer/src/__tests__/ReactFabric-test.internal.js b/packages/react-native-renderer/src/__tests__/ReactFabric-test.internal.js index 90ad6c3e80b..2f19765c9e0 100644 --- a/packages/react-native-renderer/src/__tests__/ReactFabric-test.internal.js +++ b/packages/react-native-renderer/src/__tests__/ReactFabric-test.internal.js @@ -287,7 +287,7 @@ describe('ReactFabric', () => { ReactFabric.setNativeProps(viewRef, {foo: 'baz'}); }).toWarnDev( [ - "Warning: setNativeProps was called on a ref that isn't a " + + "Warning: setNativeProps was called with a ref that isn't a " + 'native component. Use React.forwardRef to get access ' + 'to the underlying native component', ], diff --git a/packages/react-native-renderer/src/__tests__/ReactNativeMount-test.internal.js b/packages/react-native-renderer/src/__tests__/ReactNativeMount-test.internal.js index 225c941b398..d655f67870f 100644 --- a/packages/react-native-renderer/src/__tests__/ReactNativeMount-test.internal.js +++ b/packages/react-native-renderer/src/__tests__/ReactNativeMount-test.internal.js @@ -218,7 +218,7 @@ describe('ReactNative', () => { ReactNative.setNativeProps(viewRef, {foo: 'baz'}); }).toWarnDev( [ - "Warning: setNativeProps was called on a ref that isn't a " + + "Warning: setNativeProps was called with a ref that isn't a " + 'native component. Use React.forwardRef to get access ' + 'to the underlying native component', ],