From 1ce9691356ca8dd883efdb2d099536a12d24afb3 Mon Sep 17 00:00:00 2001 From: Dan Abramov Date: Mon, 10 Feb 2020 16:01:21 +0000 Subject: [PATCH 1/2] Revert "Update ReactFiberExpirationTime.js (#17825)" This reverts commit b63cb6f6cf18bbe28eb0a443c64fd9b87d79616d. --- packages/react-reconciler/src/ReactFiberExpirationTime.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-reconciler/src/ReactFiberExpirationTime.js b/packages/react-reconciler/src/ReactFiberExpirationTime.js index f79f4cdaaac..72d58dff4eb 100644 --- a/packages/react-reconciler/src/ReactFiberExpirationTime.js +++ b/packages/react-reconciler/src/ReactFiberExpirationTime.js @@ -43,7 +43,7 @@ const MAGIC_NUMBER_OFFSET = Batched - 1; // 1 unit of expiration time represents 10ms. export function msToExpirationTime(ms: number): ExpirationTime { - // Always subtract an offset so that we don't clash with the magic number for NoWork. + // Always add an offset so that we don't clash with the magic number for NoWork. return MAGIC_NUMBER_OFFSET - ((ms / UNIT_SIZE) | 0); } From 251398363f3cdca162e802aeb8996e25d4e05de7 Mon Sep 17 00:00:00 2001 From: Dan Abramov Date: Mon, 10 Feb 2020 16:12:51 +0000 Subject: [PATCH 2/2] Reword --- packages/react-reconciler/src/ReactFiberExpirationTime.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-reconciler/src/ReactFiberExpirationTime.js b/packages/react-reconciler/src/ReactFiberExpirationTime.js index 72d58dff4eb..b27a75aeba6 100644 --- a/packages/react-reconciler/src/ReactFiberExpirationTime.js +++ b/packages/react-reconciler/src/ReactFiberExpirationTime.js @@ -43,7 +43,7 @@ const MAGIC_NUMBER_OFFSET = Batched - 1; // 1 unit of expiration time represents 10ms. export function msToExpirationTime(ms: number): ExpirationTime { - // Always add an offset so that we don't clash with the magic number for NoWork. + // Always subtract from the offset so that we don't clash with the magic number for NoWork. return MAGIC_NUMBER_OFFSET - ((ms / UNIT_SIZE) | 0); }