From e9062ee8e91aab5a038cff8d4b832089b7068a7b Mon Sep 17 00:00:00 2001 From: eps1lon Date: Thu, 7 Oct 2021 13:35:04 +0200 Subject: [PATCH 1/7] Fix missing key warning --- fixtures/attribute-behavior/src/App.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fixtures/attribute-behavior/src/App.js b/fixtures/attribute-behavior/src/App.js index 7cb678b5873..b8008eb8dc4 100644 --- a/fixtures/attribute-behavior/src/App.js +++ b/fixtures/attribute-behavior/src/App.js @@ -723,9 +723,9 @@ class App extends React.Component { rowPatternHashes: null, }; - renderCell = props => { + renderCell = ({key, ...props}) => { return ( -
+
Date: Thu, 7 Oct 2021 13:35:12 +0200 Subject: [PATCH 2/7] Add build instructions --- fixtures/attribute-behavior/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fixtures/attribute-behavior/README.md b/fixtures/attribute-behavior/README.md index 2411462f11a..ecee33a5e6c 100644 --- a/fixtures/attribute-behavior/README.md +++ b/fixtures/attribute-behavior/README.md @@ -8,7 +8,7 @@ ## Instructions -`cd fixtures/attribute-behavior && yarn install && yarn start` +`yarn build --type=UMD_DEV react/index,react-dom && cd fixtures/attribute-behavior && yarn install && yarn start` ## Interpretation From e5d4fb1fdb1538c5fab95e96a5ddb3e6cb0d469e Mon Sep 17 00:00:00 2001 From: eps1lon Date: Thu, 7 Oct 2021 13:44:08 +0200 Subject: [PATCH 3/7] Update interpretation now that React 17 is latest stable and 18 is next --- fixtures/attribute-behavior/README.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/fixtures/attribute-behavior/README.md b/fixtures/attribute-behavior/README.md index ecee33a5e6c..51b3452e86d 100644 --- a/fixtures/attribute-behavior/README.md +++ b/fixtures/attribute-behavior/README.md @@ -16,9 +16,8 @@ Each row is an attribute which could be set on some DOM component. Some of them are invalid or mis-capitalized or mixed up versions of real ones. Each column is a value which can be passed to that attribute. Every cell has a box on the left and a box on the right. -The left box shows the property (or attribute) assigned by React 15.\*, and the -right box shows the property (or attribute) assigned by the latest version of -React 16. +The left box shows the property (or attribute) assigned by the latest stable release of React, and the +right box shows the property (or attribute) assigned by the locally built version of React. Right now, we use a purple outline to call out cases where the assigned property (or attribute) has changed between React 15 and 16. From 9ada2937fbf846adc31184c876ead48f51af0628 Mon Sep 17 00:00:00 2001 From: eps1lon Date: Thu, 7 Oct 2021 13:46:27 +0200 Subject: [PATCH 4/7] Ignore ReactDOM.render deprecation warning --- fixtures/attribute-behavior/src/App.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fixtures/attribute-behavior/src/App.js b/fixtures/attribute-behavior/src/App.js index b8008eb8dc4..b47c83dcc80 100644 --- a/fixtures/attribute-behavior/src/App.js +++ b/fixtures/attribute-behavior/src/App.js @@ -213,6 +213,9 @@ function getCanonicalizedValue(value) { let _didWarn = false; function warn(str) { + if (str.includes('ReactDOM.render is no longer supported')) { + return; + } _didWarn = true; } const UNKNOWN_HTML_TAGS = new Set(['keygen', 'time', 'command']); From 724231c3bcf387167532bfbcf8f533a00d574346 Mon Sep 17 00:00:00 2001 From: eps1lon Date: Thu, 7 Oct 2021 13:59:22 +0200 Subject: [PATCH 5/7] Ensure a server implementation with `renderToString` is used --- fixtures/attribute-behavior/.gitignore | 2 +- fixtures/attribute-behavior/package.json | 2 +- fixtures/attribute-behavior/src/App.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fixtures/attribute-behavior/.gitignore b/fixtures/attribute-behavior/.gitignore index 49c5a75db94..9190def2d17 100644 --- a/fixtures/attribute-behavior/.gitignore +++ b/fixtures/attribute-behavior/.gitignore @@ -10,7 +10,7 @@ /build /public/react.development.js /public/react-dom.development.js -/public/react-dom-server.browser.development.js +/public/react-dom-server-legacy.browser.development.js # misc .DS_Store diff --git a/fixtures/attribute-behavior/package.json b/fixtures/attribute-behavior/package.json index 4149300e1be..e71f60ec2e1 100644 --- a/fixtures/attribute-behavior/package.json +++ b/fixtures/attribute-behavior/package.json @@ -12,7 +12,7 @@ }, "scripts": { "prestart": - "cp ../../build/node_modules/react/umd/react.development.js public/ && cp ../../build/node_modules/react-dom/umd/react-dom.development.js public/ && cp ../../build/node_modules/react-dom/umd/react-dom-server.browser.development.js public/", + "cp ../../build/node_modules/react/umd/react.development.js public/ && cp ../../build/node_modules/react-dom/umd/react-dom.development.js public/ && cp ../../build/node_modules/react-dom/umd/react-dom-server-legacy.browser.development.js public/", "start": "react-scripts start", "build": "react-scripts build", "test": "react-scripts test --env=jsdom", diff --git a/fixtures/attribute-behavior/src/App.js b/fixtures/attribute-behavior/src/App.js index b47c83dcc80..ab62c09cb98 100644 --- a/fixtures/attribute-behavior/src/App.js +++ b/fixtures/attribute-behavior/src/App.js @@ -767,7 +767,7 @@ class App extends React.Component { 'https://unpkg.com/react-dom@latest/umd/react-dom-server.browser.development.js', ReactNext: '/react.development.js', ReactDOMNext: '/react-dom.development.js', - ReactDOMServerNext: '/react-dom-server.browser.development.js', + ReactDOMServerNext: '/react-dom-server-legacy.browser.development.js', }; const codePromises = Object.values(sources).map(src => fetch(src).then(res => res.text()) From 0de7328b86562fd69228e5aa5e40f9a3d4109825 Mon Sep 17 00:00:00 2001 From: eps1lon Date: Thu, 7 Oct 2021 14:01:07 +0200 Subject: [PATCH 6/7] Update AttributeTableSnapshot --- .../AttributeTableSnapshot.md | 490 ++++++++++-------- 1 file changed, 270 insertions(+), 220 deletions(-) diff --git a/fixtures/attribute-behavior/AttributeTableSnapshot.md b/fixtures/attribute-behavior/AttributeTableSnapshot.md index 5a57877f1b6..61037b69c40 100644 --- a/fixtures/attribute-behavior/AttributeTableSnapshot.md +++ b/fixtures/attribute-behavior/AttributeTableSnapshot.md @@ -526,23 +526,23 @@ ## `amplitude` (on `` inside ``) | Test Case | Flags | Result | | --- | --- | --- | -| `amplitude=(string)`| (changed)| `` | +| `amplitude=(string)`| (initial)| `` | | `amplitude=(empty string)`| (changed)| `` | -| `amplitude=(array with string)`| (changed)| `` | +| `amplitude=(array with string)`| (initial)| `` | | `amplitude=(empty array)`| (changed)| `` | -| `amplitude=(object)`| (changed)| `` | +| `amplitude=(object)`| (initial)| `` | | `amplitude=(numeric string)`| (changed)| `` | | `amplitude=(-1)`| (changed)| `` | | `amplitude=(0)`| (changed)| `` | | `amplitude=(integer)`| (initial)| `` | -| `amplitude=(NaN)`| (changed, warning)| `` | +| `amplitude=(NaN)`| (initial, warning)| `` | | `amplitude=(float)`| (changed)| `` | | `amplitude=(true)`| (initial, warning)| `` | | `amplitude=(false)`| (initial, warning)| `` | -| `amplitude=(string 'true')`| (changed)| `` | -| `amplitude=(string 'false')`| (changed)| `` | -| `amplitude=(string 'on')`| (changed)| `` | -| `amplitude=(string 'off')`| (changed)| `` | +| `amplitude=(string 'true')`| (initial)| `` | +| `amplitude=(string 'false')`| (initial)| `` | +| `amplitude=(string 'on')`| (initial)| `` | +| `amplitude=(string 'off')`| (initial)| `` | | `amplitude=(symbol)`| (initial, warning)| `` | | `amplitude=(function)`| (initial, warning)| `` | | `amplitude=(null)`| (initial)| `` | @@ -830,17 +830,17 @@ | `autoComplete=(empty string)`| (initial)| `` | | `autoComplete=(array with string)`| (changed)| `"email"` | | `autoComplete=(empty array)`| (initial)| `` | -| `autoComplete=(object)`| (changed)| `"result of toString()"` | -| `autoComplete=(numeric string)`| (changed)| `"42"` | -| `autoComplete=(-1)`| (changed)| `"-1"` | -| `autoComplete=(0)`| (changed)| `"0"` | -| `autoComplete=(integer)`| (changed)| `"1"` | -| `autoComplete=(NaN)`| (changed, warning)| `"NaN"` | -| `autoComplete=(float)`| (changed)| `"99.99"` | +| `autoComplete=(object)`| (initial)| `` | +| `autoComplete=(numeric string)`| (initial)| `` | +| `autoComplete=(-1)`| (initial)| `` | +| `autoComplete=(0)`| (initial)| `` | +| `autoComplete=(integer)`| (initial)| `` | +| `autoComplete=(NaN)`| (initial, warning)| `` | +| `autoComplete=(float)`| (initial)| `` | | `autoComplete=(true)`| (initial, warning)| `` | | `autoComplete=(false)`| (initial, warning)| `` | -| `autoComplete=(string 'true')`| (changed)| `"true"` | -| `autoComplete=(string 'false')`| (changed)| `"false"` | +| `autoComplete=(string 'true')`| (initial)| `` | +| `autoComplete=(string 'false')`| (initial)| `` | | `autoComplete=(string 'on')`| (changed)| `"on"` | | `autoComplete=(string 'off')`| (changed)| `"off"` | | `autoComplete=(symbol)`| (initial, warning)| `` | @@ -1469,16 +1469,16 @@ | `children=(string 'on')`| (initial)| `[]` | | `children=(string 'off')`| (initial)| `[]` | | `children=(symbol)`| (initial)| `[]` | -| `children=(function)`| (initial, warning, ssr warning)| `[]` | +| `children=(function)`| (initial, warning)| `[]` | | `children=(null)`| (initial)| `[]` | | `children=(undefined)`| (initial)| `[]` | ## `cite` (on `
` inside `
`) | Test Case | Flags | Result | | --- | --- | --- | -| `cite=(string)`| (changed)| `"http://reactjs.com/"` | +| `cite=(string)`| (changed)| `"https://reactjs.com/"` | | `cite=(empty string)`| (changed)| `"http://localhost:3000/"` | -| `cite=(array with string)`| (changed)| `"http://reactjs.com/"` | +| `cite=(array with string)`| (changed)| `"https://reactjs.com/"` | | `cite=(empty array)`| (changed)| `"http://localhost:3000/"` | | `cite=(object)`| (changed)| `"http://localhost:3000/result%20of%20toString()"` | | `cite=(numeric string)`| (changed)| `"http://localhost:3000/42"` | @@ -2560,7 +2560,7 @@ | `defaultChecked=(-1)`| (changed)| `` | | `defaultChecked=(0)`| (initial)| `` | | `defaultChecked=(integer)`| (changed)| `` | -| `defaultChecked=(NaN)`| (initial, warning, ssr warning)| `` | +| `defaultChecked=(NaN)`| (initial, warning)| `` | | `defaultChecked=(float)`| (changed)| `` | | `defaultChecked=(true)`| (changed)| `` | | `defaultChecked=(false)`| (initial)| `` | @@ -2593,9 +2593,9 @@ | `defaultValue=(string 'false')`| (changed)| `"false"` | | `defaultValue=(string 'on')`| (changed)| `"on"` | | `defaultValue=(string 'off')`| (changed)| `"off"` | -| `defaultValue=(symbol)`| (initial, ssr warning)| `` | -| `defaultValue=(function)`| (initial, ssr warning)| `` | -| `defaultValue=(null)`| (initial, ssr warning)| `` | +| `defaultValue=(symbol)`| (initial)| `` | +| `defaultValue=(function)`| (initial)| `` | +| `defaultValue=(null)`| (initial)| `` | | `defaultValue=(undefined)`| (initial)| `` | ## `defaultValuE` (on `` inside `
`) @@ -2676,23 +2676,23 @@ ## `diffuseConstant` (on `` inside ``) | Test Case | Flags | Result | | --- | --- | --- | -| `diffuseConstant=(string)`| (changed)| `` | +| `diffuseConstant=(string)`| (initial)| `` | | `diffuseConstant=(empty string)`| (changed)| `` | -| `diffuseConstant=(array with string)`| (changed)| `` | +| `diffuseConstant=(array with string)`| (initial)| `` | | `diffuseConstant=(empty array)`| (changed)| `` | -| `diffuseConstant=(object)`| (changed)| `` | +| `diffuseConstant=(object)`| (initial)| `` | | `diffuseConstant=(numeric string)`| (changed)| `` | | `diffuseConstant=(-1)`| (changed)| `` | | `diffuseConstant=(0)`| (changed)| `` | | `diffuseConstant=(integer)`| (initial)| `` | -| `diffuseConstant=(NaN)`| (changed, warning)| `` | +| `diffuseConstant=(NaN)`| (initial, warning)| `` | | `diffuseConstant=(float)`| (changed)| `` | | `diffuseConstant=(true)`| (initial, warning)| `` | | `diffuseConstant=(false)`| (initial, warning)| `` | -| `diffuseConstant=(string 'true')`| (changed)| `` | -| `diffuseConstant=(string 'false')`| (changed)| `` | -| `diffuseConstant=(string 'on')`| (changed)| `` | -| `diffuseConstant=(string 'off')`| (changed)| `` | +| `diffuseConstant=(string 'true')`| (initial)| `` | +| `diffuseConstant=(string 'false')`| (initial)| `` | +| `diffuseConstant=(string 'on')`| (initial)| `` | +| `diffuseConstant=(string 'off')`| (initial)| `` | | `diffuseConstant=(symbol)`| (initial, warning)| `` | | `diffuseConstant=(function)`| (initial, warning)| `` | | `diffuseConstant=(null)`| (initial)| `` | @@ -2773,6 +2773,56 @@ | `disabled=(null)`| (initial)| `` | | `disabled=(undefined)`| (initial)| `` | +## `disablePictureInPicture` (on `
`) +| Test Case | Flags | Result | +| --- | --- | --- | +| `disablePictureInPicture=(string)`| (initial)| `` | +| `disablePictureInPicture=(empty string)`| (initial)| `` | +| `disablePictureInPicture=(array with string)`| (initial)| `` | +| `disablePictureInPicture=(empty array)`| (initial)| `` | +| `disablePictureInPicture=(object)`| (initial)| `` | +| `disablePictureInPicture=(numeric string)`| (initial)| `` | +| `disablePictureInPicture=(-1)`| (initial)| `` | +| `disablePictureInPicture=(0)`| (initial)| `` | +| `disablePictureInPicture=(integer)`| (initial)| `` | +| `disablePictureInPicture=(NaN)`| (initial, warning)| `` | +| `disablePictureInPicture=(float)`| (initial)| `` | +| `disablePictureInPicture=(true)`| (initial)| `` | +| `disablePictureInPicture=(false)`| (initial)| `` | +| `disablePictureInPicture=(string 'true')`| (initial, warning)| `` | +| `disablePictureInPicture=(string 'false')`| (initial, warning)| `` | +| `disablePictureInPicture=(string 'on')`| (initial)| `` | +| `disablePictureInPicture=(string 'off')`| (initial)| `` | +| `disablePictureInPicture=(symbol)`| (initial, warning)| `` | +| `disablePictureInPicture=(function)`| (initial, warning)| `` | +| `disablePictureInPicture=(null)`| (initial)| `` | +| `disablePictureInPicture=(undefined)`| (initial)| `` | + +## `disableRemotePlayback` (on `