From b77b4de3ba05a5cfbf0d33ba0842db57c7812163 Mon Sep 17 00:00:00 2001 From: Sebastian Markbage Date: Thu, 16 Dec 2021 19:36:11 -0500 Subject: [PATCH] Remove unnecessary clearContainer call This was added when we added error recovery for hydration errors. However, when the fix up pass happens later on, it'll still call clearContainer in the commit phase. So this call is unnecessary. --- packages/react-reconciler/src/ReactFiberWorkLoop.new.js | 2 -- packages/react-reconciler/src/ReactFiberWorkLoop.old.js | 2 -- 2 files changed, 4 deletions(-) diff --git a/packages/react-reconciler/src/ReactFiberWorkLoop.new.js b/packages/react-reconciler/src/ReactFiberWorkLoop.new.js index f0f5eab4a99..740ed6dca40 100644 --- a/packages/react-reconciler/src/ReactFiberWorkLoop.new.js +++ b/packages/react-reconciler/src/ReactFiberWorkLoop.new.js @@ -86,7 +86,6 @@ import { cancelTimeout, noTimeout, afterActiveInstanceBlur, - clearContainer, getCurrentEventPriority, supportsMicrotasks, errorHydratingContainer, @@ -885,7 +884,6 @@ function recoverFromConcurrentError(root, errorRetryLanes) { if (__DEV__) { errorHydratingContainer(root.containerInfo); } - clearContainer(root.containerInfo); } let exitStatus; diff --git a/packages/react-reconciler/src/ReactFiberWorkLoop.old.js b/packages/react-reconciler/src/ReactFiberWorkLoop.old.js index 353de50e158..673da7908c2 100644 --- a/packages/react-reconciler/src/ReactFiberWorkLoop.old.js +++ b/packages/react-reconciler/src/ReactFiberWorkLoop.old.js @@ -86,7 +86,6 @@ import { cancelTimeout, noTimeout, afterActiveInstanceBlur, - clearContainer, getCurrentEventPriority, supportsMicrotasks, errorHydratingContainer, @@ -885,7 +884,6 @@ function recoverFromConcurrentError(root, errorRetryLanes) { if (__DEV__) { errorHydratingContainer(root.containerInfo); } - clearContainer(root.containerInfo); } let exitStatus;