From 9e4b540f8e8231700ec7c7bb0b9ab6422f598725 Mon Sep 17 00:00:00 2001 From: ThomasCrvsr Date: Tue, 14 Oct 2014 10:58:31 +0200 Subject: [PATCH 1/2] Use of this._rootNodeID in componentDidMount of ReactDOMInput according to #2327 --- src/browser/ui/dom/components/ReactDOMInput.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/browser/ui/dom/components/ReactDOMInput.js b/src/browser/ui/dom/components/ReactDOMInput.js index 670e5de8af3..77ea6361f41 100644 --- a/src/browser/ui/dom/components/ReactDOMInput.js +++ b/src/browser/ui/dom/components/ReactDOMInput.js @@ -83,7 +83,7 @@ var ReactDOMInput = ReactCompositeComponent.createClass({ }, componentDidMount: function() { - var id = ReactMount.getID(this.getDOMNode()); + var id = this._rootNodeID; instancesByReactID[id] = this; }, From 69afa154b58373c935ef7406f6c03a46e085c29a Mon Sep 17 00:00:00 2001 From: ThomasCrvsr Date: Tue, 14 Oct 2014 15:33:31 +0200 Subject: [PATCH 2/2] #2327 Use of this._rootNodeID in componentWillUnmount of ReactDOMInput --- src/browser/ui/dom/components/ReactDOMInput.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/browser/ui/dom/components/ReactDOMInput.js b/src/browser/ui/dom/components/ReactDOMInput.js index 77ea6361f41..e74942bae1a 100644 --- a/src/browser/ui/dom/components/ReactDOMInput.js +++ b/src/browser/ui/dom/components/ReactDOMInput.js @@ -88,8 +88,7 @@ var ReactDOMInput = ReactCompositeComponent.createClass({ }, componentWillUnmount: function() { - var rootNode = this.getDOMNode(); - var id = ReactMount.getID(rootNode); + var id = this._rootNodeID; delete instancesByReactID[id]; }, @@ -147,6 +146,7 @@ var ReactDOMInput = ReactCompositeComponent.createClass({ continue; } var otherID = ReactMount.getID(otherNode); + invariant( otherID, 'ReactDOMInput: Mixing React and non-React radio inputs with the ' +