diff --git a/src/browser/ReactDOM.js b/src/browser/ReactDOM.js index 3bc9c5c1027..d4b1303b444 100644 --- a/src/browser/ReactDOM.js +++ b/src/browser/ReactDOM.js @@ -14,7 +14,6 @@ var ReactElement = require('ReactElement'); var ReactElementValidator = require('ReactElementValidator'); -var ReactLegacyElement = require('ReactLegacyElement'); var mapObject = require('mapObject'); @@ -26,13 +25,9 @@ var mapObject = require('mapObject'); */ function createDOMFactory(tag) { if (__DEV__) { - return ReactLegacyElement.markNonLegacyFactory( - ReactElementValidator.createFactory(tag) - ); + return ReactElementValidator.createFactory(tag); } - return ReactLegacyElement.markNonLegacyFactory( - ReactElement.createFactory(tag) - ); + return ReactElement.createFactory(tag); } /** diff --git a/src/browser/__tests__/ReactDOM-test.js b/src/browser/__tests__/ReactDOM-test.js index c47ef01f69b..b839089d2b8 100644 --- a/src/browser/__tests__/ReactDOM-test.js +++ b/src/browser/__tests__/ReactDOM-test.js @@ -114,24 +114,4 @@ describe('ReactDOM', function() { expect(element.type).toBe('div'); expect(console.warn.argsForCall.length).toBe(0); }); - - it('warns but allow dom factories to be used in createFactory', function() { - spyOn(console, 'warn'); - var factory = React.createFactory(React.DOM.div); - expect(factory().type).toBe('div'); - expect(console.warn.argsForCall.length).toBe(1); - expect(console.warn.argsForCall[0][0]).toContain( - 'Do not pass React.DOM.div' - ); - }); - - it('warns but allow dom factories to be used in createElement', function() { - spyOn(console, 'warn'); - var element = React.createElement(React.DOM.div); - expect(element.type).toBe('div'); - expect(console.warn.argsForCall.length).toBe(1); - expect(console.warn.argsForCall[0][0]).toContain( - 'Do not pass React.DOM.div' - ); - }); }); diff --git a/src/browser/ui/React.js b/src/browser/ui/React.js index 83d15f84d77..19de5a77ea9 100644 --- a/src/browser/ui/React.js +++ b/src/browser/ui/React.js @@ -24,7 +24,6 @@ var ReactDOM = require('ReactDOM'); var ReactDOMComponent = require('ReactDOMComponent'); var ReactDefaultInjection = require('ReactDefaultInjection'); var ReactInstanceHandles = require('ReactInstanceHandles'); -var ReactLegacyElement = require('ReactLegacyElement'); var ReactMount = require('ReactMount'); var ReactMultiChild = require('ReactMultiChild'); var ReactPerf = require('ReactPerf'); @@ -46,14 +45,6 @@ if (__DEV__) { createFactory = ReactElementValidator.createFactory; } -// TODO: Drop legacy elements once classes no longer export these factories -createElement = ReactLegacyElement.wrapCreateElement( - createElement -); -createFactory = ReactLegacyElement.wrapCreateFactory( - createFactory -); - var render = ReactPerf.measure('React', 'render', ReactMount.render); var React = { @@ -77,7 +68,6 @@ var React = { renderToString: ReactServerRendering.renderToString, renderToStaticMarkup: ReactServerRendering.renderToStaticMarkup, unmountComponentAtNode: ReactMount.unmountComponentAtNode, - isValidClass: ReactLegacyElement.isValidClass, isValidElement: ReactElement.isValidElement, withContext: ReactContext.withContext, diff --git a/src/browser/ui/ReactMount.js b/src/browser/ui/ReactMount.js index 57a20710ff3..642fe67e5e4 100644 --- a/src/browser/ui/ReactMount.js +++ b/src/browser/ui/ReactMount.js @@ -15,7 +15,6 @@ var DOMProperty = require('DOMProperty'); var ReactBrowserEventEmitter = require('ReactBrowserEventEmitter'); var ReactCurrentOwner = require('ReactCurrentOwner'); var ReactElement = require('ReactElement'); -var ReactLegacyElement = require('ReactLegacyElement'); var ReactInstanceHandles = require('ReactInstanceHandles'); var ReactPerf = require('ReactPerf'); @@ -27,10 +26,6 @@ var invariant = require('invariant'); var shouldUpdateReactComponent = require('shouldUpdateReactComponent'); var warning = require('warning'); -var createElement = ReactLegacyElement.wrapCreateElement( - ReactElement.createElement -); - var SEPARATOR = ReactInstanceHandles.SEPARATOR; var ATTR_NAME = DOMProperty.ID_ATTRIBUTE_NAME; @@ -342,7 +337,7 @@ var ReactMount = { typeof nextElement === 'string' ? ' Instead of passing an element string, make sure to instantiate ' + 'it by passing it to React.createElement.' : - ReactLegacyElement.isValidFactory(nextElement) ? + typeof nextElement === 'function' ? ' Instead of passing a component class, make sure to instantiate ' + 'it by passing it to React.createElement.' : // Check if it quacks like a element @@ -394,7 +389,7 @@ var ReactMount = { * @return {ReactComponent} Component instance rendered in `container`. */ constructAndRenderComponent: function(constructor, props, container) { - var element = createElement(constructor, props); + var element = ReactElement.createElement(constructor, props); return ReactMount.render(element, container); }, diff --git a/src/browser/ui/dom/components/ReactDOMButton.js b/src/browser/ui/dom/components/ReactDOMButton.js index ed23b00289c..a5fd34caf6d 100644 --- a/src/browser/ui/dom/components/ReactDOMButton.js +++ b/src/browser/ui/dom/components/ReactDOMButton.js @@ -15,12 +15,10 @@ var AutoFocusMixin = require('AutoFocusMixin'); var ReactBrowserComponentMixin = require('ReactBrowserComponentMixin'); var ReactClass = require('ReactClass'); var ReactElement = require('ReactElement'); -var ReactDOM = require('ReactDOM'); var keyMirror = require('keyMirror'); -// Store a reference to the