From dded82b5974acc0bd2533852da7d8cfe113c6f8d Mon Sep 17 00:00:00 2001 From: Sebastian Markbage Date: Tue, 5 Aug 2025 13:56:45 -0400 Subject: [PATCH 1/2] Columns in source maps are returned as zero based but we use one based in ReactCallSite and ReactFunctionLocation --- packages/react-devtools-shared/src/symbolicateSource.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/react-devtools-shared/src/symbolicateSource.js b/packages/react-devtools-shared/src/symbolicateSource.js index e5f469a21a5..49a30984c28 100644 --- a/packages/react-devtools-shared/src/symbolicateSource.js +++ b/packages/react-devtools-shared/src/symbolicateSource.js @@ -82,12 +82,14 @@ export async function symbolicateSource( const { sourceURL: possiblyURL, line, - column, + column: columnZeroBased, } = consumer.originalPositionFor({ lineNumber, // 1-based columnNumber, // 1-based }); + const column = columnZeroBased + 1; + if (possiblyURL === null) { return null; } From d7548edc95fbe79e36f57af705a13bf457baaf34 Mon Sep 17 00:00:00 2001 From: Sebastian Markbage Date: Wed, 6 Aug 2025 13:20:11 -0400 Subject: [PATCH 2/2] Update test --- packages/react-devtools-shared/src/__tests__/utils-test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-devtools-shared/src/__tests__/utils-test.js b/packages/react-devtools-shared/src/__tests__/utils-test.js index 83b31903e06..dacbe0f46b9 100644 --- a/packages/react-devtools-shared/src/__tests__/utils-test.js +++ b/packages/react-devtools-shared/src/__tests__/utils-test.js @@ -401,7 +401,7 @@ Object.defineProperty(exports, "__esModule", { value: true }); exports.f = f; function f() { } //# sourceMappingURL=`; - const result = ['', 'http://test/a.mts', 1, 16]; + const result = ['', 'http://test/a.mts', 1, 17]; const fs = { 'http://test/a.mts': `export function f() {}`, 'http://test/a.mjs.map': `{"version":3,"file":"a.mjs","sourceRoot":"","sources":["a.mts"],"names":[],"mappings":";;AAAA,cAAsB;AAAtB,SAAgB,CAAC,KAAI,CAAC"}`,